Attachment 347643 Details for Bug 188795 – Patch

[patch] Patch

bug-188795-20180821084158.patch (text/plain), 2.18 KB, created by Simon Fraser (smfr) on 2018-08-21 08:41:59 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Simon Fraser (smfr)

Created: 2018-08-21 08:41:59 PDT

Size: 2.18 KB

patch

obsolete

>Subversion Revision: 235116
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index ddbe2a91605bebfdd8f2828f8e37bcf901509227..b7c45d9aab3848edc019f45f9bbdee5587add9b2 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-08-21  Simon Fraser  <simon.fraser@apple.com>
>+
>+        REGRESSION(r234993): Test results page ignores TestExpectations, shows 1800 failures
>+        https://bugs.webkit.org/show_bug.cgi?id=188795
>+
>+        Reviewed by NOBODY (OOPS!).
>+        
>+        A MISSING result would trigger a code path that hit appendActualOnlyLinks() which had
>+        a JS error, causing all expected results to be visible. Fix with a change to full_results.json
>+        which tests the change.
>+
>+        * fast/harness/full_results.json:
>+        * fast/harness/results.html:
>+
> 2018-08-20  Fujii Hironori  <Hironori.Fujii@sony.com>
> 
>         Unreviewed WinCairo port test gardening
>diff --git a/LayoutTests/fast/harness/full_results.json b/LayoutTests/fast/harness/full_results.json
>index ed235cec2bbdc9224dd924220133a9e6c9aee828..f446d93a4f6304981e589082705bff31684bcab8 100644
>--- a/LayoutTests/fast/harness/full_results.json
>+++ b/LayoutTests/fast/harness/full_results.json
>@@ -42,6 +42,11 @@ ADD_RESULTS({
>                 "expected": "PASS TIMEOUT",
>                 "actual": "TEXT PASS TIMEOUT"
>             },
>+            "scale-transition-no-start.html": {
>+                "expected": "FAIL MISSING",
>+                "is_missing_text": true,
>+                "actual": "MISSING"
>+            }
>         },
>         "canvas": {
>             "philip": {
>diff --git a/LayoutTests/fast/harness/results.html b/LayoutTests/fast/harness/results.html
>index 4a514069b8a3449e525f065974d016b7dafd3377..f1342be6698f2df08811429257dbcd21abb7c741 100644
>--- a/LayoutTests/fast/harness/results.html
>+++ b/LayoutTests/fast/harness/results.html
>@@ -1234,6 +1234,7 @@ class FailuresSectionBuilder extends SectionBuilder {
>     
>     appendActualOnlyLinks(testResult, cell)
>     {
>+        let prefix = Utils.stripExtension(testResult.name);
>         if (testResult.info.is_missing_audio)
>             cell.innerHTML += TestResultsController.resultLink(prefix, '-actual.wav', 'audio result');
>

Actions: View | Formatted Diff | Diff

Attachments on bug 188795: 347643