Attachment 347630 Details for Bug 188786 – Patch

[patch] Patch

bug-188786-20180821141006.patch (text/plain), 1.75 KB, created by Xabier Rodríguez Calvar on 2018-08-21 05:10:07 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Xabier Rodríguez Calvar

Created: 2018-08-21 05:10:07 PDT

Size: 1.75 KB

patch

obsolete

>Subversion Revision: 235110
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 67ce640d4aef7339fddccf59205b71a98300fcdd..fe93f79a5a263e68b71a1c32eff0e8a4b1f83cc2 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-08-21  Xabier Rodriguez Calvar  <calvaris@igalia.com>
>+
>+        [GStreamer] Extra ASSERTs at MainThreadNotifier
>+        https://bugs.webkit.org/show_bug.cgi?id=188786
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        We add a couple of checks in debug mode:
>+        * There is only one bit on per notification.
>+        * Ensure a notifier was invalidated before being destroyed.
>+
>+        * platform/graphics/gstreamer/MainThreadNotifier.h:
>+
> 2018-08-21  Philippe Normand  <philn@igalia.com>
> 
>         [GStreamer][MSE] Generic main thread notification support
>diff --git a/Source/WebCore/platform/graphics/gstreamer/MainThreadNotifier.h b/Source/WebCore/platform/graphics/gstreamer/MainThreadNotifier.h
>index 3752dc275e719578ebf19596f4fa6bf2fc88f9b5..5eada639b99293e2bba3fd17c81e28638c55ff7d 100644
>--- a/Source/WebCore/platform/graphics/gstreamer/MainThreadNotifier.h
>+++ b/Source/WebCore/platform/graphics/gstreamer/MainThreadNotifier.h
>@@ -35,10 +35,17 @@ public:
>         return adoptRef(*new MainThreadNotifier());
>     }
> 
>+    ~MainThreadNotifier()
>+    {
>+        ASSERT(!m_isValid.load());
>+    }
>+
>     template<typename F>
>     void notify(T notificationType, F&& callbackFunctor)
>     {
>         ASSERT(m_isValid.load());
>+        // Assert that there is only one bit on at a time.
>+        ASSERT(!(static_cast<int>(notificationType) & (static_cast<int>(notificationType) - 1)));
>         if (isMainThread()) {
>             removePendingNotification(notificationType);
>             callbackFunctor();

Actions: View | Formatted Diff | Diff

Attachments on bug 188786: 347630 | 349012