Attachment 347585 Details for Bug 186714 – Patch

[patch] Patch

bug-186714-20180820174123.patch (text/plain), 45.00 KB, created by Aditya Keerthi on 2018-08-20 17:41:23 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Aditya Keerthi

Created: 2018-08-20 17:41:23 PDT

Size: 45.00 KB

patch

obsolete

>Subversion Revision: 235065
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 70bd1a9cd7558064b57c991ae1cbb4050ab43f7a..68a9e2a0b5ce11ce3cbbcdaf5113b46fcbeb305e 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,25 @@
>+2018-08-20  Aditya Keerthi  <akeerthi@apple.com>
>+
>+        [Datalist][iOS] Add suggestions UI for TextFieldInputTypes
>+        https://bugs.webkit.org/show_bug.cgi?id=186714
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        On iOS, the datalist button should appear as a downward triangle. Furthermore, the
>+        button should only be displayed if the input has focus and there are suggested
>+        values.
>+
>+        * css/html.css:
>+        (input::-webkit-list-button): Draw the triangle using an SVG.
>+        * html/DataListSuggestionInformation.h:
>+        * html/HTMLInputElement.h:
>+        * html/TextFieldInputType.cpp: Added logic to show and hide the datalist button as necessary.
>+        (WebCore::TextFieldInputType::handleFocusEvent):
>+        (WebCore::TextFieldInputType::handleBlurEvent):
>+        (WebCore::TextFieldInputType::didSetValueByUserEdit):
>+        (WebCore::TextFieldInputType::listAttributeTargetChanged):
>+        (WebCore::TextFieldInputType::displaySuggestions):
>+
> 2018-08-20  Rob Buis  <rbuis@igalia.com>
> 
>         Throw an exception if window.open() gets passed a URL that cannot be parsed
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 65f4f102ac5f23d0bbaab46c05b406eb0ed4a9bb..4d6904309b39f78a4c1078ce9a7b9d1b2dbc417e 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,94 @@
>+2018-08-20  Aditya Keerthi  <akeerthi@apple.com>
>+
>+        [Datalist][iOS] Add suggestions UI for TextFieldInputTypes
>+        https://bugs.webkit.org/show_bug.cgi?id=186714
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        On iOS, we have less space display suggestions from a datalist element compared to
>+        macOS. Furthermore, iPhones and iPads have different form factors, leading to a
>+        different approach on each device. The commonalities of the two implementations
>+        can be found in WKDataListSuggestionsControl. This class is subclassed by the
>+        device specific implementations.
>+
>+        On iPhone, we display the suggestions in a UIPickerView. This view is accessible
>+        only after tapping on the datalist button element to the side of the input field.
>+        This approach was chosen in order to avoid tricking the user into thinking that
>+        the values displayed in the picker are the only accepted values.
>+        WKDataListSuggestionsPicker is responsible for managing the interface shown on
>+        iPhones.
>+
>+        On iPad, we display the suggestions in a popover, that is visible alongside the
>+        keyboard. The suggestions in the popover update as the user types.
>+        WKDataListSuggestionsPopover is responsible for managing the interface shown on
>+        iPads.
>+
>+        Both devices display predictive text suggestions, taking the first three values
>+        from the filtered suggestions list. In order to prevent other clients from
>+        overwriting the suggestions provided by the datalist element, we prevent writing
>+        to the predictive text bar if an input with the list attribute is the currently
>+        assisted node.
>+
>+        * Shared/AssistedNodeInformation.cpp:
>+        (WebKit::AssistedNodeInformation::encode const):
>+        (WebKit::AssistedNodeInformation::decode):
>+        * Shared/AssistedNodeInformation.h:
>+        * Shared/ios/InteractionInformationAtPosition.h:
>+        * Shared/ios/InteractionInformationAtPosition.mm:
>+        (WebKit::InteractionInformationAtPosition::encode const):
>+        (WebKit::InteractionInformationAtPosition::decode):
>+        * UIProcess/WebDataListSuggestionsDropdownIOS.h: Added.
>+        * UIProcess/WebDataListSuggestionsDropdownIOS.mm: Added.
>+        (WebKit::WebDataListSuggestionsDropdownIOS::create):
>+        (WebKit::WebDataListSuggestionsDropdownIOS::~WebDataListSuggestionsDropdownIOS):
>+        (WebKit::WebDataListSuggestionsDropdownIOS::WebDataListSuggestionsDropdownIOS):
>+        (WebKit::WebDataListSuggestionsDropdownIOS::show):
>+        (WebKit::WebDataListSuggestionsDropdownIOS::handleKeydownWithIdentifier):
>+        (WebKit::WebDataListSuggestionsDropdownIOS::close):
>+        (WebKit::WebDataListSuggestionsDropdownIOS::didSelectOption):
>+        (-[WKDataListSuggestionsControl initWithInformation:inView:]):
>+        (-[WKDataListSuggestionsControl updateWithInformation:]):
>+        (-[WKDataListSuggestionsControl showSuggestionsDropdown:activationType:]):
>+        (-[WKDataListSuggestionsControl didSelectOptionAtIndex:]):
>+        (-[WKDataListSuggestionsControl invalidate]):
>+        (-[WKDataListSuggestionsControl textSuggestions]):
>+        (-[WKDataListSuggestionsControl suggestionsCount]):
>+        (-[WKDataListSuggestionsControl suggestionAtIndex:]):
>+        (-[WKDataListSuggestionsControl textAlignment]):
>+        (-[WKDataListSuggestionsPicker initWithInformation:inView:]):
>+        (-[WKDataListSuggestionsPicker updateWithInformation:]):
>+        (-[WKDataListSuggestionsPicker showSuggestionsDropdown:activationType:]):
>+        (-[WKDataListSuggestionsPicker numberOfComponentsInPickerView:]):
>+        (-[WKDataListSuggestionsPicker pickerView:numberOfRowsInComponent:]):
>+        (-[WKDataListSuggestionsPicker pickerView:titleForRow:forComponent:]):
>+        (-[WKDataListSuggestionsPicker invalidate]):
>+        (-[WKDataListSuggestionsPickerView endEditing]):
>+        (-[WKDataListSuggestionsPopover initWithInformation:inView:]):
>+        (-[WKDataListSuggestionsPopover updateWithInformation:]):
>+        (-[WKDataListSuggestionsPopover showSuggestionsDropdown:activationType:]):
>+        (-[WKDataListSuggestionsPopover invalidate]):
>+        (-[WKDataListSuggestionsPopover didSelectOptionAtIndex:]):
>+        (-[WKDataListSuggestionsViewController reloadData]):
>+        (-[WKDataListSuggestionsViewController tableView:numberOfRowsInSection:]):
>+        (-[WKDataListSuggestionsViewController tableView:cellForRowAtIndexPath:]):
>+        (-[WKDataListSuggestionsViewController tableView:didSelectRowAtIndexPath:]):
>+        * UIProcess/ios/PageClientImplIOS.mm:
>+        (WebKit::PageClientImpl::createDataListSuggestionsDropdown):
>+        * UIProcess/ios/WKContentViewInteraction.h:
>+        * UIProcess/ios/WKContentViewInteraction.mm:
>+        (-[WKFormInputSession setSuggestions:]):
>+        (-[WKContentView _formInputSession]):
>+        (-[WKContentView resignFirstResponderForWebView]):
>+        (-[WKContentView textInteractionGesture:shouldBeginAtPoint:]):
>+        (-[WKContentView accessoryTab:]):
>+        (-[WKContentView insertTextSuggestion:]):
>+        * WebKit.xcodeproj/project.pbxproj:
>+        * WebProcess/WebPage/WebPage.cpp:
>+        (WebKit::WebPage::didCloseSuggestions):
>+        * WebProcess/WebPage/ios/WebPageIOS.mm:
>+        (WebKit::WebPage::getPositionInformation):
>+        (WebKit::WebPage::getAssistedNodeInformation):
>+
> 2018-08-20  Carlos Garcia Campos  <cgarcia@igalia.com>
> 
>         Unreviewed. Fix GTK/WPE cookie API tests after r234396.
>diff --git a/Source/WebCore/css/html.css b/Source/WebCore/css/html.css
>index e6b189e0eca18086631d480f21a1d36efb9683bb..d8e8c89fc36c9c62a99ea95df3a6601918590187 100644
>--- a/Source/WebCore/css/html.css
>+++ b/Source/WebCore/css/html.css
>@@ -626,7 +626,15 @@ input::-webkit-list-button {
>     flex: none;
>     -webkit-user-select: none;
>     width: 16px;
>+#if defined(WTF_PLATFORM_IOS) && WTF_PLATFORM_IOS
>+    content: url('data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" stroke="black" fill="black" width="16" height="16"><polygon points="8 11.031, 4.5 4.969, 11.5 4.969"/></svg>');
>+    /* Make it easier to hit the button on iOS */
>+    padding: 7px;
>+    margin: -7px;
>+    z-index: 2147483645;
>+#else
>     height: 100%;
>+#endif
> }
> #endif
> 
>diff --git a/Source/WebCore/html/DataListSuggestionInformation.h b/Source/WebCore/html/DataListSuggestionInformation.h
>index 8c449ef9994c603cc4f5ec8a5ad993950a0559fe..579451a59832fddffc9b98f40cd9595568cefc6d 100644
>--- a/Source/WebCore/html/DataListSuggestionInformation.h
>+++ b/Source/WebCore/html/DataListSuggestionInformation.h
>@@ -26,6 +26,7 @@
> #pragma once
> 
> #include "IntRect.h"
>+#include <wtf/Vector.h>
> 
> #if ENABLE(DATALIST_ELEMENT)
> namespace WebCore {
>diff --git a/Source/WebCore/html/HTMLInputElement.h b/Source/WebCore/html/HTMLInputElement.h
>index e32b3893eb4ac796c66e08c1bda7f3e4729ec8d3..4ce89b16003ee5efb98a0c8f7c3e39083a204a28 100644
>--- a/Source/WebCore/html/HTMLInputElement.h
>+++ b/Source/WebCore/html/HTMLInputElement.h
>@@ -151,7 +151,7 @@ public:
>     HTMLElement* placeholderElement() const final;
>     WEBCORE_EXPORT HTMLElement* autoFillButtonElement() const;
> #if ENABLE(DATALIST_ELEMENT)
>-    HTMLElement* dataListButtonElement() const;
>+    WEBCORE_EXPORT HTMLElement* dataListButtonElement() const;
> #endif
> 
>     bool checked() const { return m_isChecked; }
>diff --git a/Source/WebCore/html/TextFieldInputType.cpp b/Source/WebCore/html/TextFieldInputType.cpp
>index 13c31ba61aa2accf320e63d20a1314d0485fffbb..c9846c499e831388fd05799326b42f2d6d0e6872 100644
>--- a/Source/WebCore/html/TextFieldInputType.cpp
>+++ b/Source/WebCore/html/TextFieldInputType.cpp
>@@ -260,8 +260,13 @@ void TextFieldInputType::handleFocusEvent(Node* oldFocusedNode, FocusDirection)
> {
>     ASSERT(element());
>     ASSERT_UNUSED(oldFocusedNode, oldFocusedNode != element());
>-    if (RefPtr<Frame> frame = element()->document().frame())
>+    if (RefPtr<Frame> frame = element()->document().frame()) {
>         frame->editor().textFieldDidBeginEditing(element());
>+#if ENABLE(DATALIST_ELEMENT) && PLATFORM(IOS)
>+        if (element()->list() && m_dataListDropdownIndicator)
>+            m_dataListDropdownIndicator->setInlineStyleProperty(CSSPropertyDisplay, suggestions().size() ? CSSValueBlock : CSSValueNone, true);
>+#endif
>+    }
> }
> 
> void TextFieldInputType::handleBlurEvent()
>@@ -269,6 +274,10 @@ void TextFieldInputType::handleBlurEvent()
>     InputType::handleBlurEvent();
>     ASSERT(element());
>     element()->endEditing();
>+#if ENABLE(DATALIST_ELEMENT) && PLATFORM(IOS)
>+    if (element()->list() && m_dataListDropdownIndicator)
>+        m_dataListDropdownIndicator->setInlineStyleProperty(CSSPropertyDisplay, CSSValueNone, true);
>+#endif
> }
> 
> bool TextFieldInputType::shouldSubmitImplicitly(Event& event)
>@@ -648,6 +657,10 @@ void TextFieldInputType::didSetValueByUserEdit()
>     if (RefPtr<Frame> frame = element()->document().frame())
>         frame->editor().textDidChangeInTextField(element());
> #if ENABLE(DATALIST_ELEMENT)
>+#if PLATFORM(IOS)
>+    if (element()->list() && m_dataListDropdownIndicator)
>+        m_dataListDropdownIndicator->setInlineStyleProperty(CSSPropertyDisplay, suggestions().size() ? CSSValueBlock : CSSValueNone, true);
>+#endif
>     if (element()->list())
>         displaySuggestions(DataListSuggestionActivationType::TextChanged);
> #endif
>@@ -802,7 +815,9 @@ void TextFieldInputType::listAttributeTargetChanged()
>     if (!m_dataListDropdownIndicator)
>         return;
> 
>+#if !PLATFORM(IOS)
>     m_dataListDropdownIndicator->setInlineStyleProperty(CSSPropertyDisplay, element()->list() ? CSSValueBlock : CSSValueNone, true);
>+#endif
> }
> 
> HTMLElement* TextFieldInputType::dataListButtonElement() const
>@@ -859,8 +874,10 @@ void TextFieldInputType::displaySuggestions(DataListSuggestionActivationType typ
>     if (element()->isDisabledFormControl() || !element()->renderer())
>         return;
> 
>+#if !PLATFORM(IOS)
>     if (!UserGestureIndicator::processingUserGesture())
>         return;
>+#endif
> 
>     if (!m_suggestionPicker && suggestions().size() > 0)
>         m_suggestionPicker = chrome()->createDataListSuggestionPicker(*this);
>diff --git a/Source/WebKit/Shared/AssistedNodeInformation.cpp b/Source/WebKit/Shared/AssistedNodeInformation.cpp
>index 79adb680fe47121d129f9241d7e66afb2abed0d5..6b780191b53ec30f794718cd68b9200b188fb8c3 100644
>--- a/Source/WebKit/Shared/AssistedNodeInformation.cpp
>+++ b/Source/WebKit/Shared/AssistedNodeInformation.cpp
>@@ -96,9 +96,12 @@ void AssistedNodeInformation::encode(IPC::Encoder& encoder) const
>     encoder << label;
>     encoder << ariaLabel;
>     encoder << assistedNodeIdentifier;
>-#if ENABLE(INPUT_TYPE_COLOR) && ENABLE(DATALIST_ELEMENT)
>+#if ENABLE(DATALIST_ELEMENT)
>+    encoder << hasSuggestions;
>+#if ENABLE(INPUT_TYPE_COLOR)
>     encoder << suggestedColors;
> #endif
>+#endif
> }
> 
> bool AssistedNodeInformation::decode(IPC::Decoder& decoder, AssistedNodeInformation& result)
>@@ -202,9 +205,14 @@ bool AssistedNodeInformation::decode(IPC::Decoder& decoder, AssistedNodeInformat
>     if (!decoder.decode(result.assistedNodeIdentifier))
>         return false;
> 
>-#if ENABLE(INPUT_TYPE_COLOR) && ENABLE(DATALIST_ELEMENT)
>+#if ENABLE(DATALIST_ELEMENT)
>+    if (!decoder.decode(result.hasSuggestions))
>+        return false;
>+
>+#if ENABLE(INPUT_TYPE_COLOR)
>     if (!decoder.decode(result.suggestedColors))
>         return false;
>+#endif
> #endif
> 
>     return true;
>diff --git a/Source/WebKit/Shared/AssistedNodeInformation.h b/Source/WebKit/Shared/AssistedNodeInformation.h
>index 1e7aac77b008194d19418404116cea24a1ce31fd..c371731fae887daa7538b41db49b71f52aed4c31 100644
>--- a/Source/WebKit/Shared/AssistedNodeInformation.h
>+++ b/Source/WebKit/Shared/AssistedNodeInformation.h
>@@ -123,8 +123,11 @@ struct AssistedNodeInformation {
>     String placeholder;
>     String label;
>     String ariaLabel;
>-#if ENABLE(INPUT_TYPE_COLOR) && ENABLE(DATALIST_ELEMENT)
>+#if ENABLE(DATALIST_ELEMENT)
>+    bool hasSuggestions { false };
>+#if ENABLE(INPUT_TYPE_COLOR)
>     Vector<WebCore::Color> suggestedColors;
>+#endif
> #endif
> 
>     uint64_t assistedNodeIdentifier { 0 };
>diff --git a/Source/WebKit/Shared/ios/InteractionInformationAtPosition.h b/Source/WebKit/Shared/ios/InteractionInformationAtPosition.h
>index 9b9533e072da80dc3ddbc1bd01c51b270cb3f29c..3d08689fe176dd7a6172a137c0583dcea7372f63 100644
>--- a/Source/WebKit/Shared/ios/InteractionInformationAtPosition.h
>+++ b/Source/WebKit/Shared/ios/InteractionInformationAtPosition.h
>@@ -55,6 +55,9 @@ struct InteractionInformationAtPosition {
>     bool isElement { false };
> #if ENABLE(DATA_DETECTION)
>     bool isDataDetectorLink { false };
>+#endif
>+#if ENABLE(DATALIST_ELEMENT)
>+    bool preventTextInteraction { false };
> #endif
>     WebCore::FloatPoint adjustedPointForNodeRespondingToClickEvents;
>     WebCore::URL url;
>diff --git a/Source/WebKit/Shared/ios/InteractionInformationAtPosition.mm b/Source/WebKit/Shared/ios/InteractionInformationAtPosition.mm
>index caf3b3e578928428e7466133567e56a51d28f1cd..a39af222582aa657c27ede069c5c36e25bb61ad6 100644
>--- a/Source/WebKit/Shared/ios/InteractionInformationAtPosition.mm
>+++ b/Source/WebKit/Shared/ios/InteractionInformationAtPosition.mm
>@@ -82,6 +82,9 @@ void InteractionInformationAtPosition::encode(IPC::Encoder& encoder) const
>         IPC::encode(encoder, reinterpret_cast<CFDataRef>(archiver.get().encodedData));
>     }
> #endif
>+#if ENABLE(DATALIST_ELEMENT)
>+    encoder << preventTextInteraction;
>+#endif
> }
> 
> bool InteractionInformationAtPosition::decode(IPC::Decoder& decoder, InteractionInformationAtPosition& result)
>@@ -186,6 +189,11 @@ bool InteractionInformationAtPosition::decode(IPC::Decoder& decoder, Interaction
>     }
> #endif
> 
>+#if ENABLE(DATALIST_ELEMENT)
>+    if (!decoder.decode(result.preventTextInteraction))
>+        return false;
>+#endif
>+
>     return true;
> }
> 
>diff --git a/Source/WebKit/UIProcess/WebDataListSuggestionsDropdownIOS.h b/Source/WebKit/UIProcess/WebDataListSuggestionsDropdownIOS.h
>new file mode 100644
>index 0000000000000000000000000000000000000000..377f6725eab7308000dc476e4c77c5c250c40184
>--- /dev/null
>+++ b/Source/WebKit/UIProcess/WebDataListSuggestionsDropdownIOS.h
>@@ -0,0 +1,60 @@
>+/*
>+ * Copyright (C) 2018 Apple Inc. All rights reserved.
>+ *
>+ * Redistribution and use in source and binary forms, with or without
>+ * modification, are permitted provided that the following conditions
>+ * are met:
>+ * 1. Redistributions of source code must retain the above copyright
>+ *    notice, this list of conditions and the following disclaimer.
>+ * 2. Redistributions in binary form must reproduce the above copyright
>+ *    notice, this list of conditions and the following disclaimer in the
>+ *    documentation and/or other materials provided with the distribution.
>+ *
>+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
>+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
>+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
>+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
>+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
>+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
>+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
>+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
>+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
>+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
>+ * THE POSSIBILITY OF SUCH DAMAGE.
>+ */
>+
>+#pragma once
>+
>+#if ENABLE(DATALIST_ELEMENT) && PLATFORM(IOS)
>+
>+#import "WebDataListSuggestionsDropdown.h"
>+#include <wtf/RetainPtr.h>
>+#include <wtf/Vector.h>
>+
>+OBJC_CLASS WKContentView;
>+OBJC_CLASS WKDataListTextSuggestion;
>+OBJC_CLASS WKDataListSuggestionsControl;
>+
>+namespace WebKit {
>+
>+class WebDataListSuggestionsDropdownIOS : public WebDataListSuggestionsDropdown {
>+public:
>+    static Ref<WebDataListSuggestionsDropdownIOS> create(WebDataListSuggestionsDropdown::Client&, WKContentView *);
>+    ~WebDataListSuggestionsDropdownIOS();
>+
>+    void didSelectOption(String&);
>+
>+private:
>+    WebDataListSuggestionsDropdownIOS(WebDataListSuggestionsDropdown::Client&, WKContentView *);
>+
>+    void show(WebCore::DataListSuggestionInformation&&) final;
>+    void handleKeydownWithIdentifier(const String&) final;
>+    void close() final;
>+
>+    WKContentView *m_contentView;
>+    RetainPtr<WKDataListSuggestionsControl> m_suggestionsControl;
>+};
>+
>+} // namespace WebKit
>+
>+#endif // ENABLE(DATALIST_ELEMENT) && PLATFORM(IOS)
>diff --git a/Source/WebKit/UIProcess/WebDataListSuggestionsDropdownIOS.mm b/Source/WebKit/UIProcess/WebDataListSuggestionsDropdownIOS.mm
>new file mode 100644
>index 0000000000000000000000000000000000000000..1570dec966bc9c3dc54449138dba3c1fec91053b
>--- /dev/null
>+++ b/Source/WebKit/UIProcess/WebDataListSuggestionsDropdownIOS.mm
>@@ -0,0 +1,382 @@
>+/*
>+ * Copyright (C) 2018 Apple Inc. All rights reserved.
>+ *
>+ * Redistribution and use in source and binary forms, with or without
>+ * modification, are permitted provided that the following conditions
>+ * are met:
>+ * 1. Redistributions of source code must retain the above copyright
>+ *    notice, this list of conditions and the following disclaimer.
>+ * 2. Redistributions in binary form must reproduce the above copyright
>+ *    notice, this list of conditions and the following disclaimer in the
>+ *    documentation and/or other materials provided with the distribution.
>+ *
>+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
>+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
>+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
>+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
>+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
>+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
>+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
>+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
>+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
>+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
>+ * THE POSSIBILITY OF SUCH DAMAGE.
>+ */
>+
>+#include "config.h"
>+#include "WebDataListSuggestionsDropdownIOS.h"
>+
>+#if ENABLE(DATALIST_ELEMENT) && PLATFORM(IOS)
>+
>+#import "UIKitSPI.h"
>+#import "WKContentView.h"
>+#import "WKContentViewInteraction.h"
>+#import "WKFormPopover.h"
>+#import "_WKFormInputSession.h"
>+
>+static const CGFloat maxVisibleSuggestions = 5;
>+static const CGFloat suggestionsPopoverCellHeight = 44;
>+static const CGFloat suggestionsPopoverWidth = 320;
>+static NSString * const suggestionCellReuseIdentifier = @"WKDataListSuggestionCell";
>+
>+@interface WKFormInputSession ()
>+- (void)setCustomInputView:(UIView *)customInputView;
>+- (void)setSuggestions:(NSArray<UITextSuggestion *> *)suggestions;
>+@end
>+
>+@interface WKContentView ()
>+- (WKFormInputSession *)_formInputSession;
>+@end
>+
>+@interface WKDataListSuggestionsControl : NSObject {
>+    WebKit::WebDataListSuggestionsDropdownIOS* _dropdown;
>+    Vector<String> _suggestions;
>+}
>+
>+@property (nonatomic, weak) WKContentView *view;
>+
>+- (instancetype)initWithInformation:(WebCore::DataListSuggestionInformation&&)information inView:(WKContentView *)view;
>+- (void)updateWithInformation:(WebCore::DataListSuggestionInformation&&)information;
>+- (void)showSuggestionsDropdown:(WebKit::WebDataListSuggestionsDropdownIOS *)dropdown activationType:(WebCore::DataListSuggestionActivationType)activationType;
>+- (void)didSelectOptionAtIndex:(NSInteger)index;
>+- (void)invalidate;
>+
>+- (NSArray<WKDataListTextSuggestion *> *)textSuggestions;
>+- (NSInteger)suggestionsCount;
>+- (String)suggestionAtIndex:(NSInteger)index;
>+- (NSTextAlignment)textAlignment;
>+@end
>+
>+@interface WKDataListSuggestionsPicker : WKDataListSuggestionsControl <UIPickerViewDataSource, UIPickerViewDelegate>
>+@end
>+
>+@interface WKDataListSuggestionsPickerView : UIPickerView
>+@property (nonatomic, weak) WKDataListSuggestionsControl *control;
>+
>+- (void)endEditing;
>+@end
>+
>+@interface WKDataListSuggestionsPopover : WKDataListSuggestionsControl
>+@end
>+
>+@interface WKDataListSuggestionsViewController : UITableViewController
>+@property (nonatomic, weak) WKDataListSuggestionsControl *control;
>+
>+- (void)reloadData;
>+@end
>+
>+@interface WKDataListTextSuggestion : UITextSuggestion
>+@end
>+
>+@implementation WKDataListTextSuggestion
>+@end
>+
>+#pragma mark - WebDataListSuggestionsDropdownIOS
>+
>+namespace WebKit {
>+
>+Ref<WebDataListSuggestionsDropdownIOS> WebDataListSuggestionsDropdownIOS::create(WebDataListSuggestionsDropdown::Client& client, WKContentView *view)
>+{
>+    return adoptRef(*new WebDataListSuggestionsDropdownIOS(client, view));
>+}
>+
>+WebDataListSuggestionsDropdownIOS::~WebDataListSuggestionsDropdownIOS() { }
>+
>+WebDataListSuggestionsDropdownIOS::WebDataListSuggestionsDropdownIOS(WebDataListSuggestionsDropdown::Client& client, WKContentView *view)
>+    : WebDataListSuggestionsDropdown(client)
>+    , m_contentView(view)
>+{
>+}
>+
>+void WebDataListSuggestionsDropdownIOS::show(WebCore::DataListSuggestionInformation&& information)
>+{
>+    if (m_suggestionsControl) {
>+        [m_suggestionsControl updateWithInformation:WTFMove(information)];
>+        return;
>+    }
>+
>+    if (currentUserInterfaceIdiomIsPad())
>+        m_suggestionsControl = adoptNS([[WKDataListSuggestionsPopover alloc] initWithInformation:WTFMove(information) inView:m_contentView]);
>+    else
>+        m_suggestionsControl = adoptNS([[WKDataListSuggestionsPicker alloc] initWithInformation:WTFMove(information) inView:m_contentView]);
>+
>+    [m_suggestionsControl showSuggestionsDropdown:this activationType:information.activationType];
>+}
>+
>+void WebDataListSuggestionsDropdownIOS::handleKeydownWithIdentifier(const String&)
>+{
>+}
>+
>+void WebDataListSuggestionsDropdownIOS::close()
>+{
>+    [m_suggestionsControl invalidate];
>+    m_suggestionsControl = nil;
>+    m_client->didCloseSuggestions();
>+}
>+
>+void WebDataListSuggestionsDropdownIOS::didSelectOption(String& selectedOption)
>+{
>+    if (!m_client)
>+        return;
>+
>+    m_client->didSelectOption(selectedOption);
>+    close();
>+}
>+
>+} // namespace WebKit
>+
>+#pragma mark - WKDataListSuggestionsControl
>+
>+@implementation WKDataListSuggestionsControl
>+
>+- (instancetype)initWithInformation:(WebCore::DataListSuggestionInformation&&)information inView:(WKContentView *)view
>+{
>+    if (!(self = [super init]))
>+        return nil;
>+
>+    _view = view;
>+    _suggestions = WTFMove(information.suggestions);
>+
>+    return self;
>+}
>+
>+- (void)updateWithInformation:(WebCore::DataListSuggestionInformation&&)information
>+{
>+    _suggestions = WTFMove(information.suggestions);
>+}
>+
>+- (void)showSuggestionsDropdown:(WebKit::WebDataListSuggestionsDropdownIOS *)dropdown activationType:(WebCore::DataListSuggestionActivationType)activationType
>+{
>+    _dropdown = dropdown;
>+}
>+
>+- (void)didSelectOptionAtIndex:(NSInteger)index
>+{
>+    _dropdown->didSelectOption(_suggestions[index]);
>+}
>+
>+- (void)invalidate
>+{
>+}
>+
>+- (NSArray<WKDataListTextSuggestion *> *)textSuggestions
>+{
>+    NSMutableArray *suggestions = [NSMutableArray array];
>+
>+    for (auto suggestion : _suggestions) {
>+        [suggestions addObject:[WKDataListTextSuggestion textSuggestionWithInputText:suggestion]];
>+        if (suggestions.count == 3)
>+            break;
>+    }
>+
>+    return suggestions;
>+}
>+
>+- (NSInteger)suggestionsCount
>+{
>+    return _suggestions.size();
>+}
>+
>+- (String)suggestionAtIndex:(NSInteger)index
>+{
>+    return _suggestions[index];
>+}
>+
>+- (NSTextAlignment)textAlignment
>+{
>+    return _view.assistedNodeInformation.isRTL ? NSTextAlignmentRight : NSTextAlignmentLeft;
>+}
>+
>+@end
>+
>+#pragma mark - WKDataListSuggestionsPicker
>+
>+@implementation WKDataListSuggestionsPicker  {
>+    RetainPtr<WKDataListSuggestionsPickerView> _pickerView;
>+}
>+
>+- (instancetype)initWithInformation:(WebCore::DataListSuggestionInformation&&)information inView:(WKContentView *)view
>+{
>+    if (!(self = [super initWithInformation:WTFMove(information) inView:view]))
>+        return nil;
>+
>+    _pickerView = adoptNS([[WKDataListSuggestionsPickerView alloc] initWithFrame:CGRectZero]);
>+    [_pickerView setAutoresizingMask:UIViewAutoresizingFlexibleWidth | UIViewAutoresizingFlexibleHeight];
>+    [_pickerView setDataSource:self];
>+    [_pickerView setDelegate:self];
>+    [_pickerView setControl:self];
>+    [_pickerView setSize:[UIKeyboard defaultSizeForInterfaceOrientation:UIApp.interfaceOrientation]];
>+
>+    return self;
>+}
>+
>+- (void)updateWithInformation:(WebCore::DataListSuggestionInformation&&)information
>+{
>+    [super updateWithInformation:WTFMove(information)];
>+    if (information.activationType != WebCore::DataListSuggestionActivationType::IndicatorClicked) {
>+        [[self.view _formInputSession] setCustomInputView:nil];
>+        [[self.view _formInputSession] setSuggestions:[self textSuggestions]];
>+        return;
>+    }
>+
>+    [[self.view _formInputSession] setCustomInputView:_pickerView.get()];
>+
>+    [_pickerView reloadAllComponents];
>+    [_pickerView selectRow:0 inComponent:0 animated:NO];
>+}
>+
>+- (void)showSuggestionsDropdown:(WebKit::WebDataListSuggestionsDropdownIOS *)dropdown activationType:(WebCore::DataListSuggestionActivationType)activationType
>+{
>+    [super showSuggestionsDropdown:dropdown activationType:activationType];
>+    if (activationType == WebCore::DataListSuggestionActivationType::IndicatorClicked) {
>+        [[self.view _formInputSession] setCustomInputView:_pickerView.get()];
>+        [_pickerView selectRow:0 inComponent:0 animated:NO];
>+    } else
>+        [[self.view _formInputSession] setSuggestions:[self textSuggestions]];
>+}
>+
>+- (NSInteger)numberOfComponentsInPickerView:(UIPickerView *)pickerView
>+{
>+    return 1;
>+}
>+
>+- (NSInteger)pickerView:(UIPickerView *)pickerView numberOfRowsInComponent:(NSInteger)columnIndex
>+{
>+    return [self suggestionsCount];
>+}
>+
>+- (NSString *)pickerView:(UIPickerView *)pickerView titleForRow:(NSInteger)row forComponent:(NSInteger)component
>+{
>+    return [self suggestionAtIndex:row];
>+}
>+
>+- (void)invalidate
>+{
>+    if ([[self.view _formInputSession] customInputView] == _pickerView.get())
>+        [[self.view _formInputSession] setCustomInputView:nil];
>+
>+    [_pickerView setDelegate:nil];
>+    [_pickerView setDataSource:nil];
>+    [_pickerView setControl:nil];
>+}
>+
>+@end
>+
>+@implementation WKDataListSuggestionsPickerView
>+
>+- (void)endEditing
>+{
>+    [self.control didSelectOptionAtIndex:[self selectedRowInComponent:0]];
>+}
>+
>+@end
>+
>+#pragma mark - WKDataListSuggestionsPopover
>+
>+@implementation WKDataListSuggestionsPopover  {
>+    RetainPtr<WKFormRotatingAccessoryPopover> _popover;
>+    RetainPtr<WKDataListSuggestionsViewController> _suggestionsViewController;
>+}
>+
>+- (instancetype)initWithInformation:(WebCore::DataListSuggestionInformation&&)information inView:(WKContentView *)view
>+{
>+    if (!(self = [super initWithInformation:WTFMove(information) inView:view]))
>+        return nil;
>+
>+    _popover = adoptNS([[WKFormRotatingAccessoryPopover alloc] initWithView:view]);
>+
>+    return self;
>+}
>+
>+- (void)updateWithInformation:(WebCore::DataListSuggestionInformation&&)information
>+{
>+    [super updateWithInformation:WTFMove(information)];
>+    [_suggestionsViewController reloadData];
>+    [[self.view _formInputSession] setSuggestions:[self textSuggestions]];
>+}
>+
>+- (void)showSuggestionsDropdown:(WebKit::WebDataListSuggestionsDropdownIOS *)dropdown activationType:(WebCore::DataListSuggestionActivationType)activationType
>+{
>+    [super showSuggestionsDropdown:dropdown activationType:activationType];
>+
>+    _suggestionsViewController = adoptNS([[WKDataListSuggestionsViewController alloc] initWithStyle:UITableViewStylePlain]);
>+    [_suggestionsViewController setControl:self];
>+    [_suggestionsViewController reloadData];
>+    [[self.view _formInputSession] setSuggestions:[self textSuggestions]];
>+
>+#pragma clang diagnostic push
>+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
>+    [_popover setPopoverController:[[[UIPopoverController alloc] initWithContentViewController:_suggestionsViewController.get()] autorelease]];
>+#pragma clang diagnostic pop
>+
>+    [_popover presentPopoverAnimated:NO];
>+}
>+
>+- (void)invalidate
>+{
>+    [_suggestionsViewController setControl:nil];
>+}
>+
>+- (void)didSelectOptionAtIndex:(NSInteger)index
>+{
>+    [super didSelectOptionAtIndex:index];
>+    [[_popover popoverController] dismissPopoverAnimated:YES];
>+    [[self.view _formInputSession] setSuggestions:@[[WKDataListTextSuggestion textSuggestionWithInputText:[self suggestionAtIndex:index]]]];
>+}
>+
>+@end
>+
>+@implementation WKDataListSuggestionsViewController
>+
>+- (void)reloadData
>+{
>+    [self.tableView reloadData];
>+    [self setPreferredContentSize:CGSizeMake(suggestionsPopoverWidth, maxVisibleSuggestions * suggestionsPopoverCellHeight + suggestionsPopoverCellHeight / 2)];
>+}
>+
>+- (NSInteger)tableView:(UITableView *)tableView numberOfRowsInSection:(NSInteger)section
>+{
>+    return [self.control suggestionsCount];
>+}
>+
>+- (UITableViewCell *)tableView:(UITableView *)tableView cellForRowAtIndexPath:(NSIndexPath *)indexPath
>+{
>+    UITableViewCell *cell = [tableView dequeueReusableCellWithIdentifier:suggestionCellReuseIdentifier];
>+    if (!cell)
>+        cell = [[[UITableViewCell alloc] initWithStyle:UITableViewCellStyleDefault reuseIdentifier:suggestionCellReuseIdentifier] autorelease];
>+
>+    [cell.textLabel setText:[self.control suggestionAtIndex:indexPath.row]];
>+    [cell.textLabel setLineBreakMode:NSLineBreakByTruncatingTail];
>+    [cell.textLabel setTextAlignment:[self.control textAlignment]];
>+
>+    return cell;
>+}
>+
>+- (void)tableView:(UITableView *)tableView didSelectRowAtIndexPath:(NSIndexPath *)indexPath
>+{
>+    [self.control didSelectOptionAtIndex:indexPath.row];
>+}
>+
>+@end
>+
>+#endif // ENABLE(DATALIST_ELEMENT) && PLATFORM(IOS)
>diff --git a/Source/WebKit/UIProcess/ios/PageClientImplIOS.mm b/Source/WebKit/UIProcess/ios/PageClientImplIOS.mm
>index f90a2f8a755d9b638244566ddd096270703e2115..bd9a65970f9d2fca085473a5667a914f7a546ce3 100644
>--- a/Source/WebKit/UIProcess/ios/PageClientImplIOS.mm
>+++ b/Source/WebKit/UIProcess/ios/PageClientImplIOS.mm
>@@ -48,6 +48,7 @@
> #import "WKWebViewContentProviderRegistry.h"
> #import "WKWebViewInternal.h"
> #import "WebContextMenuProxy.h"
>+#import "WebDataListSuggestionsDropdownIOS.h"
> #import "WebEditCommandProxy.h"
> #import "WebProcessProxy.h"
> #import "_WKDownloadInternal.h"
>@@ -775,7 +776,7 @@ RefPtr<WebColorPicker> PageClientImpl::createColorPicker(WebPageProxy*, const We
> #if ENABLE(DATALIST_ELEMENT)
> RefPtr<WebDataListSuggestionsDropdown> PageClientImpl::createDataListSuggestionsDropdown(WebPageProxy& page)
> {
>-    return nullptr;
>+    return WebDataListSuggestionsDropdownIOS::create(page, m_contentView);
> }
> #endif
> 
>diff --git a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
>index cc45c5cff220d325765f0a0721e11b9985149469..0ec791904a355ea8b78d0eb81a25e00e189cf595 100644
>--- a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
>+++ b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
>@@ -39,6 +39,7 @@
> #import "WKFormPeripheral.h"
> #import "WKKeyboardScrollingAnimator.h"
> #import "WKSyntheticClickTapGestureRecognizer.h"
>+#import "_WKFormInputSession.h"
> #import <UIKit/UIView.h>
> #import <WebCore/Color.h>
> #import <WebCore/FloatQuad.h>
>@@ -141,6 +142,15 @@ struct WKAutoCorrectionData {
> 
> }
> 
>+@class WKFocusedElementInfo;
>+
>+@interface WKFormInputSession : NSObject <_WKFormInputSession>
>+
>+- (instancetype)initWithContentView:(WKContentView *)view focusedElementInfo:(WKFocusedElementInfo *)elementInfo requiresStrongPasswordAssistance:(BOOL)requiresStrongPasswordAssistance;
>+- (void)invalidate;
>+
>+@end
>+
> @interface WKContentView () {
>     RetainPtr<UIWebTouchEventsGestureRecognizer> _touchEventGestureRecognizer;
> 
>diff --git a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>index e829d450125f07c8523a739360a8016566a1f968..a04ae9d0fae7511871997f88d0a48fc185e634d3 100644
>--- a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>+++ b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>@@ -67,7 +67,6 @@
> #import "_WKActivatedElementInfoInternal.h"
> #import "_WKElementAction.h"
> #import "_WKFocusedElementInfo.h"
>-#import "_WKFormInputSession.h"
> #import "_WKInputDelegate.h"
> #import <CoreText/CTFont.h>
> #import <CoreText/CTFontDescriptor.h>
>@@ -283,13 +282,6 @@ const CGFloat minimumTapHighlightRadius = 2.0;
> - (instancetype)initWithAssistedNodeInformation:(const AssistedNodeInformation&)information isUserInitiated:(BOOL)isUserInitiated userObject:(NSObject <NSSecureCoding> *)userObject;
> @end
> 
>-@interface WKFormInputSession : NSObject <_WKFormInputSession>
>-
>-- (instancetype)initWithContentView:(WKContentView *)view focusedElementInfo:(WKFocusedElementInfo *)elementInfo requiresStrongPasswordAssistance:(BOOL)requiresStrongPasswordAssistance;
>-- (void)invalidate;
>-
>-@end
>-
> @implementation WKFormInputSession {
>     WeakObjCPtr<WKContentView> _contentView;
>     RetainPtr<WKFocusedElementInfo> _focusedElementInfo;
>@@ -391,6 +383,15 @@ const CGFloat minimumTapHighlightRadius = 2.0;
> 
> - (void)setSuggestions:(NSArray<UITextSuggestion *> *)suggestions
> {
>+    // Suggestions that come from a <datalist> should not be overwritten by other clients.
>+#if ENABLE(DATALIST_ELEMENT)
>+    if (_contentView.get()
>+        && [_contentView assistedNodeInformation].hasSuggestions
>+        && ![suggestions.firstObject isKindOfClass:NSClassFromString(@"WKDataListTextSuggestion")]) {
>+        return;
>+    }
>+#endif
>+
>     id <UITextInputSuggestionDelegate> suggestionDelegate = (id <UITextInputSuggestionDelegate>)[_contentView inputDelegate];
>     _suggestions = adoptNS([suggestions copy]);
>     [suggestionDelegate setSuggestions:suggestions];
>@@ -594,6 +595,11 @@ static inline bool hasAssistedNode(WebKit::AssistedNodeInformation assistedNodeI
>     return (assistedNodeInformation.elementType != InputType::None);
> }
> 
>+- (WKFormInputSession *)_formInputSession
>+{
>+    return _formInputSession.get();
>+}
>+
> - (void)_createAndConfigureDoubleTapGestureRecognizer
> {
>     _doubleTapGestureRecognizer = adoptNS([[UITapGestureRecognizer alloc] initWithTarget:self action:@selector(_doubleTapRecognized:)]);
>@@ -994,6 +1000,9 @@ static inline bool hasAssistedNode(WebKit::AssistedNodeInformation assistedNodeI
>     if (!_webView->_activeFocusedStateRetainCount) {
>         // We need to complete the editing operation before we blur the element.
>         [_inputPeripheral endEditing];
>+        if ([[_formInputSession customInputView] respondsToSelector:@selector(endEditing)])
>+            [[_formInputSession customInputView] performSelector:@selector(endEditing)];
>+
>         _page->blurAssistedNode();
>     }
> 
>@@ -1738,6 +1747,11 @@ static inline bool isSamePair(UIGestureRecognizer *a, UIGestureRecognizer *b, UI
>     }
> #endif
> 
>+#if ENABLE(DATALIST_ELEMENT)
>+    if (_positionInformation.preventTextInteraction)
>+        return NO;
>+#endif
>+
>     // If we're currently editing an assisted node, only allow the selection to move within that assisted node.
>     if (self.isAssistingNode)
>         return _positionInformation.nodeAtPositionIsAssistedNode;
>@@ -3098,6 +3112,9 @@ static void selectionChangedWithTouch(WKContentView *view, const WebCore::IntPoi
> 
> - (void)accessoryTab:(BOOL)isNext
> {
>+    if ([[_formInputSession customInputView] respondsToSelector:@selector(endEditing)])
>+        [[_formInputSession customInputView] performSelector:@selector(endEditing)];
>+
>     [_inputPeripheral endEditing];
>     _inputPeripheral = nil;
> 
>@@ -3108,7 +3125,6 @@ static void selectionChangedWithTouch(WKContentView *view, const WebCore::IntPoi
>         [view endSelectionChange];
>         [view reloadInputViews];
>     });
>-
> }
> 
> - (void)_becomeFirstResponderWithSelectionMovingForward:(BOOL)selectingForward completionHandler:(void (^)(BOOL didBecomeFirstResponder))completionHandler
>@@ -3207,6 +3223,12 @@ static void selectionChangedWithTouch(WKContentView *view, const WebCore::IntPoi
>         _page->autofillLoginCredentials([(UITextAutofillSuggestion *)textSuggestion username], [(UITextAutofillSuggestion *)textSuggestion password]);
>         return;
>     }
>+#if ENABLE(DATALIST_ELEMENT)
>+    if ([textSuggestion isKindOfClass:NSClassFromString(@"WKDataListTextSuggestion")]) {
>+        _page->setAssistedNodeValue([textSuggestion inputText]);
>+        return;
>+    }
>+#endif
>     id <_WKInputDelegate> inputDelegate = [_webView _inputDelegate];
>     if ([inputDelegate respondsToSelector:@selector(_webView:insertTextSuggestion:inInputSession:)])
>         [inputDelegate _webView:_webView insertTextSuggestion:textSuggestion inInputSession:_formInputSession.get()];
>diff --git a/Source/WebKit/WebKit.xcodeproj/project.pbxproj b/Source/WebKit/WebKit.xcodeproj/project.pbxproj
>index 6bd98ba4602cff129c24187fc3d2dd6642197da4..f46660f27350ad6170b41931fce641fd35b084e0 100644
>--- a/Source/WebKit/WebKit.xcodeproj/project.pbxproj
>+++ b/Source/WebKit/WebKit.xcodeproj/project.pbxproj
>@@ -2170,6 +2170,8 @@
> 		E548EBD121015F0E00BE3C32 /* WKFormColorPicker.h in Headers */ = {isa = PBXBuildFile; fileRef = E548EBCF21015F0E00BE3C32 /* WKFormColorPicker.h */; };
> 		E548EBD221015F0E00BE3C32 /* WKFormColorPicker.mm in Sources */ = {isa = PBXBuildFile; fileRef = E548EBD021015F0E00BE3C32 /* WKFormColorPicker.mm */; };
> 		E54A14CF20FCFB7B007E13D8 /* WebDataListSuggestionsDropdown.cpp in Sources */ = {isa = PBXBuildFile; fileRef = E54A14CE20FCFB7B007E13D8 /* WebDataListSuggestionsDropdown.cpp */; };
>+		E548CC1120C7321B00F76119 /* WebDataListSuggestionsDropdownIOS.h in Headers */ = {isa = PBXBuildFile; fileRef = E548CC0F20C7321B00F76119 /* WebDataListSuggestionsDropdownIOS.h */; };
>+		E548CC1220C7321B00F76119 /* WebDataListSuggestionsDropdownIOS.mm in Sources */ = {isa = PBXBuildFile; fileRef = E548CC1020C7321B00F76119 /* WebDataListSuggestionsDropdownIOS.mm */; };
> 		E568B91F20A3AB2F00E3C856 /* WebDataListSuggestionsDropdown.h in Headers */ = {isa = PBXBuildFile; fileRef = E568B91E20A3AB2F00E3C856 /* WebDataListSuggestionsDropdown.h */; };
> 		E568B92220A3AC6A00E3C856 /* WebDataListSuggestionsDropdownMac.h in Headers */ = {isa = PBXBuildFile; fileRef = E568B92020A3AC6A00E3C856 /* WebDataListSuggestionsDropdownMac.h */; };
> 		E568B92320A3AC6A00E3C856 /* WebDataListSuggestionsDropdownMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = E568B92120A3AC6A00E3C856 /* WebDataListSuggestionsDropdownMac.mm */; };
>@@ -4975,6 +4977,8 @@
> 		E548EBCF21015F0E00BE3C32 /* WKFormColorPicker.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name = WKFormColorPicker.h; path = ios/forms/WKFormColorPicker.h; sourceTree = "<group>"; };
> 		E548EBD021015F0E00BE3C32 /* WKFormColorPicker.mm */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.objcpp; name = WKFormColorPicker.mm; path = ios/forms/WKFormColorPicker.mm; sourceTree = "<group>"; };
> 		E54A14CE20FCFB7B007E13D8 /* WebDataListSuggestionsDropdown.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = WebDataListSuggestionsDropdown.cpp; sourceTree = "<group>"; };
>+		E548CC0F20C7321B00F76119 /* WebDataListSuggestionsDropdownIOS.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = WebDataListSuggestionsDropdownIOS.h; sourceTree = "<group>"; };
>+		E548CC1020C7321B00F76119 /* WebDataListSuggestionsDropdownIOS.mm */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.objcpp; path = WebDataListSuggestionsDropdownIOS.mm; sourceTree = "<group>"; };
> 		E568B91E20A3AB2F00E3C856 /* WebDataListSuggestionsDropdown.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = WebDataListSuggestionsDropdown.h; sourceTree = "<group>"; };
> 		E568B92020A3AC6A00E3C856 /* WebDataListSuggestionsDropdownMac.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = WebDataListSuggestionsDropdownMac.h; sourceTree = "<group>"; };
> 		E568B92120A3AC6A00E3C856 /* WebDataListSuggestionsDropdownMac.mm */ = {isa = PBXFileReference; explicitFileType = sourcecode.cpp.objcpp; path = WebDataListSuggestionsDropdownMac.mm; sourceTree = "<group>"; };
>@@ -6257,6 +6261,8 @@
> 				2DAF06D518BD1A470081CEB1 /* SmartMagnificationController.mm */,
> 				2DA944A91884E9BA00ED86DB /* TextCheckerIOS.mm */,
> 				2DF9593418A42412009785A1 /* ViewGestureControllerIOS.mm */,
>+				E548CC0F20C7321B00F76119 /* WebDataListSuggestionsDropdownIOS.h */,
>+				E548CC1020C7321B00F76119 /* WebDataListSuggestionsDropdownIOS.mm */,
> 				2D3EF4411917646300034184 /* WebMemoryPressureHandlerIOS.h */,
> 				2D3EF4401917646300034184 /* WebMemoryPressureHandlerIOS.mm */,
> 				2DA944AB1884E9BA00ED86DB /* WebPageProxyIOS.mm */,
>@@ -9778,6 +9784,7 @@
> 				1AA83F6D1A5B63FF00026EC6 /* WebDatabaseProvider.h in Headers */,
> 				E52CF55220A35C3A00DADA27 /* WebDataListSuggestionPicker.h in Headers */,
> 				E568B91F20A3AB2F00E3C856 /* WebDataListSuggestionsDropdown.h in Headers */,
>+				E548CC1120C7321B00F76119 /* WebDataListSuggestionsDropdownIOS.h in Headers */,
> 				E568B92220A3AC6A00E3C856 /* WebDataListSuggestionsDropdownMac.h in Headers */,
> 				CD19A26E1A13E834008D650E /* WebDiagnosticLoggingClient.h in Headers */,
> 				1A5B1C5518987EDF004FCF9B /* WebDocumentLoader.h in Headers */,
>@@ -11705,6 +11712,7 @@
> 				1AA83F6C1A5B63FF00026EC6 /* WebDatabaseProvider.cpp in Sources */,
> 				E52CF55320A35C3A00DADA27 /* WebDataListSuggestionPicker.cpp in Sources */,
> 				E54A14CF20FCFB7B007E13D8 /* WebDataListSuggestionsDropdown.cpp in Sources */,
>+				E548CC1220C7321B00F76119 /* WebDataListSuggestionsDropdownIOS.mm in Sources */,
> 				E568B92320A3AC6A00E3C856 /* WebDataListSuggestionsDropdownMac.mm in Sources */,
> 				CD19A26D1A13E82A008D650E /* WebDiagnosticLoggingClient.cpp in Sources */,
> 				1A5B1C5418987EDF004FCF9B /* WebDocumentLoader.cpp in Sources */,
>diff --git a/Source/WebKit/WebProcess/WebPage/WebPage.cpp b/Source/WebKit/WebProcess/WebPage/WebPage.cpp
>index 82fff4948d28c6a6c8b25568bc589508c9603a37..af6b8c2885df6213ce214bd13beeb31116c074b6 100644
>--- a/Source/WebKit/WebProcess/WebPage/WebPage.cpp
>+++ b/Source/WebKit/WebProcess/WebPage/WebPage.cpp
>@@ -3599,7 +3599,8 @@ void WebPage::didSelectDataListOption(const String& selectedOption)
> 
> void WebPage::didCloseSuggestions()
> {
>-    m_activeDataListSuggestionPicker->didCloseSuggestions();
>+    if (m_activeDataListSuggestionPicker)
>+        m_activeDataListSuggestionPicker->didCloseSuggestions();
>     m_activeDataListSuggestionPicker = nullptr;
> }
> 
>diff --git a/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm b/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
>index 26186fb9870e17e45056bca0392baaf485bfff61..3189d98ea2e9388cddd8f95ce33f1506d8592209 100644
>--- a/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
>+++ b/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
>@@ -2192,6 +2192,18 @@ void WebPage::getPositionInformation(const InteractionInformationRequest& reques
>         }
>     }
> 
>+    // Prevent the callout bar from showing when tapping on the datalist button.
>+#if ENABLE(DATALIST_ELEMENT)
>+    if (is<HTMLInputElement>(*hitNode)) {
>+        const HTMLInputElement& input = downcast<HTMLInputElement>(*hitNode);
>+        if (input.list()) {
>+            HitTestResult result = m_page->mainFrame().eventHandler().hitTestResultAtPoint(request.point, HitTestRequest::ReadOnly | HitTestRequest::Active);
>+            if (result.innerNode() == input.dataListButtonElement())
>+                info.preventTextInteraction = true;
>+        }
>+    }
>+#endif
>+
> #if ENABLE(DATA_INTERACTION)
>     info.hasSelectionAtPosition = m_page->hasSelectionAtPosition(adjustedPoint);
> #endif
>@@ -2459,6 +2471,9 @@ void WebPage::getAssistedNodeInformation(AssistedNodeInformation& information)
>         }
> #endif
> 
>+#if ENABLE(DATALIST_ELEMENT)
>+        information.hasSuggestions = !!element.list();
>+#endif
>         information.isReadOnly = element.isReadOnly();
>         information.value = element.value();
>         information.valueAsNumber = element.valueAsNumber();

Actions: View | Formatted Diff | Diff

Attachments on bug 186714: 347585 | 347869 | 348054 | 348056 | 348221 | 348577