Attachment 347577 Details for Bug 188769 – proposed patch.

[patch] proposed patch.

bug-188769.patch (text/plain), 1.67 KB, created by Mark Lam on 2018-08-20 17:14:21 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Lam

Created: 2018-08-20 17:14:21 PDT

Size: 1.67 KB

patch

obsolete

>Index: Source/JavaScriptCore/ChangeLog
>===================================================================
>--- Source/JavaScriptCore/ChangeLog	(revision 235100)
>+++ Source/JavaScriptCore/ChangeLog	(working copy)
>@@ -1,3 +1,15 @@
>+2018-08-20  Mark Lam  <mark.lam@apple.com>
>+
>+        Fix the LLInt so that btjs shows vmEntryToJavaScript instead of llintPCRangeStart for the entry frame.
>+        https://bugs.webkit.org/show_bug.cgi?id=188769
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * llint/LowLevelInterpreter.asm:
>+        - Just put an unused instruction between llintPCRangeStart and vmEntryToJavaScript
>+          so that libunwind doesn't get confused by the 2 labels pointing to the same
>+          code address.
>+
> 2018-08-19  Carlos Garcia Campos  <cgarcia@igalia.com>
> 
>         [GLIB] Add API to throw exceptions using printf formatted strings
>Index: Source/JavaScriptCore/llint/LowLevelInterpreter.asm
>===================================================================
>--- Source/JavaScriptCore/llint/LowLevelInterpreter.asm	(revision 235085)
>+++ Source/JavaScriptCore/llint/LowLevelInterpreter.asm	(working copy)
>@@ -1148,6 +1148,13 @@ macro doReturn()
>     ret
> end
> 
>+# This break instruction is needed so that the synthesized llintPCRangeStart label
>+# doesn't point to the exact same location as vmEntryToJavaScript which comes after it.
>+# Otherwise, libunwind will report vmEntryToJavaScript as llintPCRangeStart in
>+# stack traces.
>+
>+    break
>+
> # stub to call into JavaScript or Native functions
> # EncodedJSValue vmEntryToJavaScript(void* code, VM* vm, ProtoCallFrame* protoFrame)
> # EncodedJSValue vmEntryToNativeFunction(void* code, VM* vm, ProtoCallFrame* protoFrame)

Actions: View | Formatted Diff | Diff

Attachments on bug 188769: 347577