Attachment 347559 Details for Bug 188607 – Patch

[patch] Patch

bug-188607-20180820161527.patch (text/plain), 3.91 KB, created by Ross Kirsling on 2018-08-20 16:15:27 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ross Kirsling

Created: 2018-08-20 16:15:27 PDT

Size: 3.91 KB

patch

obsolete

>Subversion Revision: 234944
>diff --git a/Websites/bugs.webkit.org/ChangeLog b/Websites/bugs.webkit.org/ChangeLog
>index 5aa77bc05c85121b9c5331147b9726edd5eb9dfb..4a402de75feb26de679412f7bb1c08999d17eccf 100644
>--- a/Websites/bugs.webkit.org/ChangeLog
>+++ b/Websites/bugs.webkit.org/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-08-20  Ross Kirsling  <ross.kirsling@sony.com>
>+
>+        EWS bubbles are being hidden due to lack of space.
>+        https://bugs.webkit.org/show_bug.cgi?id=188607
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * template/en/default/attachment/edit.html.tmpl:
>+        * template/en/default/attachment/list.html.tmpl:
>+        Set the iframe dimensions via postMessage, like on the Review Patch screen.
>+
> 2018-06-22  Daniel Bates  <dabates@apple.com>
> 
>         EWS for security bugs
>diff --git a/Websites/bugs.webkit.org/template/en/default/attachment/edit.html.tmpl b/Websites/bugs.webkit.org/template/en/default/attachment/edit.html.tmpl
>index 51533acfbf20ff2e6085918e5c88f65cd2f72fe8..5725a9c61a36b180cdb9918a478a6045d8bd2895 100644
>--- a/Websites/bugs.webkit.org/template/en/default/attachment/edit.html.tmpl
>+++ b/Websites/bugs.webkit.org/template/en/default/attachment/edit.html.tmpl
>@@ -34,6 +34,21 @@
> [% can_edit = attachment.validate_can_edit %]
> [% editable_or_hide = can_edit ? "" : " bz_hidden_option" %]
> 
>+<script>
>+window.addEventListener('message', function (e) {
>+    if (e.origin !== 'https://webkit-queues.webkit.org' || !e.data.height)
>+        return;
>+
>+    const iframe = document.querySelector('.statusBubble > iframe');
>+    iframe.style.height = e.data.height + 'px';
>+    iframe.style.width = e.data.width + 'px';
>+}, false);
>+
>+function handleStatusBubbleLoad(iframe) {
>+    iframe.contentWindow.postMessage('containerMetrics', 'https://webkit-queues.webkit.org');
>+}
>+</script>
>+
> <form method="post" action="attachment.cgi" onsubmit="normalizeComments();">
>   <input type="hidden" name="id" value="[% attachment.id %]">
>   <input type="hidden" name="action" value="update">
>@@ -260,7 +275,7 @@
> 
>         <div class="statusBubble">
>           <iframe src="https://webkit-queues.webkit.org/status-bubble/[% attachment.id %]"
>-                  style="width: 600px; height: 20px; border: none;" scrolling="no">
>+                  style="width: 600px; height: 20px; border: none;" scrolling="no" onload="handleStatusBubbleLoad(this);">
>           </iframe>
>         </div>
>         <br>
>diff --git a/Websites/bugs.webkit.org/template/en/default/attachment/list.html.tmpl b/Websites/bugs.webkit.org/template/en/default/attachment/list.html.tmpl
>index eadbd201e8d7570696fdc5646a0e64ea46b5061d..73cd06f6cbbeddf20e70d79e294826fc6e137b82 100644
>--- a/Websites/bugs.webkit.org/template/en/default/attachment/list.html.tmpl
>+++ b/Websites/bugs.webkit.org/template/en/default/attachment/list.html.tmpl
>@@ -38,6 +38,23 @@ function toggle_display(link) {
> 
>     return false;
> }
>+
>+window.addEventListener('message', function (e) {
>+    if (e.origin !== 'https://webkit-queues.webkit.org' || !e.data.height)
>+        return;
>+
>+    for (const iframe of document.querySelectorAll('.statusBubble > iframe')) {
>+        if (iframe.contentWindow !== e.source)
>+            continue;
>+
>+        iframe.style.height = e.data.height + 'px';
>+        iframe.style.width = e.data.width + 'px';
>+    }
>+}, false);
>+
>+function handleStatusBubbleLoad(iframe) {
>+    iframe.contentWindow.postMessage('containerMetrics', 'https://webkit-queues.webkit.org');
>+}
> //-->
> </script>
> 
>@@ -153,7 +170,7 @@ function toggle_display(link) {
>           [% IF attachment.ispatch %]
>           <div class="statusBubble">
>             <iframe src="https://webkit-queues.webkit.org/status-bubble/[% attachment.id %]"
>-                    style="width: 600px; height: 20px; border: none;" scrolling="no">
>+                    style="width: 600px; height: 20px; border: none;" scrolling="no" onload="handleStatusBubbleLoad(this);>
>             </iframe>
>           </div>
>           [% END %]

Actions: View | Formatted Diff | Diff

Attachments on bug 188607: 347175 | 347177 | 347195 | 347216 | 347325 | 347557 | 347559 | 347623 | 347964 | 347967 | 347969