Attachment 347547 Details for Bug 188758 – Patch

[patch] Patch

bug-188758-20180820144341.patch (text/plain), 4.36 KB, created by Jonathan Bedard on 2018-08-20 14:43:42 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Bedard

Created: 2018-08-20 14:43:42 PDT

Size: 4.36 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 235095)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,16 @@
>+2018-08-20  Jonathan Bedard  <jbedard@apple.com>
>+
>+        WebKitTestRunner: Add watchOS entitlements
>+        https://bugs.webkit.org/show_bug.cgi?id=188758
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        watchOS needs an additional entitlement to open up a socket for on-device testing.
>+
>+        * WebKitTestRunner/Configurations/WebKitTestRunnerApp-watchOS.entitlements: Added.
>+        * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
>+        * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
>+
> 2018-08-20  Thomas Denney  <tdenney@apple.com>
> 
>         Added Thomas Denney to contributors.json.
>Index: Tools/WebKitTestRunner/Configurations/WebKitTestRunnerApp-watchOS.entitlements
>===================================================================
>--- Tools/WebKitTestRunner/Configurations/WebKitTestRunnerApp-watchOS.entitlements	(nonexistent)
>+++ Tools/WebKitTestRunner/Configurations/WebKitTestRunnerApp-watchOS.entitlements	(working copy)
>@@ -0,0 +1,10 @@
>+<?xml version="1.0" encoding="UTF-8"?>
>+<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
>+<plist version="1.0">
>+<dict>
>+	<key>com.apple.security.network.client</key>
>+	<true/>
>+	<key>com.apple.developer.WebKit.ServiceWorkers</key>
>+	<true/>
>+</dict>
>+</plist>
>Index: Tools/WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig
>===================================================================
>--- Tools/WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig	(revision 235094)
>+++ Tools/WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig	(working copy)
>@@ -41,3 +41,4 @@ EXCLUDED_SOURCE_FILE_NAMES[sdk=watch*] =
> TARGETED_DEVICE_FAMILY = 1,2,4;
> 
> CODE_SIGN_ENTITLEMENTS[sdk=iphone*] = Configurations/WebKitTestRunnerApp-iOS.entitlements;
>+CODE_SIGN_ENTITLEMENTS[sdk=watch*] = Configurations/WebKitTestRunnerApp-watchOS.entitlements;
>Index: Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj
>===================================================================
>--- Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj	(revision 235094)
>+++ Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj	(working copy)
>@@ -275,6 +275,7 @@
> 		2EE52D141890A9FB0010ED21 /* TestControllerIOS.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = TestControllerIOS.mm; sourceTree = "<group>"; };
> 		2EE52D161890A9FB0010ED21 /* mainIOS.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; name = mainIOS.mm; path = ../ios/mainIOS.mm; sourceTree = "<group>"; };
> 		3110BE0F15BA011400D216AC /* WebNotificationProvider.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = WebNotificationProvider.h; sourceTree = "<group>"; };
>+		311183AA212B1AC70077BCE0 /* WebKitTestRunnerApp-watchOS.entitlements */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.plist.entitlements; path = "WebKitTestRunnerApp-watchOS.entitlements"; sourceTree = "<group>"; };
> 		31268EB91EF06A3B001963E2 /* UIKitTestSPI.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = UIKitTestSPI.h; path = ../TestRunnerShared/spi/UIKitTestSPI.h; sourceTree = "<group>"; };
> 		3148A0531E6F85B600D3B316 /* IOSLayoutTestCommunication.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = IOSLayoutTestCommunication.cpp; path = ../TestRunnerShared/IOSLayoutTestCommunication.cpp; sourceTree = "<group>"; };
> 		3148A0541E6F85B600D3B316 /* IOSLayoutTestCommunication.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = IOSLayoutTestCommunication.h; path = ../TestRunnerShared/IOSLayoutTestCommunication.h; sourceTree = "<group>"; };
>@@ -767,6 +768,7 @@
> 				BC25197111D15E61002EBC01 /* InjectedBundle.xcconfig */,
> 				A18510381B9ADF2200744AEB /* WebKitTestRunner.xcconfig */,
> 				9B0D132E2036D346008FC8FB /* WebKitTestRunnerApp-iOS.entitlements */,
>+				311183AA212B1AC70077BCE0 /* WebKitTestRunnerApp-watchOS.entitlements */,
> 				A18510391B9ADFF800744AEB /* WebKitTestRunnerApp.xcconfig */,
> 				BC251A1811D16795002EBC01 /* WebKitTestRunnerLibrary.xcconfig */,
> 			);

Actions: View | Formatted Diff | Diff

Attachments on bug 188758: 347547