Attachment 347513 Details for Bug 188351 – Patch for Landing

[patch] Patch for Landing

bug-188351-20180820111303.patch (text/plain), 1.71 KB, created by Jeremy Jones on 2018-08-20 11:13:03 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jeremy Jones

Created: 2018-08-20 11:13:03 PDT

Size: 1.71 KB

patch

obsolete

>Subversion Revision: 234613
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 2ba87c3e3401319a9ef2f86da9c9be584deccffc..c0b246b15dff45d5e471a46f0ffd748b83925116 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,18 @@
>+2018-08-06  Jeremy Jones  <jeremyj@apple.com>
>+
>+        UIWebView crashes while attempting to play youtube video on phone
>+        https://bugs.webkit.org/show_bug.cgi?id=188351
>+        rdar://problem/42489664
>+
>+        Reviewed by David Kilzer.
>+
>+        Test will be incorporated with fix for 188749, which will test both fixes.
>+
>+        VideoFullscreenControllerContext must remove unretained reference to it from m_playbackModel during cleanup.
>+
>+        * platform/ios/WebVideoFullscreenControllerAVKit.mm:
>+        (VideoFullscreenControllerContext::didCleanupFullscreen):
>+
> 2018-08-06  Ryan Haddad  <ryanhaddad@apple.com>
> 
>         Unreviewed, rolling out r234569.
>diff --git a/Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm b/Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm
>index 3efbb17cfa649d31c5088035e0adfe0425299588..7ff0cf574d6fd4bf57eb52cfc92c0f44e9c204c7 100644
>--- a/Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm
>+++ b/Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm
>@@ -328,6 +328,7 @@ void VideoFullscreenControllerContext::didCleanupFullscreen()
>         m_fullscreenModel->setVideoFullscreenLayer(nil);
>         m_fullscreenModel->setVideoElement(nullptr);
>         m_playbackModel->setMediaElement(nullptr);
>+        m_playbackModel->removeClient(*this);
>         m_fullscreenModel->removeClient(*this);
>         m_fullscreenModel = nullptr;
>         m_videoElement = nullptr;

Actions: View | Formatted Diff | Diff

Attachments on bug 188351: 346646 | 347513