Attachment 347492 Details for Bug 188704 – Patch

[patch] Patch

bug-188704-20180820093616.patch (text/plain), 1.80 KB, created by Thibault Saunier on 2018-08-20 05:36:17 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Thibault Saunier

Created: 2018-08-20 05:36:17 PDT

Size: 1.80 KB

patch

obsolete

>Subversion Revision: 234611
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 8f5dc496b38b09b8ec5d8d970dcb65780a50e20e..16bf103e21970c7d34572a1c73017ab814c49f2d 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-08-17  Thibault Saunier  <tsaunier@igalia.com>
>+
>+        [GTK][WPE] Make sure MediaDeviceEnabled and PeerConnectionEnabled are always synced with enable-media-stream
>+        https://bugs.webkit.org/show_bug.cgi?id=188704
>+
>+        By default m_isMediaDevicesEnabled and m_isScreenCaptureEnabled are false but
>+        m_isMediaStreamEnabled is true meaning that in the WPE minibrowser getUserMedia
>+        was disabled even if we explicitly set `"enable-media-stream", TRUE`.
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UIProcess/API/glib/WebKitSettings.cpp:
>+        (webKitSettingsConstructed):
>+
> 2018-08-06  Chris Dumez  <cdumez@apple.com>
> 
>         Fix IPC::Connection leak in StorageManager
>diff --git a/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp b/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp
>index 4c960904982ea2aaf0dadc0872f34db7badcb3a0..835b384274ee8dcd93d7dc39c872c48b06310266 100644
>--- a/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp
>+++ b/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp
>@@ -177,6 +177,10 @@ static void webKitSettingsConstructed(GObject* object)
>     WebPreferences* prefs = settings->priv->preferences.get();
>     prefs->setShouldRespectImageOrientation(true);
> 
>+    bool mediaStreamEnabled = prefs->mediaStreamEnabled();
>+    prefs->setMediaStreamEnabled(mediaStreamEnabled);
>+    prefs->setPeerConnectionEnabled(mediaStreamEnabled);
>+
>     settings->priv->screenDpi = WebCore::screenDPI();
>     WebCore::setScreenDPIObserverHandler([settings]() {
>         auto newScreenDpi = WebCore::screenDPI();

Actions: View | Formatted Diff | Diff

Attachments on bug 188704: 347376 | 347492 | 347493 | 350252