Attachment 347453 Details for Bug 188725 – Patch v1

[patch] Patch v1

bug-188725-20180818165036.patch (text/plain), 2.00 KB, created by David Kilzer (:ddkilzer) on 2018-08-18 16:50:46 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: David Kilzer (:ddkilzer)

Created: 2018-08-18 16:50:46 PDT

Size: 2.00 KB

patch

obsolete

>Subversion Revision: 234997
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index ac352a45bb061fd7e09f9196290afaaf9c4d1af2..9ef6c4f1a126966f4341d91c16f2cf52e936a0f5 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-08-18  David Kilzer  <ddkilzer@apple.com>
>+
>+        REGRESSION (r234396): Leak of CFURLRef in WebKit::NetworkProcess::deleteHSTSCacheForHostNames()
>+        <https://webkit.org/b/188725>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * NetworkProcess/cocoa/NetworkProcessCocoa.mm:
>+        (WebKit::NetworkProcess::deleteHSTSCacheForHostNames): Use
>+        adoptCF() to prevent a leak.
>+
> 2018-08-16  Ryosuke Niwa  <rniwa@webkit.org>
> 
>         Replace canBubble and cancelable booleans in Event by enum classes
>diff --git a/Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm b/Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm
>index c9348e7418b779d74ab7ec875dd8b14a79483cfe..0023fe161b53ef5bc3a534439b662e58cda0e65c 100644
>--- a/Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm
>+++ b/Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm
>@@ -45,6 +45,7 @@
> #import <wtf/BlockPtr.h>
> #import <wtf/CallbackAggregator.h>
> #import <wtf/ProcessPrivilege.h>
>+#import <wtf/RetainPtr.h>
> 
> namespace WebKit {
> 
>@@ -159,8 +160,10 @@ void NetworkProcess::getHostNamesWithHSTSCache(WebCore::NetworkStorageSession& s
> 
> void NetworkProcess::deleteHSTSCacheForHostNames(WebCore::NetworkStorageSession& session, const Vector<String>& hostNames)
> {
>-    for (auto& hostName : hostNames)
>-        _CFNetworkResetHSTS(CFURLCreateWithString(kCFAllocatorDefault, hostName.createCFString().get(), NULL), session.platformSession());
>+    for (auto& hostName : hostNames) {
>+        auto url = adoptCF(CFURLCreateWithString(kCFAllocatorDefault, hostName.createCFString().get(), NULL));
>+        _CFNetworkResetHSTS(url.get(), session.platformSession());
>+    }
> }
> 
> void NetworkProcess::clearHSTSCache(WebCore::NetworkStorageSession& session, WallTime modifiedSince)

Actions: View | Formatted Diff | Diff

Attachments on bug 188725: 347453