Attachment 347402 Details for Bug 188710 – Patch

[patch] Patch

bug-188710-20180817155825.patch (text/plain), 2.40 KB, created by Brent Fulgham on 2018-08-17 15:58:26 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Brent Fulgham

Created: 2018-08-17 15:58:26 PDT

Size: 2.40 KB

patch

obsolete

>Subversion Revision: 234714
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 1a7de65ef11598dd4becab5c46542292ae1bd4f1..26804d4cd0bc480fa0e2285f7a9abdba109c5a50 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-08-17  Brent Fulgham  <bfulgham@apple.com>
>+
>+        Remove Adobe SSO exception now that StorageAccess API is available
>+        https://bugs.webkit.org/show_bug.cgi?id=188710
>+        <rdar://problem/35056707>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Remove custom quirk now that proper API exists to allow the same functions.
>+
>+        * loader/ResourceLoadObserver.cpp:
>+        (WebCore::ResourceLoadObserver::logSubresourceLoading): Remove unneeded quirk.
>+        (WebCore::resourceNeedsSSOQuirk): Deleted.
>+
> 2018-08-08  Don Olmstead  <don.olmstead@sony.com>
> 
>         [Nicosia] Add the Nicosia-specific PlatformLayer type alias
>diff --git a/Source/WebCore/loader/ResourceLoadObserver.cpp b/Source/WebCore/loader/ResourceLoadObserver.cpp
>index 8b9836e1ce12714bed2b6c2cae26f1fa78c9a856..511b912a2540c3926304abedcb8ec04540217092 100644
>--- a/Source/WebCore/loader/ResourceLoadObserver.cpp
>+++ b/Source/WebCore/loader/ResourceLoadObserver.cpp
>@@ -104,15 +104,6 @@ bool ResourceLoadObserver::shouldLog(Page* page) const
>     return DeprecatedGlobalSettings::resourceLoadStatisticsEnabled() && !page->usesEphemeralSession() && m_notificationCallback;
> }
> 
>-// FIXME: This quirk was added to address <rdar://problem/33325881> and should be removed once content is fixed.
>-static bool resourceNeedsSSOQuirk(Page* page, const URL& url)
>-{
>-    if (!shouldEnableSiteSpecificQuirks(page))
>-        return false;
>-
>-    return equalIgnoringASCIICase(url.host(), "sp.auth.adobe.com");
>-}
>-
> void ResourceLoadObserver::logSubresourceLoading(const Frame* frame, const ResourceRequest& newRequest, const ResourceResponse& redirectResponse)
> {
>     ASSERT(frame->page());
>@@ -139,9 +130,6 @@ void ResourceLoadObserver::logSubresourceLoading(const Frame* frame, const Resou
>     if (areDomainsAssociated(page, targetPrimaryDomain, mainFramePrimaryDomain) || (isRedirect && areDomainsAssociated(page, targetPrimaryDomain, sourcePrimaryDomain)))
>         return;
> 
>-    if (resourceNeedsSSOQuirk(page, targetURL))
>-        return;
>-
>     bool shouldCallNotificationCallback = false;
>     {
>         auto& targetStatistics = ensureResourceStatisticsForPrimaryDomain(targetPrimaryDomain);

Actions: View | Formatted Diff | Diff

Attachments on bug 188710: 347402