Attachment 347390 Details for Bug 188696 – Patch

[patch] Patch

bug-188696-20180817212758.patch (text/plain), 1.38 KB, created by PhistucK on 2018-08-17 14:27:59 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: PhistucK

Created: 2018-08-17 14:27:59 PDT

Size: 1.38 KB

patch

obsolete

>Subversion Revision: 234984
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 0cb77c8f315ca022df72249d51784df7cb7ffe66..00d4bf3c7987836c39804a6588f7f629e904d8c0 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-08-17  PhistucK  <phistuck@gmail.com>
>+
>+        beforeunload interoperability issues with a throwing return
>+        https://bugs.webkit.org/show_bug.cgi?id=188696
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        No new tests .
>+
>+        * bindings/js/JSEventListener.cpp:
>+        (WebCore::handleBeforeUnloadEventReturnValue):
>+
> 2018-08-17  Yusuke Suzuki  <yusukesuzuki@slowstart.org> and Fujii Hironori  <Hironori.Fujii@sony.com>
> 
>         [JSC] Add GPRReg::InvalidGPRReg and FPRReg::InvalidFPRReg
>diff --git a/Source/WebCore/bindings/js/JSEventListener.cpp b/Source/WebCore/bindings/js/JSEventListener.cpp
>index 9931fe8b1abcb640a85970b4bb9ea3ad186e803b..101929edd0ccf753da4fb4ea3c72e072081b07f1 100644
>--- a/Source/WebCore/bindings/js/JSEventListener.cpp
>+++ b/Source/WebCore/bindings/js/JSEventListener.cpp
>@@ -88,7 +88,7 @@ void JSEventListener::visitJSFunction(SlotVisitor& visitor)
> 
> static void handleBeforeUnloadEventReturnValue(BeforeUnloadEvent& event, const String& returnValue)
> {
>-    if (returnValue.isNull())
>+    if (returnValue.isNull() || returnValue.isEmpty())
>         return;
> 
>     event.preventDefault();

Actions: View | Formatted Diff | Diff

Attachments on bug 188696: 347390 | 347395 | 347397 | 347403 | 347410 | 347442 | 350504 | 350510 | 350511 | 350513 | 350514 | 350519 | 350520 | 350521 | 350522 | 350523 | 350524 | 350528