Attachment 347376 Details for Bug 188704 – Patch

[patch] Patch

bug-188704-20180817160600.patch (text/plain), 1.91 KB, created by Thibault Saunier on 2018-08-17 12:06:01 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Thibault Saunier

Created: 2018-08-17 12:06:01 PDT

Size: 1.91 KB

patch

obsolete

>Subversion Revision: 234611
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 8f5dc496b38b09b8ec5d8d970dcb65780a50e20e..47bedb7a9e1713d4d445bab71c0acf0920bcbf60 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-08-17  Thibault Saunier  <tsaunier@igalia.com>
>+
>+        [GTK][WPE] Make sure MediaDeviceEnabled and PeerConnectionEnabled are always synced with enable-media-stream
>+        https://bugs.webkit.org/show_bug.cgi?id=188704
>+
>+        By default m_isMediaDevicesEnabled and m_isScreenCaptureEnabled are false but
>+        m_isMediaStreamEnabled is true meaning that in the WPE minibrowser getUserMedia
>+        was disabled even if we explicitly set `"enable-media-stream", TRUE`.
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UIProcess/API/glib/WebKitSettings.cpp:
>+        (webkit_settings_set_enable_media_stream):
>+
> 2018-08-06  Chris Dumez  <cdumez@apple.com>
> 
>         Fix IPC::Connection leak in StorageManager
>diff --git a/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp b/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp
>index 4c960904982ea2aaf0dadc0872f34db7badcb3a0..33bf257b75d5cd4fdb92c031dfb52db4f7b455f7 100644
>--- a/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp
>+++ b/Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp
>@@ -3118,13 +3118,13 @@ void webkit_settings_set_enable_media_stream(WebKitSettings* settings, gboolean
> 
>     WebKitSettingsPrivate* priv = settings->priv;
>     bool currentValue = priv->preferences->mediaStreamEnabled();
>-    if (currentValue == enabled)
>-        return;
> 
>     priv->preferences->setMediaDevicesEnabled(enabled);
>     priv->preferences->setMediaStreamEnabled(enabled);
>     priv->preferences->setPeerConnectionEnabled(enabled);
>-    g_object_notify(G_OBJECT(settings), "enable-media-stream");
>+
>+    if (currentValue != enabled)
>+        g_object_notify(G_OBJECT(settings), "enable-media-stream");
> }
> 
> /**

Actions: View | Formatted Diff | Diff

Attachments on bug 188704: 347376 | 347492 | 347493 | 350252