Attachment 347317 Details for Bug 188681 – Patch

[patch] Patch

bug-188681-20180816154240.patch (text/plain), 2.64 KB, created by Alex Christensen on 2018-08-16 15:42:41 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Christensen

Created: 2018-08-16 15:42:41 PDT

Size: 2.64 KB

patch

obsolete

>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 234962)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,15 @@
>+2018-08-16  Alex Christensen  <achristensen@webkit.org>
>+
>+        Remove unused and deprecated _WKProcessPoolConfiguration.allowsCellularAccess
>+        https://bugs.webkit.org/show_bug.cgi?id=188681
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h:
>+        * UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm:
>+        (-[_WKProcessPoolConfiguration allowsCellularAccess]): Deleted.
>+        (-[_WKProcessPoolConfiguration setAllowsCellularAccess:]): Deleted.
>+
> 2018-08-16  Alex Christensen  <achristensen@webkit.org>
> 
>         Add temporary SPI WKContextHandlesSafeBrowsing
>Index: Source/WebKit/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h
>===================================================================
>--- Source/WebKit/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h	(revision 234932)
>+++ Source/WebKit/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h	(working copy)
>@@ -56,7 +56,6 @@ WK_CLASS_AVAILABLE(macosx(10.10), ios(8.
> @property (nonatomic) BOOL diskCacheSpeculativeValidationEnabled WK_API_AVAILABLE(macosx(10.12), ios(10.0));
> @property (nonatomic, nullable, copy) NSString *sourceApplicationBundleIdentifier WK_API_AVAILABLE(macosx(10.12.3), ios(10.3));
> @property (nonatomic, nullable, copy) NSString *sourceApplicationSecondaryIdentifier WK_API_AVAILABLE(macosx(10.12.3), ios(10.3));
>-@property (nonatomic) BOOL allowsCellularAccess WK_API_DEPRECATED_WITH_REPLACEMENT("WKWebsiteDataStore._allowsCellularAccess", macosx(10.13, 10.13.4), ios(11.0, 11.3));
> @property (nonatomic) BOOL shouldCaptureAudioInUIProcess WK_API_AVAILABLE(macosx(10.13), ios(11.0));
> #if TARGET_OS_IPHONE
> @property (nonatomic, nullable, copy) NSString *CTDataConnectionServiceType WK_API_AVAILABLE(ios(10.3));
>Index: Source/WebKit/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm
>===================================================================
>--- Source/WebKit/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm	(revision 234932)
>+++ Source/WebKit/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm	(working copy)
>@@ -220,15 +220,6 @@ - (void)setSourceApplicationSecondaryIde
>     _processPoolConfiguration->setSourceApplicationSecondaryIdentifier(sourceApplicationSecondaryIdentifier);
> }
> 
>-- (BOOL)allowsCellularAccess
>-{
>-    return YES;
>-}
>-
>-- (void)setAllowsCellularAccess:(BOOL)allowsCellularAccess
>-{
>-}
>-
> - (BOOL)shouldCaptureAudioInUIProcess
> {
>     return _processPoolConfiguration->shouldCaptureAudioInUIProcess();

Flags:

thorton: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 188681: 347317