Attachment 347299 Details for Bug 188676 – Patch

[patch] Patch

bug-188676-20180816134501.patch (text/plain), 1.99 KB, created by Alex Christensen on 2018-08-16 13:45:01 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Christensen

Created: 2018-08-16 13:45:01 PDT

Size: 1.99 KB

patch

obsolete

>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 234950)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,19 @@
>+2018-08-16  Alex Christensen  <achristensen@webkit.org>
>+
>+        Add temporary SPI WKContextHandlesSafeBrowsing
>+        https://bugs.webkit.org/show_bug.cgi?id=188676
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        WebKit showing the safe browsing warning doesn't play well with Safari showing the safe browsing warning.
>+        I plan to adopt this SPI in Safari to disable Safari's safe browsing check if it's true.
>+        Then when I implement safe browsing in WebKit, I can switch this value to true in the same change and
>+        not have a broken Safari.
>+
>+        * UIProcess/API/C/mac/WKContextPrivateMac.h:
>+        * UIProcess/API/C/mac/WKContextPrivateMac.mm:
>+        (WKContextHandlesSafeBrowsing):
>+
> 2018-08-16  Alex Christensen  <achristensen@webkit.org>
> 
>         Transition more WKWebViewConfiguration ivars to API::PageConfiguration values
>Index: Source/WebKit/UIProcess/API/C/mac/WKContextPrivateMac.h
>===================================================================
>--- Source/WebKit/UIProcess/API/C/mac/WKContextPrivateMac.h	(revision 234932)
>+++ Source/WebKit/UIProcess/API/C/mac/WKContextPrivateMac.h	(working copy)
>@@ -74,6 +74,8 @@ WK_EXPORT WKStringRef WKPlugInInfoIsSand
> WK_EXPORT bool WKContextShouldBlockWebGL();
> WK_EXPORT bool WKContextShouldSuggestBlockWebGL();
> 
>+WK_EXPORT bool WKContextHandlesSafeBrowsing();
>+
> #ifdef __cplusplus
> }
> #endif
>Index: Source/WebKit/UIProcess/API/C/mac/WKContextPrivateMac.mm
>===================================================================
>--- Source/WebKit/UIProcess/API/C/mac/WKContextPrivateMac.mm	(revision 234932)
>+++ Source/WebKit/UIProcess/API/C/mac/WKContextPrivateMac.mm	(working copy)
>@@ -172,3 +172,8 @@ bool WKContextShouldSuggestBlockWebGL()
>     return false;
> #endif
> }
>+
>+bool WKContextHandlesSafeBrowsing()
>+{
>+    return false;
>+}

Flags:

joepeck: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 188676: 347299