Attachment 347293 Details for Bug 188674 – Patch

[patch] Patch

bug-188674-20180816131637.patch (text/plain), 2.75 KB, created by Jer Noble on 2018-08-16 13:16:38 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jer Noble

Created: 2018-08-16 13:16:38 PDT

Size: 2.75 KB

patch

obsolete

>Subversion Revision: 234941
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index f5e45bca2d1689993ecaa6133fba05e88a6b52a8..820bb1937f6a36474f4acde4c8bedf87e029e6f2 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-08-16  Jer Noble  <jer.noble@apple.com>
>+
>+        Add option to run-api-tests to force running of DISABLED tests.
>+        https://bugs.webkit.org/show_bug.cgi?id=188674
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Scripts/webkitpy/api_tests/run_api_tests.py:
>+        (parse_args):
>+        * Scripts/webkitpy/api_tests/runner.py:
>+        (Runner.command_for_port):
>+        (_Worker._run_single_test):
>+
> 2018-08-16  Jer Noble  <jer.noble@apple.com>
> 
>         Add Experimental Feature support for SourceBuffer.changeType()
>diff --git a/Tools/Scripts/webkitpy/api_tests/run_api_tests.py b/Tools/Scripts/webkitpy/api_tests/run_api_tests.py
>index a68bc3b9c25a8c5b3a4f750557ec6bb1b35a916d..903b9c4a3e8337812e17000b93be4f932bcc4657 100644
>--- a/Tools/Scripts/webkitpy/api_tests/run_api_tests.py
>+++ b/Tools/Scripts/webkitpy/api_tests/run_api_tests.py
>@@ -120,6 +120,9 @@ def parse_args(args):
>         # FIXME: Default should be false, API tests should not be forced to run singly
>         optparse.make_option('--run-singly', action='store_true', default=True,
>                              help='Run a separate process for each test'),
>+
>+        optparse.make_option('--force', action='store_true', default=False,
>+                             help='Run all tests, even DISABLED tests'),
>     ]))
> 
>     option_parser = optparse.OptionParser(usage='%prog [options] [<path>...]')
>diff --git a/Tools/Scripts/webkitpy/api_tests/runner.py b/Tools/Scripts/webkitpy/api_tests/runner.py
>index d6b1139639b11c2cda815f36a79f80823768fad3..fe48b4b0c8cf83a08e52cf5fc763b24f758ddd23 100644
>--- a/Tools/Scripts/webkitpy/api_tests/runner.py
>+++ b/Tools/Scripts/webkitpy/api_tests/runner.py
>@@ -66,6 +66,8 @@ class Runner(object):
>     # FIXME API tests should run as an app, we won't need this function <https://bugs.webkit.org/show_bug.cgi?id=175204>
>     @staticmethod
>     def command_for_port(port, args):
>+        if (port.get_option('force')):
>+            args.append('--gtest_also_run_disabled_tests=1')
>         if 'simulator' in port.port_name:
>             assert SimulatedDeviceManager.INITIALIZED_DEVICES
>             return ['/usr/bin/xcrun', 'simctl', 'spawn', SimulatedDeviceManager.INITIALIZED_DEVICES[0].udid] + args
>@@ -159,7 +161,7 @@ class _Worker(object):
>             env=self._port.environment_for_api_tests())
> 
>         status = Runner.STATUS_RUNNING
>-        if test.split('.')[1].startswith('DISABLED_'):
>+        if test.split('.')[1].startswith('DISABLED_') and not self._port.get_option('force'):
>             status = Runner.STATUS_DISABLED
> 
>         try:

Actions: View | Formatted Diff | Diff

Attachments on bug 188674: 347293