Attachment 347276 Details for Bug 188662 – PATCH

[patch] PATCH

188662.diff (text/plain), 1.65 KB, created by Basuke Suzuki on 2018-08-16 11:16:20 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Basuke Suzuki

Created: 2018-08-16 11:16:20 PDT

Size: 1.65 KB

patch

obsolete

>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 3e7cc4ec2d3..b96e996585c 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-08-16  Basuke Suzuki  <Basuke.Suzuki@sony.com>
>+
>+        [Win][DumpRenderTree] Remove error message for duplicated tests.
>+        https://bugs.webkit.org/show_bug.cgi?id=188662
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This was added to track down an issue where the same tests appeared
>+        to be run multiple times. This turned out to not be the case.
>+        See https://bugs.webkit.org/show_bug.cgi?id=166760 .
>+
>+        * DumpRenderTree/win/DumpRenderTree.cpp:
>+        (runTest):
>+
> 2018-08-15  Ryan Haddad  <ryanhaddad@apple.com>
> 
>         Unreviewed, rolling out r234870.
>diff --git a/Tools/DumpRenderTree/win/DumpRenderTree.cpp b/Tools/DumpRenderTree/win/DumpRenderTree.cpp
>index a7067528013..54d06ea8322 100644
>--- a/Tools/DumpRenderTree/win/DumpRenderTree.cpp
>+++ b/Tools/DumpRenderTree/win/DumpRenderTree.cpp
>@@ -1155,12 +1155,6 @@ static void runTest(const string& inputLine)
>     _bstr_t urlBStr(reinterpret_cast<wchar_t*>(buffer.data()));
>     ASSERT(urlBStr.length() == length);
> 
>-    // Check that test has not already run
>-    static HashSet<String> testUrls;
>-    if (testUrls.contains(String(inputLine.c_str())))
>-        fprintf(stderr, "Test has already run \"%s\"\n", inputLine.c_str());
>-    testUrls.add(String(inputLine.c_str()));
>-
>     CFIndex maximumURLLengthAsUTF8 = CFStringGetMaximumSizeForEncoding(length, kCFStringEncodingUTF8) + 1;
>     Vector<char> testURL(maximumURLLengthAsUTF8 + 1, 0);
>     CFStringGetCString(str, testURL.data(), maximumURLLengthAsUTF8, kCFStringEncodingUTF8);

Actions: View | Formatted Diff | Diff

Attachments on bug 188662: 347276