Attachment 347262 Details for Bug 188651 – Patch

[patch] Patch

bug-188651-20180816094645.patch (text/plain), 1.74 KB, created by Michael Catanzaro on 2018-08-16 07:46:45 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Michael Catanzaro

Created: 2018-08-16 07:46:45 PDT

Size: 1.74 KB

patch

obsolete

>Subversion Revision: 234887
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index c052c632521fffed7f6a1b9181d118bdd56bcd27..da7d19deb6fb0d0444c78a1b6a01055023b90793 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-08-16  Michael Catanzaro  <mcatanzaro@igalia.com>
>+
>+        [SOUP] Handle OAuth authentication after r234912
>+        https://bugs.webkit.org/show_bug.cgi?id=188651
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Update this switch to consider the new OAuth enum value added in r234912. I suppose OAuth is
>+        used for HTTP Auth now. It will be a one-time compatibility break as passwords previously
>+        stored with type "Unknown" will no longer be accessible.
>+
>+        * platform/network/soup/NetworkStorageSessionSoup.cpp:
>+        (WebCore::authTypeFromProtectionSpaceAuthenticationScheme):
>+
> 2018-08-15  Wenson Hsieh  <wenson_hsieh@apple.com>
> 
>         [Attachment SPI] Remove attachment display mode options
>diff --git a/Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp b/Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp
>index b3d71a4b40e5ded09b6832008bef0061d1fed15f..e483aa6316ce6c5d6c8f3e655d55dd1eeb0463cf 100644
>--- a/Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp
>+++ b/Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp
>@@ -177,6 +177,8 @@ static const char* authTypeFromProtectionSpaceAuthenticationScheme(ProtectionSpa
>     case ProtectionSpaceAuthenticationSchemeServerTrustEvaluationRequested:
>         ASSERT_NOT_REACHED();
>         break;
>+    case ProtectionSpaceAuthenticationSchemeOAuth:
>+        return "OAuth";
>     case ProtectionSpaceAuthenticationSchemeUnknown:
>         return "unknown";
>     }

Actions: View | Formatted Diff | Diff

Attachments on bug 188651: 347262