Attachment 347260 Details for Bug 188649 – Patch

[patch] Patch

bug-188649-20180816153607.patch (text/plain), 1.70 KB, created by Philippe Normand on 2018-08-16 06:36:08 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Philippe Normand

Created: 2018-08-16 06:36:08 PDT

Size: 1.70 KB

patch

obsolete

>Subversion Revision: 234920
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index bed7d527e4e8841320390c0691d6a0422030411f..040d5ec6fec1236431567501b4180239cbd8eeee 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-08-16  Philippe Normand  <philn@igalia.com>
>+
>+        [GStreamer][MSE] Disable last-sample support in AppendPipeline
>+        https://bugs.webkit.org/show_bug.cgi?id=188649
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * platform/graphics/gstreamer/mse/AppendPipeline.cpp:
>+        (WebCore::AppendPipeline::AppendPipeline): This property isn't
>+        used by the append pipeline. So as a micro-optimization, it is now
>+        disabled.
>+
> 2018-08-16  Antti Koivisto  <antti@apple.com>
> 
>         Use OptionSet for ActivityState::Flags
>diff --git a/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp b/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp
>index fd186af9909ba0ecbab12d2f8e44c9bda727c0d2..a8a4aae90dab3c221a48637dd3d2de844c098ef1 100644
>--- a/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp
>+++ b/Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp
>@@ -147,6 +147,7 @@ AppendPipeline::AppendPipeline(Ref<MediaSourceClientGStreamerMSE> mediaSourceCli
> 
>     gst_app_sink_set_emit_signals(GST_APP_SINK(m_appsink.get()), TRUE);
>     gst_base_sink_set_sync(GST_BASE_SINK(m_appsink.get()), FALSE);
>+    gst_base_sink_set_last_sample_enabled(GST_BASE_SINK(m_appsink.get()), FALSE);
> 
>     GRefPtr<GstPad> appsinkPad = adoptGRef(gst_element_get_static_pad(m_appsink.get(), "sink"));
>     g_signal_connect(appsinkPad.get(), "notify::caps", G_CALLBACK(appendPipelineAppsinkCapsChanged), this);

Flags:

calvaris: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 188649: 347260