Attachment 347246 Details for Bug 188636 – Patch

[patch] Patch

bug-188636-20180815222455.patch (text/plain), 7.51 KB, created by Simon Fraser (smfr) on 2018-08-15 22:24:56 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Simon Fraser (smfr)

Created: 2018-08-15 22:24:56 PDT

Size: 7.51 KB

patch

obsolete

>Subversion Revision: 234781
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index d4e6fed9d05b1dc08d9f88b9ca8467ee2aada5fd..caff52f22b2631352dcdce2508ce6e9867cf0e75 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,18 @@
>+2018-08-15  Simon Fraser  <simon.fraser@apple.com>
>+
>+        Add fake layout test results JSON to exercise the functionality in results.html
>+        https://bugs.webkit.org/show_bug.cgi?id=188636
>+
>+        Reviewed by NOBODY (OOPS!).
>+        
>+        The results for results.html are mostly blank because the page runs without any JSON
>+        data, so there's no testing of the functionality of the page. Add some fake JSON
>+        data which supplies most of the different types of test result, so we're testing
>+        at least some of the results.html script.
>+
>+        * fast/harness/full_results.json: Added.
>+        * fast/harness/results-expected.txt:
>+
> 2018-08-10  Joseph Pecoraro  <pecoraro@apple.com>
> 
>         Web Inspector: console.log fires getters for deep properties
>diff --git a/LayoutTests/fast/harness/full_results.json b/LayoutTests/fast/harness/full_results.json
>new file mode 100644
>index 0000000000000000000000000000000000000000..ed235cec2bbdc9224dd924220133a9e6c9aee828
>--- /dev/null
>+++ b/LayoutTests/fast/harness/full_results.json
>@@ -0,0 +1,127 @@
>+ADD_RESULTS({
>+    "tests": {
>+        "http": {
>+            "wpt": {
>+                "cache-storage": {
>+                    "cache-put-stream.https.any.html": {
>+                        "expected": "PASS FAIL",
>+                        "actual": "PASS"
>+                    },
>+                    "cache-put-keys.https.any.worker.html": {
>+                        "report": "REGRESSION",
>+                        "expected": "PASS",
>+                        "actual": "TEXT"
>+                    }
>+                }
>+            },
>+            "tests": {
>+                "contentextensions": {
>+                    "async-xhr-onerror.html": {
>+                        "expected": "PASS TIMEOUT",
>+                        "actual": "PASS"
>+                    },
>+                    "top-url.html": {
>+                        "report": "REGRESSION",
>+                        "expected": "PASS",
>+                        "actual": "CRASH",
>+                        "has_stderr": true
>+                    }
>+                },
>+                "storageAccess": {
>+                    "request-storage-access-top-frame.html": {
>+                        "report": "REGRESSION",
>+                        "expected": "PASS TIMEOUT",
>+                        "actual": "TEXT"
>+                    }
>+                }
>+            }
>+        },
>+        "media": {
>+            "video-loop.html": {
>+                "report": "FLAKY",
>+                "expected": "PASS TIMEOUT",
>+                "actual": "TEXT PASS TIMEOUT"
>+            },
>+        },
>+        "canvas": {
>+            "philip": {
>+                "tests": {
>+                    "2d.gradient.interpolate.solid.html": {
>+                        "expected": "FAIL",
>+                        "actual": "PASS"
>+                    }
>+                }
>+            }
>+        },
>+        "editing": {
>+            "spelling": {
>+                "spelling-marker-includes-hyphen.html": {
>+                    "expected": "IMAGE",
>+                    "actual": "PASS",
>+                    "reftest_type": ["=="]
>+                },
>+                "spelling-markers-in-overlapping-lines.html": {
>+                    "expected": "IMAGE",
>+                    "actual": "PASS",
>+                    "reftest_type": ["!="]
>+                }
>+            }
>+        },
>+        "webarchive": {
>+            "test-css-url-resources-in-stylesheets.html": {
>+                "expected": "FAIL",
>+                "actual": "TEXT"
>+            },
>+            "loading": {
>+                "object.html": {
>+                    "expected": "PASS CRASH",
>+                    "actual": "PASS"
>+                },
>+                "test-loading-archive-subresource-null-mimetype.html": {
>+                    "expected": "CRASH",
>+                    "actual": "PASS"
>+                }
>+            }
>+        },
>+        "svg": {
>+            "batik": {
>+                "smallFonts.svg": {
>+                    "report": "MISSING",
>+                    "expected": "PASS",
>+                    "actual": "MISSING"
>+                }
>+            }
>+        },
>+        "platform": {
>+            "mac": {
>+                "media": {
>+                    "audio-session-category-video-paused.html": {
>+                        "report": "REGRESSION",
>+                        "expected": "PASS",
>+                        "actual": "TIMEOUT",
>+                        "has_stderr": true
>+                    }
>+                }
>+            }
>+        }
>+    },
>+    "skipped": 5367,
>+    "num_regressions": 2,
>+    "other_crashes": {
>+        "DumpRenderTree-54888": {},
>+        "DumpRenderTree-56804": {},
>+    },
>+    "interrupted": false,
>+    "num_missing": 0,
>+    "layout_tests_dir": "/Volumes/Data/slave/highsierra-release-tests-wk2/build/LayoutTests",
>+    "version": 4,
>+    "num_passes": 49387,
>+    "pixel_tests_enabled": false,
>+    "date": "05:38PM on August 15, 2018",
>+    "has_pretty_patch": true,
>+    "fixable": 6360,
>+    "num_flaky": 0,
>+    "uses_expectations_file": true,
>+    "revision": "234905"
>+});
>+
>diff --git a/LayoutTests/fast/harness/results-expected.txt b/LayoutTests/fast/harness/results-expected.txt
>index 3ab410aef285839da956bdce90751f7eec685302..6af71da6f0ced94fee8f2986774e9d92fadf33cd 100644
>--- a/LayoutTests/fast/harness/results-expected.txt
>+++ b/LayoutTests/fast/harness/results-expected.txt
>@@ -1,6 +1,40 @@
> Use the i, j, k and l keys to navigate, e, c to expand and collapse, and f to flag
> expand all collapse all options
> Only unexpected results
>-Toggle images
> Use newlines in flagged list
>+Tests that crashed (1): flag all
> 
>++http/tests/contentextensions/top-url.html	crash log sample	history
>+Other Crashes (2): flag all
>+
>++DumpRenderTree-54888	crash log
>++DumpRenderTree-56804	crash log
>+Tests that failed text/pixel/audio diff (2): flag all
>+
>+ test 	results		actual failure	expected failure	history
>++http/tests/storageAccess/request-storage-access-top-frame.html	expected actual diff pretty diff		text	pass timeout	history
>++http/wpt/cache-storage/cache-put-keys.https.any.worker.html	expected actual diff pretty diff		text	pass	history
>+Tests that had no expected results (probably new) (1): flag all
>+
>+test	results	image results	actual failure	expected failure	history
>++svg/batik/smallFonts.svg			missing		history
>+Tests that timed out (1): flag all
>+
>++platform/mac/media/audio-session-category-video-paused.html	expected actual diff pretty diff	history
>+Tests that had stderr output (2): flag all
>+
>++http/tests/contentextensions/top-url.html	stderr	history
>++platform/mac/media/audio-session-category-video-paused.html	stderr	history
>+Flaky tests (failed the first run and passed on retry) (1): flag all
>+
>+test	results	image results	actual failure	expected failure	history	failures
>++media/video-loop.html	expected actual diff pretty diff		text pass timeout	pass timeout	history
>+Tests expected to fail but passed (4): flag all
>+
>+test	expected failure
>+canvas/philip/tests/2d.gradient.interpolate.solid.html	fail	history
>+editing/spelling/spelling-marker-includes-hyphen.html	image	history
>+editing/spelling/spelling-markers-in-overlapping-lines.html	image	history
>+webarchive/loading/test-loading-archive-subresource-null-mimetype.html	crash	history
>+httpd access log: access_log.txt
>+httpd error log: error_log.txt

Actions: View | Formatted Diff | Diff

Attachments on bug 188636: 347246