WebKit Bugzilla
Attachment 347210 Details for
Bug 188622
: Remove WKNavigationDelegatePrivate's canAuthenticateAgainstProtectionSpace
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-188622-20180815150123.patch (text/plain), 5.10 KB, created by
Alex Christensen
on 2018-08-15 15:01:24 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Alex Christensen
Created:
2018-08-15 15:01:24 PDT
Size:
5.10 KB
patch
obsolete
>Index: Source/WebKit/ChangeLog >=================================================================== >--- Source/WebKit/ChangeLog (revision 234900) >+++ Source/WebKit/ChangeLog (working copy) >@@ -1,3 +1,18 @@ >+2018-08-15 Alex Christensen <achristensen@webkit.org> >+ >+ Remove WKNavigationDelegatePrivate's canAuthenticateAgainstProtectionSpace >+ https://bugs.webkit.org/show_bug.cgi?id=188622 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ It's been deprecated for a release now, nobody uses it, and it's a concept from NSURLConnection, which we don't use any more in WebKit2. >+ >+ * UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h: >+ * UIProcess/Cocoa/NavigationState.h: >+ * UIProcess/Cocoa/NavigationState.mm: >+ (WebKit::NavigationState::setNavigationDelegate): >+ (WebKit::NavigationState::NavigationClient::canAuthenticateAgainstProtectionSpace): >+ > 2018-08-15 Tim Horton <timothy_horton@apple.com> > > Crashes in Quip under _dictionaryPopupInfoForRange, in setObject:forKey: >Index: Source/WebKit/UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h >=================================================================== >--- Source/WebKit/UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h (revision 234900) >+++ Source/WebKit/UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h (working copy) >@@ -75,7 +75,6 @@ static const WKNavigationResponsePolicy > > - (void)_webView:(WKWebView *)webView renderingProgressDidChange:(_WKRenderingProgressEvents)progressEvents; > >-- (BOOL)_webView:(WKWebView *)webView canAuthenticateAgainstProtectionSpace:(NSURLProtectionSpace *)protectionSpace WK_API_DEPRECATED_WITH_REPLACEMENT("webView:didReceiveAuthenticationChallenge:completionHandler:", macosx(10.10, 10.13.4), ios(8.0, 11.3)); > - (void)_webView:(WKWebView *)webView didReceiveAuthenticationChallenge:(NSURLAuthenticationChallenge *)challenge WK_API_DEPRECATED_WITH_REPLACEMENT("webView:didReceiveAuthenticationChallenge:completionHandler:", macosx(10.10, 10.13.4), ios(8.0, 11.3)); > > - (void)_webViewWebProcessDidCrash:(WKWebView *)webView; >Index: Source/WebKit/UIProcess/Cocoa/NavigationState.h >=================================================================== >--- Source/WebKit/UIProcess/Cocoa/NavigationState.h (revision 234900) >+++ Source/WebKit/UIProcess/Cocoa/NavigationState.h (working copy) >@@ -207,7 +207,6 @@ private: > bool webViewDidReceiveAuthenticationChallengeCompletionHandler : 1; > bool webViewWebContentProcessDidTerminate : 1; > bool webViewWebContentProcessDidTerminateWithReason : 1; >- bool webViewCanAuthenticateAgainstProtectionSpace : 1; > bool webViewDidReceiveAuthenticationChallenge : 1; > bool webViewWebProcessDidCrash : 1; > bool webViewWebProcessDidBecomeResponsive : 1; >Index: Source/WebKit/UIProcess/Cocoa/NavigationState.mm >=================================================================== >--- Source/WebKit/UIProcess/Cocoa/NavigationState.mm (revision 234900) >+++ Source/WebKit/UIProcess/Cocoa/NavigationState.mm (working copy) >@@ -164,7 +164,6 @@ void NavigationState::setNavigationDeleg > m_navigationDelegateMethods.webViewDidReceiveAuthenticationChallengeCompletionHandler = [delegate respondsToSelector:@selector(webView:didReceiveAuthenticationChallenge:completionHandler:)]; > m_navigationDelegateMethods.webViewWebContentProcessDidTerminate = [delegate respondsToSelector:@selector(webViewWebContentProcessDidTerminate:)]; > m_navigationDelegateMethods.webViewWebContentProcessDidTerminateWithReason = [delegate respondsToSelector:@selector(_webView:webContentProcessDidTerminateWithReason:)]; >- m_navigationDelegateMethods.webViewCanAuthenticateAgainstProtectionSpace = [delegate respondsToSelector:@selector(_webView:canAuthenticateAgainstProtectionSpace:)]; > m_navigationDelegateMethods.webViewDidReceiveAuthenticationChallenge = [delegate respondsToSelector:@selector(_webView:didReceiveAuthenticationChallenge:)]; > m_navigationDelegateMethods.webViewWebProcessDidCrash = [delegate respondsToSelector:@selector(_webViewWebProcessDidCrash:)]; > m_navigationDelegateMethods.webViewWebProcessDidBecomeResponsive = [delegate respondsToSelector:@selector(_webViewWebProcessDidBecomeResponsive:)]; >@@ -875,17 +874,7 @@ bool NavigationState::NavigationClient:: > if (m_navigationState.m_navigationDelegateMethods.webViewDidReceiveAuthenticationChallengeCompletionHandler) > return true; > >- if (!m_navigationState.m_navigationDelegateMethods.webViewCanAuthenticateAgainstProtectionSpace) >- return false; >- >- auto navigationDelegate = m_navigationState.m_navigationDelegate.get(); >- if (!navigationDelegate) >- return false; >- >-#pragma clang diagnostic push >-#pragma clang diagnostic ignored "-Wdeprecated-declarations" >- return [static_cast<id <WKNavigationDelegatePrivate>>(navigationDelegate.get()) _webView:m_navigationState.m_webView canAuthenticateAgainstProtectionSpace:protectionSpace->protectionSpace().nsSpace()]; >-#pragma clang diagnostic pop >+ return false; > } > > void NavigationState::NavigationClient::didReceiveAuthenticationChallenge(WebPageProxy&, AuthenticationChallengeProxy& authenticationChallenge)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Flags:
timothy
:
review+
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 188622
: 347210