Attachment 347207 Details for Bug 188618 – Patch

[patch] Patch

bug-188618-20180815135653.patch (text/plain), 4.52 KB, created by Sihui Liu on 2018-08-15 13:56:54 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Sihui Liu

Created: 2018-08-15 13:56:54 PDT

Size: 4.52 KB

patch

obsolete

>Subversion Revision: 234888
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 65b78a253c9de6d06d570c6bdfef158d67ac774b..67e8a2bacb1a140c1abc6ae7b91d0437ff817359 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-08-15  Sihui Liu  <sihui_liu@apple.com>
>+
>+        Remove unused parentProcessName from NetworkProcessCreationParameters
>+        https://bugs.webkit.org/show_bug.cgi?id=188618
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * NetworkProcess/NetworkProcessCreationParameters.cpp:
>+        (WebKit::NetworkProcessCreationParameters::encode const):
>+        (WebKit::NetworkProcessCreationParameters::decode):
>+        * NetworkProcess/NetworkProcessCreationParameters.h:
>+        * UIProcess/Cocoa/WebProcessPoolCocoa.mm:
>+        (WebKit::WebProcessPool::platformInitializeNetworkProcess):
>+
> 2018-08-15  Michael Catanzaro  <mcatanzaro@igalia.com>
> 
>         [WPE][GTK] WaylandCompositor fails to properly remove surface from its page map
>diff --git a/Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.cpp b/Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.cpp
>index b7ab18600717930355670e9c3c407979a766538e..f0f046b0507b1114927ce5ee4e3be85b5fa68665 100644
>--- a/Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.cpp
>+++ b/Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.cpp
>@@ -67,7 +67,6 @@ void NetworkProcessCreationParameters::encode(IPC::Encoder& encoder) const
>     encoder << urlSchemesRegisteredForCustomProtocols;
>     encoder << presentingApplicationPID;
> #if PLATFORM(COCOA)
>-    encoder << parentProcessName;
>     encoder << uiProcessBundleIdentifier;
>     encoder << uiProcessSDKVersion;
>     encoder << sourceApplicationBundleIdentifier;
>@@ -82,7 +81,6 @@ void NetworkProcessCreationParameters::encode(IPC::Encoder& encoder) const
>     encoder << suppressesConnectionTerminationOnSystemChange;
> #endif
> #if USE(SOUP)
>-    encoder << cookiePersistentStoragePath;
>     encoder << cookiePersistentStorageType;
>     encoder.encodeEnum(cookieAcceptPolicy);
>     encoder << ignoreTLSErrors;
>@@ -180,8 +178,6 @@ bool NetworkProcessCreationParameters::decode(IPC::Decoder& decoder, NetworkProc
>     if (!decoder.decode(result.presentingApplicationPID))
>         return false;
> #if PLATFORM(COCOA)
>-    if (!decoder.decode(result.parentProcessName))
>-        return false;
>     if (!decoder.decode(result.uiProcessBundleIdentifier))
>         return false;
>     if (!decoder.decode(result.uiProcessSDKVersion))
>@@ -207,8 +203,6 @@ bool NetworkProcessCreationParameters::decode(IPC::Decoder& decoder, NetworkProc
> #endif
> 
> #if USE(SOUP)
>-    if (!decoder.decode(result.cookiePersistentStoragePath))
>-        return false;
>     if (!decoder.decode(result.cookiePersistentStorageType))
>         return false;
>     if (!decoder.decodeEnum(result.cookieAcceptPolicy))
>diff --git a/Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.h b/Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.h
>index 0e9129b39500d40005cf89723f65206c1fcc1b72..d12e8622be0692ba08f3ea97e81db55818f247ee 100644
>--- a/Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.h
>+++ b/Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.h
>@@ -80,7 +80,6 @@ struct NetworkProcessCreationParameters {
>     ProcessID presentingApplicationPID { 0 };
> 
> #if PLATFORM(COCOA)
>-    String parentProcessName;
>     String uiProcessBundleIdentifier;
>     uint32_t uiProcessSDKVersion { 0 };
>     String sourceApplicationBundleIdentifier;
>@@ -96,7 +95,6 @@ struct NetworkProcessCreationParameters {
> #endif
> 
> #if USE(SOUP)
>-    String cookiePersistentStoragePath;
>     uint32_t cookiePersistentStorageType { 0 };
>     HTTPCookieAcceptPolicy cookieAcceptPolicy { HTTPCookieAcceptPolicyAlways };
>     bool ignoreTLSErrors { false };
>diff --git a/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm b/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
>index ce586dc1355d6a426b4aa12d59b21f70bf70e086..54184b60bd8b2bd5a17e1e008b329924fbd6189e 100644
>--- a/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
>+++ b/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
>@@ -292,7 +292,6 @@ void WebProcessPool::platformInitializeWebProcess(WebProcessCreationParameters&
> 
> void WebProcessPool::platformInitializeNetworkProcess(NetworkProcessCreationParameters& parameters)
> {
>-    parameters.parentProcessName = [[NSProcessInfo processInfo] processName];
>     parameters.uiProcessBundleIdentifier = [[NSBundle mainBundle] bundleIdentifier];
>     parameters.uiProcessSDKVersion = dyld_get_program_sdk_version();
>

Actions: View | Formatted Diff | Diff

Attachments on bug 188618: 347207 | 347212