Attachment 347203 Details for Bug 188615 – Patch

[patch] Patch

bug-188615-20180815133052.patch (text/plain), 1.67 KB, created by Per Arne Vollan on 2018-08-15 13:30:53 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Per Arne Vollan

Created: 2018-08-15 13:30:53 PDT

Size: 1.67 KB

patch

obsolete

>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 234897)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,16 @@
>+2018-08-15  Per Arne Vollan  <pvollan@apple.com>
>+
>+        Assert that calling CGSSetDenyWindowServerConnections(true) succeeds
>+        https://bugs.webkit.org/show_bug.cgi?id=188615
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        If the call to CGSSetDenyWindowServerConnections(true) fails, it means there are open WindowServer connections
>+        at this point, and future WindowServer connections will not be denied. We should assert that this call succeeds.
>+
>+        * WebProcess/cocoa/WebProcessCocoa.mm:
>+        (WebKit::WebProcess::platformInitializeProcess):
>+
> 2018-08-15  Ryan Haddad  <ryanhaddad@apple.com>
> 
>         Unreviewed, rolling out r234870.
>Index: Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm
>===================================================================
>--- Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm	(revision 234885)
>+++ Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm	(working copy)
>@@ -323,7 +323,8 @@ void WebProcess::platformInitializeProce
> #if ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING)
>     // Deny the WebContent process access to the WindowServer.
>     // This call will not succeed if there are open WindowServer connections at this point.
>-    CGSSetDenyWindowServerConnections(true);
>+    auto retval = CGSSetDenyWindowServerConnections(true);
>+    ASSERT_UNUSED(retval, retval == kCGErrorSuccess);
>     // Make sure that we close any WindowServer connections after checking in with Launch Services.
>     CGSShutdownServerConnections();
> #else

Flags:

bfulgham: review+
bfulgham: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 188615: 347203 | 347215 | 347218