Attachment 347198 Details for Bug 188612 – PATCH

[patch] PATCH

188612.diff (text/plain), 3.09 KB, created by Basuke Suzuki on 2018-08-15 13:13:09 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Basuke Suzuki

Created: 2018-08-15 13:13:09 PDT

Size: 3.09 KB

patch

obsolete

>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index ee74960aa01..92f5b977b90 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-08-15  Basuke Suzuki  <Basuke.Suzuki@sony.com>
>+
>+        [Curl] Implement deleteAllCookies()
>+        https://bugs.webkit.org/show_bug.cgi?id=188612
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * platform/wincairo/TestExpectations:
>+          - http/tests/cookies/simple-cookies-expired.html [ Pass ]
>+          - http/tests/cookies/simple-cookies-max-age.html [ Pass ]
>+
> 2018-08-14  Antoine Quint  <graouts@apple.com>
> 
>         [Web Animations] Crash under AnimationTimeline::cancelOrRemoveDeclarativeAnimation()
>diff --git a/LayoutTests/platform/wincairo/TestExpectations b/LayoutTests/platform/wincairo/TestExpectations
>index f96e9c2e889..a5463c9cf20 100644
>--- a/LayoutTests/platform/wincairo/TestExpectations
>+++ b/LayoutTests/platform/wincairo/TestExpectations
>@@ -861,8 +861,6 @@ http/tests/cookies/same-site [ Skip ]
> http/tests/cookies/double-quoted-value-with-semi-colon.html [ Failure ]
> http/tests/cookies/multiple-cookies.html [ Failure ]
> http/tests/cookies/private-cookie-storage.html [ Crash ]
>-http/tests/cookies/simple-cookies-expired.html [ Failure ]
>-http/tests/cookies/simple-cookies-max-age.html [ Failure ]
> http/tests/cookies/third-party-cookie-relaxing.html [ Failure ]
> 
> http/tests/css/cross-fade-reload.html [ Timeout Pass ]
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index af596853ede..3342f2c0efd 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,18 @@
>+2018-08-15  Basuke Suzuki  <Basuke.Suzuki@sony.com>
>+
>+        [Curl] Implement deleteAllCookies()
>+        https://bugs.webkit.org/show_bug.cgi?id=188612
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        deleteAllCookies() was not implemented. Connect the interface to the implementation.
>+
>+        Tests: http/tests/cookies/simple-cookies-expired.html
>+               http/tests/cookies/simple-cookies-max-age.html
>+
>+        * platform/network/curl/CookieJarCurlDatabase.cpp:
>+        (WebCore::CookieJarCurlDatabase::deleteAllCookies const):
>+
> 2018-08-14  Ali Juma  <ajuma@chromium.org>
> 
>         Follow-up: [IntersectionObserver] Implement rootMargin parsing
>diff --git a/Source/WebCore/platform/network/curl/CookieJarCurlDatabase.cpp b/Source/WebCore/platform/network/curl/CookieJarCurlDatabase.cpp
>index 672b2515af2..fad9d94ac32 100644
>--- a/Source/WebCore/platform/network/curl/CookieJarCurlDatabase.cpp
>+++ b/Source/WebCore/platform/network/curl/CookieJarCurlDatabase.cpp
>@@ -128,9 +128,10 @@ void CookieJarCurlDatabase::deleteCookiesForHostnames(const NetworkStorageSessio
>     // FIXME: Not yet implemented
> }
> 
>-void CookieJarCurlDatabase::deleteAllCookies(const NetworkStorageSession&) const
>+void CookieJarCurlDatabase::deleteAllCookies(const NetworkStorageSession& session) const
> {
>-    // FIXME: Not yet implemented
>+    CookieJarDB& cookieJarDB = session.cookieDatabase();
>+    cookieJarDB.deleteAllCookies();
> }
> 
> void CookieJarCurlDatabase::deleteAllCookiesModifiedSince(const NetworkStorageSession&, WallTime) const

Actions: View | Formatted Diff | Diff

Attachments on bug 188612: 347198