WebKit Bugzilla
Attachment 347194 Details for
Bug 188574
: MotionMark fails to display the "run benchmark" button in some situations
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-188574-20180815123742.patch (text/plain), 4.76 KB, created by
Said Abou-Hallawa
on 2018-08-15 12:37:43 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Said Abou-Hallawa
Created:
2018-08-15 12:37:43 PDT
Size:
4.76 KB
patch
obsolete
>Index: PerformanceTests/ChangeLog >=================================================================== >--- PerformanceTests/ChangeLog (revision 234894) >+++ PerformanceTests/ChangeLog (working copy) >@@ -1,3 +1,21 @@ >+2018-08-15 Said Abou-Hallawa <sabouhallawa@apple.com> >+ >+ MotionMark fails to display the "run benchmark" button in some situations >+ https://bugs.webkit.org/show_bug.cgi?id=188574 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Use the media queries to control the visibility of the "run benchmark" >+ button in MotionMark developer page. >+ >+ * MotionMark/developer.html: >+ * MotionMark/resources/debug-runner/motionmark.js: >+ * MotionMark/resources/runner/motionmark.js: >+ (window.benchmarkController.initialize): >+ (window.benchmarkController.addOrientationListenerIfNecessary): Deleted. >+ (window.benchmarkController._orientationChanged): Deleted. >+ (window.benchmarkController.updateStartButtonState): Deleted. >+ > 2018-08-13 Jon Lee <jonlee@apple.com> > > Update MotionMark version number >Index: PerformanceTests/MotionMark/developer.html >=================================================================== >--- PerformanceTests/MotionMark/developer.html (revision 234893) >+++ PerformanceTests/MotionMark/developer.html (working copy) >@@ -113,8 +113,8 @@ > </div> > <p>For accurate results, please take the browser window full screen, or rotate the device to landscape orientation.</p> > <div class="start-benchmark"> >- <p class="hidden">Please rotate the device to orientation before starting.</p> >- <button id="run-benchmark" onclick="benchmarkController.startBenchmark()">Run benchmark</button> >+ <p class="portrait-orientation-check"><b>Please rotate your device.</b></p> >+ <button class="landscape-orientation-check" onclick="benchmarkController.startBenchmark()">Run Benchmark</button> > </div> > </div> > </section> >Index: PerformanceTests/MotionMark/resources/debug-runner/motionmark.js >=================================================================== >--- PerformanceTests/MotionMark/resources/debug-runner/motionmark.js (revision 234893) >+++ PerformanceTests/MotionMark/resources/debug-runner/motionmark.js (working copy) >@@ -548,7 +548,6 @@ Utilities.extendObject(window.benchmarkC > if (benchmarkController.startBenchmarkImmediatelyIfEncoded()) > return; > >- benchmarkController.addOrientationListenerIfNecessary(); > suitesManager.createElements(); > suitesManager.updateUIFromLocalStorage(); > suitesManager.updateEditsElementsState(); >@@ -589,11 +588,6 @@ Utilities.extendObject(window.benchmarkC > > updateStartButtonState: function() > { >- var startButton = document.getElementById("run-benchmark"); >- if ("isInLandscapeOrientation" in this && !this.isInLandscapeOrientation) { >- startButton.disabled = true; >- return; >- } > startButton.disabled = !suitesManager.isAtLeastOneTestSelected(); > }, > >Index: PerformanceTests/MotionMark/resources/runner/motionmark.js >=================================================================== >--- PerformanceTests/MotionMark/resources/runner/motionmark.js (revision 234893) >+++ PerformanceTests/MotionMark/resources/runner/motionmark.js (working copy) >@@ -463,7 +463,6 @@ window.benchmarkController = { > document.querySelectorAll(".version").forEach(function(e) { > e.textContent = Strings.version; > }); >- benchmarkController.addOrientationListenerIfNecessary(); > }, > > determineCanvasSize: function() { >@@ -488,30 +487,6 @@ window.benchmarkController = { > document.body.classList.add("large"); > }, > >- addOrientationListenerIfNecessary: function() { >- if (!("orientation" in window)) >- return; >- >- this.orientationQuery = window.matchMedia("(orientation: landscape)"); >- this._orientationChanged(this.orientationQuery); >- this.orientationQuery.addListener(this._orientationChanged); >- }, >- >- _orientationChanged: function(match) >- { >- benchmarkController.isInLandscapeOrientation = match.matches; >- if (match.matches) >- document.querySelector(".start-benchmark p").classList.add("hidden"); >- else >- document.querySelector(".start-benchmark p").classList.remove("hidden"); >- benchmarkController.updateStartButtonState(); >- }, >- >- updateStartButtonState: function() >- { >- document.getElementById("run-benchmark").disabled = !this.isInLandscapeOrientation; >- }, >- > _startBenchmark: function(suites, options, frameContainerID) > { > benchmarkController.determineCanvasSize();
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Flags:
jonlee
:
review+
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 188574
: 347194