Attachment 347186 Details for Bug 188605 – Patch

[patch] Patch

bug-188605-20180815115323.patch (text/plain), 3.66 KB, created by Alex Christensen on 2018-08-15 11:53:25 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Christensen

Created: 2018-08-15 11:53:25 PDT

Size: 3.66 KB

patch

obsolete

>Index: Source/WebCore/ChangeLog
>===================================================================
>--- Source/WebCore/ChangeLog	(revision 234890)
>+++ Source/WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,15 @@
>+2018-08-15  Alex Christensen  <achristensen@webkit.org>
>+
>+        Remove unused CSSPrimitiveValue::createAllowingMarginQuirk
>+        https://bugs.webkit.org/show_bug.cgi?id=188605
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * css/CSSPrimitiveValue.h:
>+        (WebCore::CSSPrimitiveValue::createAllowingMarginQuirk): Deleted.
>+        * css/CSSValue.h:
>+        (WebCore::CSSValue::CSSValue):
>+
> 2018-08-15  Alex Christensen  <achristensen@webkit.org>
> 
>         Remove failing assertion introduced in r234873
>Index: Source/WebCore/css/CSSPrimitiveValue.h
>===================================================================
>--- Source/WebCore/css/CSSPrimitiveValue.h	(revision 234881)
>+++ Source/WebCore/css/CSSPrimitiveValue.h	(working copy)
>@@ -214,12 +214,6 @@ public:
> 
>     template<typename T> static Ref<CSSPrimitiveValue> create(T&&);
> 
>-    // This value is used to handle quirky margins in reflow roots (body, td, and th) like WinIE.
>-    // The basic idea is that a stylesheet can use the value __qem (for quirky em) instead of em.
>-    // When the quirky value is used, if you're in quirks mode, the margin will collapse away
>-    // inside a table cell.
>-    static Ref<CSSPrimitiveValue> createAllowingMarginQuirk(double value, UnitType);
>-
>     ~CSSPrimitiveValue();
> 
>     void cleanup();
>@@ -276,8 +270,7 @@ public:
> 
>     String customCSSText() const;
> 
>-    // FIXME-NEWPARSER: Can ditch the boolean and just use the unit type once old parser is gone.
>-    bool isQuirkValue() const { return m_isQuirkValue || primitiveType() == CSS_QUIRKY_EMS; }
>+    bool isQuirkValue() const { return primitiveType() == CSS_QUIRKY_EMS; }
> 
>     bool equals(const CSSPrimitiveValue&) const;
> 
>@@ -388,13 +381,6 @@ template<typename T> inline Ref<CSSPrimi
>     return adoptRef(*new CSSPrimitiveValue(std::forward<T>(value)));
> }
> 
>-inline Ref<CSSPrimitiveValue> CSSPrimitiveValue::createAllowingMarginQuirk(double value, UnitType type)
>-{
>-    auto result = adoptRef(*new CSSPrimitiveValue(value, type));
>-    result->m_isQuirkValue = true;
>-    return result;
>-}
>-
> template<typename T, CSSPrimitiveValue::TimeUnit timeUnit> inline T CSSPrimitiveValue::computeTime() const
> {
>     if (timeUnit == Seconds && primitiveType() == CSS_S)
>Index: Source/WebCore/css/CSSValue.cpp
>===================================================================
>--- Source/WebCore/css/CSSValue.cpp	(revision 234881)
>+++ Source/WebCore/css/CSSValue.cpp	(working copy)
>@@ -77,7 +77,7 @@ struct SameSizeAsCSSValue : public RefCo
>     uint32_t bitfields;
> };
> 
>-COMPILE_ASSERT(sizeof(CSSValue) == sizeof(SameSizeAsCSSValue), CSS_value_should_stay_small);
>+static_assert(sizeof(CSSValue) <= sizeof(SameSizeAsCSSValue), "CSSValue should stay small");
> 
> bool CSSValue::isImplicitInitialValue() const
> {
>Index: Source/WebCore/css/CSSValue.h
>===================================================================
>--- Source/WebCore/css/CSSValue.h	(revision 234881)
>+++ Source/WebCore/css/CSSValue.h	(working copy)
>@@ -214,7 +214,6 @@ protected:
>     explicit CSSValue(ClassType classType)
>         : m_primitiveUnitType(0)
>         , m_hasCachedCSSText(false)
>-        , m_isQuirkValue(false)
>         , m_valueListSeparator(SpaceSeparator)
>         , m_classType(classType)
>     {
>@@ -235,7 +234,6 @@ protected:
>     // CSSPrimitiveValue bits:
>     unsigned m_primitiveUnitType : 7; // CSSPrimitiveValue::UnitType
>     mutable unsigned m_hasCachedCSSText : 1;
>-    unsigned m_isQuirkValue : 1;
> 
>     unsigned m_valueListSeparator : ValueListSeparatorBits;
>

Actions: View | Formatted Diff | Diff

Attachments on bug 188605: 347169 | 347186 | 347199 | 347267