Attachment 347184 Details for Bug 188591 – Patch

[patch] Patch

bug-188591-20180815114233.patch (text/plain), 1.85 KB, created by Keith Miller on 2018-08-15 11:42:34 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Keith Miller

Created: 2018-08-15 11:42:34 PDT

Size: 1.85 KB

patch

obsolete

>Subversion Revision: 234862
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index 72cefe5184b3325542198676ae7f69074b26a182..005c26fd423e2651941b15e47fd20b07e120ca83 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-08-14  Keith Miller  <keith_miller@apple.com>
>+
>+        Remove evernote hacks
>+        https://bugs.webkit.org/show_bug.cgi?id=188591
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        The hack was added in 2012 and the evernote app seems to work now.
>+        It's probably not needed anymore.
>+
>+        * API/JSValueRef.cpp:
>+        (JSValueUnprotect):
>+        (evernoteHackNeeded): Deleted.
>+
> 2018-08-14  Keith Miller  <keith_miller@apple.com>
> 
>         Add missing availability macro.
>diff --git a/Source/JavaScriptCore/API/JSValueRef.cpp b/Source/JavaScriptCore/API/JSValueRef.cpp
>index daca0e1b49dd8d512e565dc13cccaf2b97f208b5..23f17bc21bb3c0829de0a560433706850fc1ec05 100644
>--- a/Source/JavaScriptCore/API/JSValueRef.cpp
>+++ b/Source/JavaScriptCore/API/JSValueRef.cpp
>@@ -54,17 +54,6 @@
> 
> using namespace JSC;
> 
>-#if PLATFORM(MAC)
>-static bool evernoteHackNeeded()
>-{
>-    static const int32_t webkitLastVersionWithEvernoteHack = 35133959;
>-    static bool hackNeeded = CFEqual(CFBundleGetIdentifier(CFBundleGetMainBundle()), CFSTR("com.evernote.Evernote"))
>-        && NSVersionOfLinkTimeLibrary("JavaScriptCore") <= webkitLastVersionWithEvernoteHack;
>-
>-    return hackNeeded;
>-}
>-#endif
>-
> ::JSType JSValueGetType(JSContextRef ctx, JSValueRef value)
> {
>     if (!ctx) {
>@@ -485,11 +474,6 @@ void JSValueProtect(JSContextRef ctx, JSValueRef value)
> 
> void JSValueUnprotect(JSContextRef ctx, JSValueRef value)
> {
>-#if PLATFORM(MAC)
>-    if ((!value || !ctx) && evernoteHackNeeded())
>-        return;
>-#endif
>-
>     ExecState* exec = toJS(ctx);
>     JSLockHolder locker(exec);
>

Actions: View | Formatted Diff | Diff

Attachments on bug 188591: 347184