Attachment 347164 Details for Bug 188603 – Patch

[patch] Patch

bug-188603-20180815092045.patch (text/plain), 3.95 KB, created by Alex Christensen on 2018-08-15 09:20:46 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Christensen

Created: 2018-08-15 09:20:46 PDT

Size: 3.95 KB

patch

obsolete

>Index: Source/WebCore/ChangeLog
>===================================================================
>--- Source/WebCore/ChangeLog	(revision 234888)
>+++ Source/WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,12 @@
>+2018-08-15  Alex Christensen  <achristensen@webkit.org>
>+
>+        Remove unused beaconAPIEnabled setting/preference/spi
>+        https://bugs.webkit.org/show_bug.cgi?id=188603
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * page/Settings.yaml:
>+
> 2018-08-15  Wenson Hsieh  <wenson_hsieh@apple.com>
> 
>         [Attachment SPI] Remove attachment display mode options
>Index: Source/WebCore/page/Settings.yaml
>===================================================================
>--- Source/WebCore/page/Settings.yaml	(revision 234881)
>+++ Source/WebCore/page/Settings.yaml	(working copy)
>@@ -589,9 +589,6 @@ subresourceIntegrityEnabled:
> linkPreconnectEnabled:
>   initial: false
> 
>-beaconAPIEnabled:
>-  initial: false
>-
> geolocationFloorLevelEnabled:
>   initial: true
> 
>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 234888)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,16 @@
>+2018-08-15  Alex Christensen  <achristensen@webkit.org>
>+
>+        Remove unused beaconAPIEnabled setting/preference/spi
>+        https://bugs.webkit.org/show_bug.cgi?id=188603
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Shared/WebPreferences.yaml:
>+        * UIProcess/API/C/WKPreferences.cpp:
>+        (WKPreferencesSetBeaconAPIEnabled): Deleted.
>+        (WKPreferencesGetBeaconAPIEnabled): Deleted.
>+        * UIProcess/API/C/WKPreferencesRefPrivate.h:
>+
> 2018-08-15  Michael Catanzaro  <mcatanzaro@igalia.com>
> 
>         [WPE][GTK] WaylandCompositor fails to properly remove surface from its page map
>Index: Source/WebKit/Shared/WebPreferences.yaml
>===================================================================
>--- Source/WebKit/Shared/WebPreferences.yaml	(revision 234881)
>+++ Source/WebKit/Shared/WebPreferences.yaml	(working copy)
>@@ -709,12 +709,6 @@ UserTimingEnabled:
>   humanReadableDescription: "Enable UserTiming API"
>   webcoreBinding: RuntimeEnabledFeatures
> 
>-BeaconAPIEnabled:
>-  type: bool
>-  defaultValue: true
>-  humanReadableName: "Beacon API"
>-  humanReadableDescription: "Beacon API"
>-
> LegacyEncryptedMediaAPIEnabled:
>   type: bool
>   defaultValue: true
>Index: Source/WebKit/UIProcess/API/C/WKPreferences.cpp
>===================================================================
>--- Source/WebKit/UIProcess/API/C/WKPreferences.cpp	(revision 234881)
>+++ Source/WebKit/UIProcess/API/C/WKPreferences.cpp	(working copy)
>@@ -845,16 +845,6 @@ bool WKPreferencesGetInlineMediaPlayback
>     return toImpl(preferencesRef)->inlineMediaPlaybackRequiresPlaysInlineAttribute();
> }
> 
>-void WKPreferencesSetBeaconAPIEnabled(WKPreferencesRef preferencesRef, bool flag)
>-{
>-    toImpl(preferencesRef)->setBeaconAPIEnabled(flag);
>-}
>-
>-bool WKPreferencesGetBeaconAPIEnabled(WKPreferencesRef preferencesRef)
>-{
>-    return toImpl(preferencesRef)->beaconAPIEnabled();
>-}
>-
> void WKPreferencesSetDirectoryUploadEnabled(WKPreferencesRef preferencesRef, bool flag)
> {
>     toImpl(preferencesRef)->setDirectoryUploadEnabled(flag);
>Index: Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h
>===================================================================
>--- Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h	(revision 234881)
>+++ Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h	(working copy)
>@@ -208,10 +208,6 @@ WK_EXPORT void WKPreferencesSetInlineMed
> WK_EXPORT bool WKPreferencesGetInlineMediaPlaybackRequiresPlaysInlineAttribute(WKPreferencesRef preferencesRef);
> 
> // Defaults to false.
>-WK_EXPORT void WKPreferencesSetBeaconAPIEnabled(WKPreferencesRef, bool flag);
>-WK_EXPORT bool WKPreferencesGetBeaconAPIEnabled(WKPreferencesRef);
>-
>-// Defaults to false.
> WK_EXPORT void WKPreferencesSetDirectoryUploadEnabled(WKPreferencesRef, bool flag);
> WK_EXPORT bool WKPreferencesGetDirectoryUploadEnabled(WKPreferencesRef);
>

Flags:

achristensen: review-

Actions: View | Formatted Diff | Diff

Attachments on bug 188603: 347164