Attachment 347163 Details for Bug 188602 – Patch

[patch] Patch

bug-188602-20180815091712.patch (text/plain), 1.85 KB, created by Alex Christensen on 2018-08-15 09:17:13 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Christensen

Created: 2018-08-15 09:17:13 PDT

Size: 1.85 KB

patch

obsolete

>Index: Source/WebCore/ChangeLog
>===================================================================
>--- Source/WebCore/ChangeLog	(revision 234888)
>+++ Source/WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,16 @@
>+2018-08-15  Alex Christensen  <achristensen@webkit.org>
>+
>+        Remove unused allowScriptsToCloseWindows setting
>+        https://bugs.webkit.org/show_bug.cgi?id=188602
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        No change in behaviour. It was always false.
>+
>+        * page/DOMWindow.cpp:
>+        (WebCore::DOMWindow::close):
>+        * page/Settings.yaml:
>+
> 2018-08-15  Wenson Hsieh  <wenson_hsieh@apple.com>
> 
>         [Attachment SPI] Remove attachment display mode options
>Index: Source/WebCore/page/DOMWindow.cpp
>===================================================================
>--- Source/WebCore/page/DOMWindow.cpp	(revision 234881)
>+++ Source/WebCore/page/DOMWindow.cpp	(working copy)
>@@ -1086,9 +1086,7 @@ void DOMWindow::close()
>     if (!m_frame->isMainFrame())
>         return;
> 
>-    bool allowScriptsToCloseWindows = m_frame->settings().allowScriptsToCloseWindows();
>-
>-    if (!(page->openedByDOM() || page->backForward().count() <= 1 || allowScriptsToCloseWindows)) {
>+    if (!(page->openedByDOM() || page->backForward().count() <= 1)) {
>         console()->addMessage(MessageSource::JS, MessageLevel::Warning, "Can't close the window since it was not opened by JavaScript"_s);
>         return;
>     }
>Index: Source/WebCore/page/Settings.yaml
>===================================================================
>--- Source/WebCore/page/Settings.yaml	(revision 234881)
>+++ Source/WebCore/page/Settings.yaml	(working copy)
>@@ -192,8 +192,6 @@ enforceCSSMIMETypeInNoQuirksMode:
>   initial: true
> usesEncodingDetector:
>   initial: false
>-allowScriptsToCloseWindows:
>-  initial: false
> canvasUsesAcceleratedDrawing:
>   initial: false
> acceleratedDrawingEnabled:

Flags:

simon.fraser: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 188602: 347163