Attachment 347139 Details for Bug 188593 – Patch

[patch] Patch

bug-188593-20180814173559.patch (text/plain), 1.55 KB, created by Matt Baker on 2018-08-14 17:36:08 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Matt Baker

Created: 2018-08-14 17:36:08 PDT

Size: 1.55 KB

patch

obsolete

>Subversion Revision: 234822
>diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog
>index b1e1d78832becb6259b00ca6480a6bacfc68d5a9..4807d08ed43421b5119e250ef142756c04048429 100644
>--- a/Source/WebInspectorUI/ChangeLog
>+++ b/Source/WebInspectorUI/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-08-14  Matt Baker  <mattbaker@apple.com>
>+
>+        Web Inspector: Table should not center rows when scrolling them into view
>+        https://bugs.webkit.org/show_bug.cgi?id=188593
>+        <rdar://problem/43311660>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UserInterface/Views/Table.js:
>+        (WI.Table.prototype._handleKeyDown):
>+
> 2018-08-13  Matt Baker  <mattbaker@apple.com>
> 
>         Web Inspector: Table should handle row selection instead of the table delegate
>diff --git a/Source/WebInspectorUI/UserInterface/Views/Table.js b/Source/WebInspectorUI/UserInterface/Views/Table.js
>index b335a9ccac47ca0acc5dfbf33eced2c55bbd1c2c..839c06c7f158d8550cd5ec66fc9b3d365b2b3904 100644
>--- a/Source/WebInspectorUI/UserInterface/Views/Table.js
>+++ b/Source/WebInspectorUI/UserInterface/Views/Table.js
>@@ -1173,7 +1173,7 @@ WI.Table = class Table extends WI.View
> 
>             let row = this._cachedRows.get(this._selectedRowIndex);
>             console.assert(row, "Moving up or down by one should always find a cached row since it is within the overflow bounds.");
>-            row.scrollIntoViewIfNeeded();
>+            row.scrollIntoViewIfNeeded(false);
> 
>             // Force our own scroll update because we may have scrolled.
>             this._cachedScrollTop = NaN;

Actions: View | Formatted Diff | Diff

Attachments on bug 188593: 347136 | 347137 | 347139