Attachment 347122 Details for Bug 188540 – Proposed patch

[patch] Proposed patch

ews_split_mac_high_sierra_v2.patch (text/plain), 3.64 KB, created by Aakash Jain on 2018-08-14 15:59:53 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Aakash Jain

Created: 2018-08-14 15:59:53 PDT

Size: 3.64 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 234863)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,12 @@
>+2018-08-14  Aakash Jain  <aakash_jain@apple.com>
>+
>+        [ews-build] Separate queues for Builders and Testers - macOS High Sierra
>+        https://bugs.webkit.org/show_bug.cgi?id=188540
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * BuildSlaveSupport/ews-build/config.json: Splitted few macOS queues into builders and testers. 
>+
> 2018-08-14  Fujii Hironori  <Hironori.Fujii@sony.com>
> 
>         [webkitpy][Win] LayoutTests: test names should be Unix style, separated by slash not backslash
>Index: Tools/BuildSlaveSupport/ews-build/config.json
>===================================================================
>--- Tools/BuildSlaveSupport/ews-build/config.json	(revision 234862)
>+++ Tools/BuildSlaveSupport/ews-build/config.json	(working copy)
>@@ -241,16 +241,34 @@
>       "workernames": ["ews104", "ews105", "ews106", "ews107"]
>     },
>     {
>-      "name": "macOS-Sierra-Debug-WK1-EWS",
>-      "factory": "MacWK1Factory",
>+      "name": "macOS-Sierra-Debug-Build-EWS",
>+      "factory": "macOSBuildFactory",
>       "platform": "mac-sierra",
>       "configuration": "debug",
>       "architectures": ["x86_64"],
>+      "triggers": ["macos-sierra-debug-wk1-tests-ews"],
>       "workernames": ["ews112", "ews113", "ews114", "ews115", "ews116"]
>     },
>     {
>-      "name": "macOS-High-Sierra-Release-32bit-WK2-EWS",
>-      "factory": "MacWK2Factory",
>+      "name": "macOS-Sierra-Debug-WK1-Tests-EWS",
>+      "factory": "macOSWK1Factory",
>+      "platform": "mac-sierra",
>+      "configuration": "debug",
>+      "architectures": ["x86_64"],
>+      "workernames": ["ews112", "ews113", "ews114", "ews115", "ews116"]
>+    },
>+    {
>+      "name": "macOS-High-Sierra-Release-32bit-Build-EWS",
>+      "factory": "macOSBuildFactory",
>+      "platform": "mac-high-sierra",
>+      "configuration": "release",
>+      "architectures": ["i386"],
>+      "triggers": ["macos-high-sierra-release-32bit-wk2-tests-ews"],
>+      "workernames": ["ews118", "ews119", "ews120"]
>+    },
>+    {
>+      "name": "macOS-High-Sierra-Release-32bit-WK2-Tests-EWS",
>+      "factory": "macOSWK2Factory",
>       "platform": "mac-high-sierra",
>       "configuration": "release",
>       "architectures": ["i386"],
>@@ -318,8 +336,8 @@
>       "name": "try",
>       "port": 5555,
>       "builderNames": ["Style-EWS", "JSC-Tests-EWS", "macOS-Sierra-Release-WK1-EWS", "GTK-Webkit2-EWS", "macOS-Sierra-Release-WK2-EWS",
>-                       "macOS-High-Sierra-Release-32bit-WK2-EWS", "WPE-EWS", "Windows-EWS", "iOS-11-Build-EWS", "WinCairo-EWS", "iOS-11-Simulator-Build-EWS",
>-                       "WebKitPy-Tests-EWS", "WebKitPerl-Tests-EWS", "macOS-Sierra-Debug-WK1-EWS", "Bindings-Tests-EWS"]
>+                       "macOS-High-Sierra-Release-32bit-Build-EWS", "WPE-EWS", "Windows-EWS", "iOS-11-Build-EWS", "WinCairo-EWS", "iOS-11-Simulator-Build-EWS",
>+                       "WebKitPy-Tests-EWS", "WebKitPerl-Tests-EWS", "macOS-Sierra-Debug-Build-EWS", "Bindings-Tests-EWS"]
>     },
>     {
>       "type": "Triggerable",
>@@ -330,6 +348,20 @@
>     },
>     {
>       "type": "Triggerable",
>+      "name": "macos-sierra-debug-wk1-tests-ews",
>+      "builderNames": [
>+        "macOS-Sierra-Debug-WK1-Tests-EWS"
>+      ]
>+    },
>+    {
>+      "type": "Triggerable",
>+      "name": "macos-high-sierra-release-32bit-wk2-tests-ews",
>+      "builderNames": [
>+        "macOS-High-Sierra-Release-32bit-WK2-Tests-EWS"
>+      ]
>+    },
>+    {
>+      "type": "Triggerable",
>       "name": "api-tests-ios-sim-ews",
>       "builderNames": [
>         "API-Tests-iOS-Simulator-EWS"

Flags:

lforschler: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 188540: 347122