Attachment 347109 Details for Bug 188579 – Patch

[patch] Patch

bug-188579-20180814141830.patch (text/plain), 2.62 KB, created by Ben Richards on 2018-08-14 14:18:31 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ben Richards

Created: 2018-08-14 14:18:31 PDT

Size: 2.62 KB

patch

obsolete

>Subversion Revision: 234859
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 33b11eb01641aa739a1272e7b108659d07540366..4512d560d2fbf33b05662fbc4576c961fd09869d 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-08-14  Ben Richards  <benton_richards@apple.com>
>+
>+        Remove api misuse check so that custom webcontent service identifier can be set at runtime
>+        https://bugs.webkit.org/show_bug.cgi?id=188579
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Changed API misuse check so that a custom bundle identifier can be set at runtime with a debug flag
>+
>+        * UIProcess/WebProcessPool.cpp:
>+        (WebKit::WebProcessPool::setCustomWebContentServiceBundleIdentifier):
>+        * UIProcess/WebProcessProxy.cpp:
>+        (WebKit::WebProcessProxy::getLaunchOptions):
>+
> 2018-08-14  Antti Koivisto  <antti@apple.com>
> 
>         RemoteLayerTreeTransaction should use OptionSet for change flags
>diff --git a/Source/WebKit/UIProcess/WebProcessPool.cpp b/Source/WebKit/UIProcess/WebProcessPool.cpp
>index c721a30a76ec554c305b6484482c0146fd399b3b..7a93bf7a72a2bb682a8435a042c6d8058d56c9e8 100644
>--- a/Source/WebKit/UIProcess/WebProcessPool.cpp
>+++ b/Source/WebKit/UIProcess/WebProcessPool.cpp
>@@ -421,7 +421,7 @@ void WebProcessPool::setMaximumNumberOfPrewarmedProcesses(unsigned maximumNumber
> void WebProcessPool::setCustomWebContentServiceBundleIdentifier(const String& customWebContentServiceBundleIdentifier)
> {
>     // Guard against API misuse.
>-    if (m_processes.size() || !customWebContentServiceBundleIdentifier.isAllASCII())
>+    if (!customWebContentServiceBundleIdentifier.isAllASCII())
>         CRASH();
> 
>     m_configuration->setCustomWebContentServiceBundleIdentifier(customWebContentServiceBundleIdentifier);
>diff --git a/Source/WebKit/UIProcess/WebProcessProxy.cpp b/Source/WebKit/UIProcess/WebProcessProxy.cpp
>index 5e0bc60b505f6b1c70dbcd4d32fb8f9aa817f617..1abee56f86ca5e058459e3f7a03f51c77cc95bc8 100644
>--- a/Source/WebKit/UIProcess/WebProcessProxy.cpp
>+++ b/Source/WebKit/UIProcess/WebProcessProxy.cpp
>@@ -162,7 +162,7 @@ void WebProcessProxy::getLaunchOptions(ProcessLauncher::LaunchOptions& launchOpt
> 
>     ChildProcessProxy::getLaunchOptions(launchOptions);
> 
>-    if (!m_processPool->customWebContentServiceBundleIdentifier().isNull())
>+    if (!m_processPool->customWebContentServiceBundleIdentifier().isEmpty())
>         launchOptions.customWebContentServiceBundleIdentifier = m_processPool->customWebContentServiceBundleIdentifier().ascii();
>     if (WebKit::isInspectorProcessPool(processPool()))
>         launchOptions.extraInitializationData.add("inspector-process"_s, "1"_s);

Actions: View | Formatted Diff | Diff

Attachments on bug 188579: 347109