Attachment 347096 Details for Bug 188567 – Patch

[patch] Patch

bug-188567-20180814142403.patch (text/plain), 1.21 KB, created by Patrick Griffis on 2018-08-14 11:24:04 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Patrick Griffis

Created: 2018-08-14 11:24:04 PDT

Size: 1.21 KB

patch

obsolete

>Subversion Revision: 234728
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 9be88423a28c7de03b5fb733d0e940a8c3b8beb5..43c9dcc872c5015aa06c612ba27b762b6154c42a 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-08-14  Patrick Griffis  <pgriffis@igalia.com>
>+
>+        [Flatpak] Fix --cmakeargs
>+        https://bugs.webkit.org/show_bug.cgi?id=188567
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * flatpak/flatpakutils.py:
>+        (WebkitFlatpak.setup_dev_env):
>+
> 2018-08-09  Ross Kirsling  <ross.kirsling@sony.com>
> 
>         Unreviewed follow-up fix for r234720.
>diff --git a/Tools/flatpak/flatpakutils.py b/Tools/flatpak/flatpakutils.py
>index 9abbe7a1e87c04a0e37965c72d6ec0e35e85e78e..e4b217937aa421db490b049b0b07cc536ceea0b7 100644
>--- a/Tools/flatpak/flatpakutils.py
>+++ b/Tools/flatpak/flatpakutils.py
>@@ -787,7 +787,7 @@ class WebkitFlatpak:
>             if self.makeargs:
>                 builder.append("--makeargs=%s" % self.makeargs)
>             if self.cmakeargs:
>-                builder.append("--makeargs=%s" % self.cmakeargs)
>+                builder.append("--cmakeargs=%s" % self.cmakeargs)
>             Console.message("Building webkit")
>             res = self.run_in_sandbox(*builder)
>

Actions: View | Formatted Diff | Diff

Attachments on bug 188567: 347096