Attachment 347087 Details for Bug 188469 – Follow-up fix

[patch] Follow-up fix

bug-188469-20180814130851.patch (text/plain), 1.42 KB, created by Ali Juma on 2018-08-14 10:08:52 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Ali Juma

Created: 2018-08-14 10:08:52 PDT

Size: 1.42 KB

patch

obsolete

>Subversion Revision: 234846
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index cf872ff87eb541e09dbd94a8c225dddf4722ab3f..78a8c8d86eecb1a5c9e9c6ba4588a2a763ccc3d8 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-08-14  Ali Juma  <ajuma@chromium.org>
>+
>+        Follow-up: [IntersectionObserver] Implement rootMargin parsing
>+        https://bugs.webkit.org/show_bug.cgi?id=188469
>+
>+        Address review feedback from Darin Adler.
>+
>+        * page/IntersectionObserver.cpp:
>+        (WebCore::IntersectionObserver::rootMargin const):
>+        Use StringBuilder::appendLiteral instead of ::append to append a literal.
>+
> 2018-08-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
> 
>         Worker should support unhandled promise rejections
>diff --git a/Source/WebCore/page/IntersectionObserver.cpp b/Source/WebCore/page/IntersectionObserver.cpp
>index 604dbcc05463b1c2f1c0e3784387702c6fab8f76..83cb2b0a056938dce242470f6f9fe0019b639800 100644
>--- a/Source/WebCore/page/IntersectionObserver.cpp
>+++ b/Source/WebCore/page/IntersectionObserver.cpp
>@@ -121,7 +121,7 @@ String IntersectionObserver::rootMargin() const
>         if (length.type() == Percent)
>             stringBuilder.append('%');
>         else
>-            stringBuilder.append("px", 2);
>+            stringBuilder.appendLiteral("px");
>         if (side != PhysicalBoxSide::Left)
>             stringBuilder.append(' ');
>     }

Actions: View | Formatted Diff | Diff

Attachments on bug 188469: 346903 | 347087