WebKit Bugzilla
Attachment 347082 Details for
Bug 188557
: [DFG] DFGPredictionPropagation should set PrimaryPass when processing invariants
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch
bug-188557-20180815014530.patch (text/plain), 1.65 KB, created by
Yusuke Suzuki
on 2018-08-14 09:45:31 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Yusuke Suzuki
Created:
2018-08-14 09:45:31 PDT
Size:
1.65 KB
patch
obsolete
>Subversion Revision: 234848 >diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog >index dfea2857d6c330b232bd5d6ced981e34e94d6322..67fba09d7ea3d2d4958debbf7d65ce5837ce9f6a 100644 >--- a/Source/JavaScriptCore/ChangeLog >+++ b/Source/JavaScriptCore/ChangeLog >@@ -1,3 +1,16 @@ >+2018-08-14 Yusuke Suzuki <yusukesuzuki@slowstart.org> >+ >+ [DFG] DFGPredictionPropagation should set PrimaryPass when processing invariants >+ https://bugs.webkit.org/show_bug.cgi?id=188557 >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ DFGPredictionPropagationPhase should set PrimaryPass before processing invariants since >+ processing for ArithRound etc.'s invariants requires `m_pass` load. This issue is found >+ in UBSan's result. >+ >+ * dfg/DFGPredictionPropagationPhase.cpp: >+ > 2018-08-12 Karo Gyoker <karogyoker2+webkit@gmail.com> > > Disable JIT on IA-32 without SSE2 >diff --git a/Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.cpp b/Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.cpp >index 2db3e643b667d1ae0c7a1be03b897de9070fcaea..7e8358dc71d5ed09baadc9628e7c7080fb984f59 100644 >--- a/Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.cpp >+++ b/Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.cpp >@@ -50,11 +50,12 @@ class PredictionPropagationPhase : public Phase { > ASSERT(m_graph.m_form == ThreadedCPS); > ASSERT(m_graph.m_unificationState == GloballyUnified); > >+ m_pass = PrimaryPass; >+ > propagateThroughArgumentPositions(); > > processInvariants(); > >- m_pass = PrimaryPass; > propagateToFixpoint(); > > m_pass = RareCasePass;
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Flags:
mark.lam
:
review+
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 188557
: 347082