Attachment 347061 Details for Bug 188501 – MSVC build fix

[patch] MSVC build fix

bug-188501.diff (text/plain), 1.10 KB, created by Don Olmstead on 2018-08-13 19:07:19 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Don Olmstead

Created: 2018-08-13 19:07:19 PDT

Size: 1.10 KB

patch

obsolete

>diff --git a/Source/WTF/ChangeLog b/Source/WTF/ChangeLog
>index 8098151ccc4..e288cc229ab 100644
>--- a/Source/WTF/ChangeLog
>+++ b/Source/WTF/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-08-13  Don Olmstead  <don.olmstead@sony.com>
>+
>+        Meaning of OptionSet::contains is unclear when used with OptionSet argument
>+        https://bugs.webkit.org/show_bug.cgi?id=188501
>+        <rdar://problem/43246242>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        MSVC is unable to compile contains using an initializer_list within a lambda.
>+
>+        * wtf/OptionSet.h:
>+        (WTF::OptionSet::contains const):
>+
> 2018-08-13  Antti Koivisto  <antti@apple.com>
> 
>         Meaning of OptionSet::contains is unclear when used with OptionSet argument
>diff --git a/Source/WTF/wtf/OptionSet.h b/Source/WTF/wtf/OptionSet.h
>index 4042a4985db..4d6b229b9da 100644
>--- a/Source/WTF/wtf/OptionSet.h
>+++ b/Source/WTF/wtf/OptionSet.h
>@@ -98,7 +98,7 @@ public:
> 
>     constexpr bool contains(T option) const
>     {
>-        return containsAny({ option });
>+        return containsAny(option);
>     }
> 
>     constexpr bool containsAny(OptionSet optionSet) const

Actions: View | Formatted Diff | Diff

Attachments on bug 188501: 347002 | 347019 | 347061