Attachment 347052 Details for Bug 188538 – Patch

[patch] Patch

bug-188538-20180813154517.patch (text/plain), 1.55 KB, created by Thomas Denney on 2018-08-13 15:45:18 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Thomas Denney

Created: 2018-08-13 15:45:18 PDT

Size: 1.55 KB

patch

obsolete

>Subversion Revision: 234820
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 65be7950696aad98ee25a4179887f3bd0ed2f496..76bec3da18cb524ec86d3b2305b4e4d997f60424 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,15 @@
>+2018-08-13  Thomas Denney  <tdenney@apple.com>
>+
>+        Allow the substring 'me' in contributor names and email addresses
>+        https://bugs.webkit.org/show_bug.cgi?id=188538
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        A test didn't permit the string "me" in email addresses or names of contributors.
>+
>+        * Scripts/webkitpy/common/config/committers_unittest.py:
>+        (CommittersTest.test_contributors_by_fuzzy_match):
>+
> 2018-08-13  Commit Queue  <commit-queue@webkit.org>
> 
>         Unreviewed, rolling out r234812.
>diff --git a/Tools/Scripts/webkitpy/common/config/committers_unittest.py b/Tools/Scripts/webkitpy/common/config/committers_unittest.py
>index d9e2e0e75d759d7c1c75190240aac60de3f51d1f..b34f39a77e89aad008a5a19723e70e165642b018 100644
>--- a/Tools/Scripts/webkitpy/common/config/committers_unittest.py
>+++ b/Tools/Scripts/webkitpy/common/config/committers_unittest.py
>@@ -111,7 +111,6 @@ class CommittersTest(unittest.TestCase):
>     def test_contributors_by_fuzzy_match(self):
>         self._assert_fuzz_match('Geof Garen', 'Geoffrey Garen', 4)
>         self._assert_fuzz_match('Sam', 'Sam Weinig', 0)
>-        self._assert_fuzz_match('me', None, 2)
> 
>     # The remaining tests test that certain names are resolved in a specific way.
>     # We break this up into multiple tests so that each is faster and they can

Actions: View | Formatted Diff | Diff

Attachments on bug 188538: 347050 | 347052