Attachment 347049 Details for Bug 188537 – Patch

[patch] Patch

bug-188537-20180813151844.patch (text/plain), 1.65 KB, created by James Savage on 2018-08-13 15:18:45 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: James Savage

Created: 2018-08-13 15:18:45 PDT

Size: 1.65 KB

patch

obsolete

>Subversion Revision: 234714
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 1a7de65ef11598dd4becab5c46542292ae1bd4f1..04dee2f7c50e728732d7932ca8b8a861e5da5aca 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-08-13  James Savage  <james.savage@apple.com>
>+
>+        [iOS] Crash at -[UIViewController _presentViewController:withAnimationController:completion:]
>+        https://bugs.webkit.org/show_bug.cgi?id=188537
>+        <rdar://problem/41400259>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * platform/ios/ValidationBubbleIOS.mm:
>+        (WebCore::ValidationBubble::show): Avoid hitting a UIKit exception for
>+        presenting an already presented view controller by turning the scenario
>+        into an early return.
>+
> 2018-08-08  Don Olmstead  <don.olmstead@sony.com>
> 
>         [Nicosia] Add the Nicosia-specific PlatformLayer type alias
>diff --git a/Source/WebCore/platform/ios/ValidationBubbleIOS.mm b/Source/WebCore/platform/ios/ValidationBubbleIOS.mm
>index 3978fe0fdb211b668451e1165469c326916ee76b..ca010a3de535826e839aaad987e233e46aa070cc 100644
>--- a/Source/WebCore/platform/ios/ValidationBubbleIOS.mm
>+++ b/Source/WebCore/platform/ios/ValidationBubbleIOS.mm
>@@ -135,6 +135,9 @@ ValidationBubble::~ValidationBubble()
> 
> void ValidationBubble::show()
> {
>+    if ([m_popoverController parentViewController] || [m_popoverController presentingViewController])
>+        return;
>+
>     // Protect the validation bubble so it stays alive until it is effectively presented. UIKit does not deal nicely with
>     // dismissing a popover that is being presented.
>     RefPtr<ValidationBubble> protectedThis(this);

Actions: View | Formatted Diff | Diff

Attachments on bug 188537: 347049