Attachment 347042 Details for Bug 188533 – Proposed patch

[patch] Proposed patch

ews_platform.patch (text/plain), 1.47 KB, created by Aakash Jain on 2018-08-13 14:44:34 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Aakash Jain

Created: 2018-08-13 14:44:34 PDT

Size: 1.47 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 234817)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,13 @@
>+2018-08-13  Aakash Jain  <aakash_jain@apple.com>
>+
>+        [ews-build] Allow * as platform for builders and workers
>+        https://bugs.webkit.org/show_bug.cgi?id=188533
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * BuildSlaveSupport/ews-build/loadConfig.py:
>+        (checkWorkersAndBuildersForConsistency):
>+
> 2018-08-13  Wenson Hsieh  <wenson_hsieh@apple.com>
> 
>         [WK2] [macOS] Implement a mechanism to test drag and drop
>Index: Tools/BuildSlaveSupport/ews-build/loadConfig.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-build/loadConfig.py	(revision 234790)
>+++ Tools/BuildSlaveSupport/ews-build/loadConfig.py	(working copy)
>@@ -159,7 +159,7 @@ def checkWorkersAndBuildersForConsistenc
>             if worker is None:
>                 raise Exception('Builder {} has worker {}, which is not defined in workers list!'.format(builder['name'], worker_name))
> 
>-            if worker['platform'] != builder['platform']:
>+            if worker['platform'] != builder['platform'] and worker['platform'] != '*' and builder['platform'] != '*':
>                 raise Exception('Builder {0} is for platform {1}, but has worker {2} for platform {3}!'.format(
>                     builder['name'], builder['platform'], worker['name'], worker['platform']))
>

Actions: View | Formatted Diff | Diff

Attachments on bug 188533: 347042 | 347291