Attachment 347027 Details for Bug 188528 – Patch

[patch] Patch

bug-188528-20180813124646.patch (text/plain), 3.98 KB, created by Alex Christensen on 2018-08-13 12:46:46 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Alex Christensen

Created: 2018-08-13 12:46:46 PDT

Size: 3.98 KB

patch

obsolete

>Index: Source/WebCore/ChangeLog
>===================================================================
>--- Source/WebCore/ChangeLog	(revision 234811)
>+++ Source/WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,17 @@
>+2018-08-13  Alex Christensen  <achristensen@webkit.org>
>+
>+        Remove unused code in CSSParserSelector/CSSSelector
>+        https://bugs.webkit.org/show_bug.cgi?id=188528
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * css/CSSSelector.cpp:
>+        * css/CSSSelector.h:
>+        (WebCore::CSSSelector::serializingValue const):
>+        (WebCore::CSSSelector::setAttributeValueMatchingIsCaseInsensitive): Deleted.
>+        * css/parser/CSSParserSelector.h:
>+        (WebCore::CSSParserSelector::setAttributeValueMatchingIsCaseInsensitive): Deleted.
>+
> 2018-08-13  Antti Koivisto  <antti@apple.com>
> 
>         Meaning of OptionSet::contains is unclear when used with OptionSet argument
>Index: Source/WebCore/css/CSSSelector.cpp
>===================================================================
>--- Source/WebCore/css/CSSSelector.cpp	(revision 234663)
>+++ Source/WebCore/css/CSSSelector.cpp	(working copy)
>@@ -751,13 +751,6 @@ String CSSSelector::selectorText(const S
>     return str.toString() + rightSide;
> }
> 
>-void CSSSelector::setAttribute(const QualifiedName& value, bool isCaseInsensitive)
>-{
>-    createRareData();
>-    m_data.m_rareData->m_attribute = value;
>-    m_data.m_rareData->m_attributeCanonicalLocalName = isCaseInsensitive ? value.localName().convertToASCIILowercase() : value.localName();
>-}
>-
> void CSSSelector::setAttribute(const QualifiedName& value, bool convertToLowercase, AttributeMatchType matchType)
> {
>     createRareData();
>Index: Source/WebCore/css/CSSSelector.h
>===================================================================
>--- Source/WebCore/css/CSSSelector.h	(revision 234663)
>+++ Source/WebCore/css/CSSSelector.h	(working copy)
>@@ -242,9 +242,6 @@ namespace WebCore {
> 
>         void setValue(const AtomicString&, bool matchLowerCase = false);
>         
>-        // FIXME-NEWPARSER: These two methods can go away once the old parser is gone.
>-        void setAttribute(const QualifiedName&, bool);
>-        void setAttributeValueMatchingIsCaseInsensitive(bool);
>         void setAttribute(const QualifiedName&, bool convertToLowercase, AttributeMatchType);
>         void setNth(int a, int b);
>         void setArgument(const AtomicString&);
>@@ -587,12 +584,6 @@ inline const AtomicString& CSSSelector::
>     // AtomicString is really just an AtomicStringImpl* so the cast below is safe.
>     return *reinterpret_cast<const AtomicString*>(&m_data.m_value);
> }
>-
>-inline void CSSSelector::setAttributeValueMatchingIsCaseInsensitive(bool isCaseInsensitive)
>-{
>-    ASSERT(isAttributeSelector() && match() != CSSSelector::Set);
>-    m_caseInsensitiveAttributeValueMatching = isCaseInsensitive;
>-}
>     
> inline bool CSSSelector::attributeValueMatchingIsCaseInsensitive() const
> {
>Index: Source/WebCore/css/parser/CSSParserSelector.h
>===================================================================
>--- Source/WebCore/css/parser/CSSParserSelector.h	(revision 234663)
>+++ Source/WebCore/css/parser/CSSParserSelector.h	(working copy)
>@@ -52,11 +52,7 @@ public:
>     std::unique_ptr<CSSSelector> releaseSelector() { return WTFMove(m_selector); }
> 
>     void setValue(const AtomicString& value, bool matchLowerCase = false) { m_selector->setValue(value, matchLowerCase); }
>-    
>-    // FIXME-NEWPARSER: These two methods can go away once old parser is gone.
>-    void setAttribute(const QualifiedName& value, bool isCaseInsensitive) { m_selector->setAttribute(value, isCaseInsensitive); }
>-    void setAttributeValueMatchingIsCaseInsensitive(bool isCaseInsensitive) { m_selector->setAttributeValueMatchingIsCaseInsensitive(isCaseInsensitive); }
>-    
>+
>     void setAttribute(const QualifiedName& value, bool convertToLowercase, CSSSelector::AttributeMatchType type) { m_selector->setAttribute(value, convertToLowercase, type); }
>     
>     void setArgument(const AtomicString& value) { m_selector->setArgument(value); }

Flags:

simon.fraser: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 188528: 347027