Attachment 346995 Details for Bug 188498 – Proposed patch

[patch] Proposed patch

ews_wk1_layout_tests.patch (text/plain), 3.64 KB, created by Aakash Jain on 2018-08-12 22:55:06 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Aakash Jain

Created: 2018-08-12 22:55:06 PDT

Size: 3.64 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 234790)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2018-08-12  Aakash Jain  <aakash_jain@apple.com>
>+
>+        [ews-build] Add build step to run WK1 layout-test
>+        https://bugs.webkit.org/show_bug.cgi?id=188498
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * BuildSlaveSupport/ews-build/steps.py:
>+        (RunWebKit1Tests): Class to run WebKit1Tests.
>+        * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
>+
> 2018-08-12  Zalan Bujtas  <zalan@apple.com>
> 
>         [LFC] Float prev/next sibling should prevent top/bottom margin collapsing with parent.
>Index: Tools/BuildSlaveSupport/ews-build/steps.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-build/steps.py	(revision 234790)
>+++ Tools/BuildSlaveSupport/ews-build/steps.py	(working copy)
>@@ -423,6 +423,13 @@ class RunWebKitTests(shell.Test):
>         return shell.Test.start(self)
> 
> 
>+class RunWebKit1Tests(RunWebKitTests):
>+    def start(self):
>+        self.setCommand(self.command + ['--dump-render-tree'])
>+
>+        return RunWebKitTests.start(self)
>+
>+
> class ArchiveBuiltProduct(shell.ShellCommand):
>     command = ['python', 'Tools/BuildSlaveSupport/built-product-archive',
>                WithProperties('--platform=%(fullPlatform)s'), WithProperties('--%(configuration)s'), 'archive']
>Index: Tools/BuildSlaveSupport/ews-build/steps_unittest.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-build/steps_unittest.py	(revision 234790)
>+++ Tools/BuildSlaveSupport/ews-build/steps_unittest.py	(working copy)
>@@ -756,6 +756,42 @@ class TestRunWebKitTests(BuildStepMixinA
>         return self.runStep()
> 
> 
>+class TestRunWebKit1Tests(BuildStepMixinAdditions, unittest.TestCase):
>+    def setUp(self):
>+        self.longMessage = True
>+        return self.setUpBuildStep()
>+
>+    def tearDown(self):
>+        return self.tearDownBuildStep()
>+
>+    def test_success(self):
>+        self.setupStep(RunWebKit1Tests())
>+        self.setProperty('fullPlatform', 'ios-simulator')
>+        self.setProperty('configuration', 'debug')
>+        self.expectRemoteCommands(
>+            ExpectShell(workdir='wkdir',
>+                        command=['python', 'Tools/Scripts/run-webkit-tests', '--no-build', '--no-new-test-results', '--no-show-results', '--exit-after-n-failures', '30', '--skip-failing-tests', '--debug', '--dump-render-tree', '--results-directory', 'layout-test-results', '--debug-rwt-logging'],
>+                        )
>+            + 0,
>+        )
>+        self.expectOutcome(result=SUCCESS, state_string='layout-tests')
>+        return self.runStep()
>+
>+    def test_failure(self):
>+        self.setupStep(RunWebKit1Tests())
>+        self.setProperty('fullPlatform', 'ios-simulator')
>+        self.setProperty('configuration', 'release')
>+        self.expectRemoteCommands(
>+            ExpectShell(workdir='wkdir',
>+                        command=['python', 'Tools/Scripts/run-webkit-tests', '--no-build', '--no-new-test-results', '--no-show-results', '--exit-after-n-failures', '30', '--skip-failing-tests', '--release', '--dump-render-tree', '--results-directory', 'layout-test-results', '--debug-rwt-logging'],
>+                        )
>+            + ExpectShell.log('stdio', stdout='9 failures found.')
>+            + 2,
>+        )
>+        self.expectOutcome(result=FAILURE, state_string='layout-tests (failure)')
>+        return self.runStep()
>+
>+
> class TestArchiveBuiltProduct(BuildStepMixinAdditions, unittest.TestCase):
>     def setUp(self):
>         self.longMessage = True

Flags:

lforschler: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 188498: 346995 | 347103