Attachment 346993 Details for Bug 188493 – Patch

[patch] Patch

bug-188493-20180813091504.patch (text/plain), 4.96 KB, created by Yusuke Suzuki on 2018-08-12 17:15:05 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Yusuke Suzuki

Created: 2018-08-12 17:15:05 PDT

Size: 4.96 KB

patch

obsolete

>Subversion Revision: 234789
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index f139546d3bdcd461fecc428bf1069744da87c3cd..15fe0dd5d8d155ad8b8ce869789e8a0c5a0c1484 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,23 @@
>+2018-08-12  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
>+
>+        Expose CloseEvent and CustomEvent to workers
>+        https://bugs.webkit.org/show_bug.cgi?id=188493
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This patch exposes CloseEvent and CustomEvent to workers.
>+        It is OK since they do not depend on things in the main thread.
>+        For example, we cannot expose FormData right now since it depends
>+        on Page.
>+
>+        We do not expose PromiseRejectionEvent in this patch since it will
>+        be done in [1].
>+
>+        [1]: https://bugs.webkit.org/show_bug.cgi?id=188265
>+
>+        * Modules/websockets/CloseEvent.idl:
>+        * dom/CustomEvent.idl:
>+
> 2018-08-12  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
> 
>         Break reference cycle in ErrorEvent by using JSValueInWrappedObject
>diff --git a/Source/WebCore/Modules/websockets/CloseEvent.idl b/Source/WebCore/Modules/websockets/CloseEvent.idl
>index db536c22797196655e661907290bc47e516d8f46..eeccfeba05f69cf432a335e7ac5c20f36b7fdb25 100644
>--- a/Source/WebCore/Modules/websockets/CloseEvent.idl
>+++ b/Source/WebCore/Modules/websockets/CloseEvent.idl
>@@ -28,9 +28,9 @@
>  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>  */
> 
>-// FIXME: This should be exposed to workers as well.
> [
>     Constructor(DOMString type, optional CloseEventInit eventInitDict),
>+    Exposed=(Window,Worker),
> ] interface CloseEvent : Event {
>     readonly attribute boolean wasClean;
>     readonly attribute unsigned short code;
>diff --git a/Source/WebCore/dom/CustomEvent.idl b/Source/WebCore/dom/CustomEvent.idl
>index 7d39bb1f19725796159fe194807f11fb38767dde..78fcea2b1abbc0f314f40bd93af2edac21045bb6 100644
>--- a/Source/WebCore/dom/CustomEvent.idl
>+++ b/Source/WebCore/dom/CustomEvent.idl
>@@ -24,9 +24,9 @@
>  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
>  */
> 
>-// FIXME: This should be exposed to workers as well.
> [
>     Constructor(DOMString type, optional CustomEventInit eventInitDict),
>+    Exposed=(Window,Worker),
>     JSCustomMarkFunction,
> ] interface CustomEvent : Event {
>     [CustomGetter] readonly attribute any detail;
>diff --git a/LayoutTests/imported/w3c/ChangeLog b/LayoutTests/imported/w3c/ChangeLog
>index cb3cafc97e2609826c46fd97b1263f5687eb7ae7..f407cb61a111bf8cfc2afa3b0e1a72cf8b671014 100644
>--- a/LayoutTests/imported/w3c/ChangeLog
>+++ b/LayoutTests/imported/w3c/ChangeLog
>@@ -1,3 +1,12 @@
>+2018-08-12  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
>+
>+        Expose CloseEvent and CustomEvent to workers
>+        https://bugs.webkit.org/show_bug.cgi?id=188493
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * web-platform-tests/workers/semantics/interface-objects/001.worker-expected.txt:
>+
> 2018-08-10  Ali Juma  <ajuma@chromium.org>
> 
>         [IntersectionObserver] Implement rootMargin parsing
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/workers/semantics/interface-objects/001.worker-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/workers/semantics/interface-objects/001.worker-expected.txt
>index 57e385273e0a5257f077e5b8fff538223ac6a088..a4bd1f8bc52a3bae5e3740bbf935b9389940fc26 100644
>--- a/LayoutTests/imported/w3c/web-platform-tests/workers/semantics/interface-objects/001.worker-expected.txt
>+++ b/LayoutTests/imported/w3c/web-platform-tests/workers/semantics/interface-objects/001.worker-expected.txt
>@@ -15,7 +15,7 @@ PASS The Path2D interface object should be exposed.
> FAIL The PromiseRejectionEvent interface object should be exposed. assert_own_property: expected property "PromiseRejectionEvent" missing
> PASS The EventSource interface object should be exposed. 
> PASS The WebSocket interface object should be exposed. 
>-FAIL The CloseEvent interface object should be exposed. assert_own_property: expected property "CloseEvent" missing
>+PASS The CloseEvent interface object should be exposed. 
> FAIL The BroadcastChannel interface object should be exposed. assert_own_property: expected property "BroadcastChannel" missing
> PASS The ArrayBuffer interface object should be exposed. 
> PASS The Int8Array interface object should be exposed. 
>@@ -43,7 +43,7 @@ PASS The FileReaderSync interface object should be exposed.
> PASS The EventTarget interface object should be exposed. 
> PASS The ErrorEvent interface object should be exposed. 
> PASS The Event interface object should be exposed. 
>-FAIL The CustomEvent interface object should be exposed. assert_own_property: expected property "CustomEvent" missing
>+PASS The CustomEvent interface object should be exposed. 
> PASS The DOMException interface object should be exposed. 
> PASS The ReadableStream interface object should be exposed. 
> FAIL The WritableStream interface object should be exposed. assert_own_property: expected property "WritableStream" missing

Actions: View | Formatted Diff | Diff

Attachments on bug 188493: 346993