WebKit Bugzilla
Attachment 346941 Details for
Bug 164833
: LayoutTest inspector/worker/debugger-pause.html is a flaky failure
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
Remember
[x]
|
Forgot Password
Login:
[x]
[patch]
[PATCH] Proposed Fix
worker-test-1.patch (text/plain), 3.17 KB, created by
Joseph Pecoraro
on 2018-08-10 16:55:28 PDT
(
hide
)
Description:
[PATCH] Proposed Fix
Filename:
MIME Type:
Creator:
Joseph Pecoraro
Created:
2018-08-10 16:55:28 PDT
Size:
3.17 KB
patch
obsolete
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog >index 523b17f7c6c..c0a359dae86 100644 >--- a/LayoutTests/ChangeLog >+++ b/LayoutTests/ChangeLog >@@ -1,3 +1,20 @@ >+2018-08-10 Joseph Pecoraro <pecoraro@apple.com> >+ >+ LayoutTest inspector/worker/debugger-pause.html is a flaky failure >+ https://bugs.webkit.org/show_bug.cgi?id=164833 >+ <rdar://problem/29295404> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ * inspector/worker/debugger-pause.html: >+ Add a microtask turn to ensure the workerTarget's mainResource is setup. >+ There were times it might not get setup, but a single turn appears >+ reliable enough. >+ >+ * platform/gtk/TestExpectations: >+ * platform/mac/TestExpectations: >+ This test always passes for me in Release and Debug. Reset expectations. >+ > 2018-08-10 Joseph Pecoraro <pecoraro@apple.com> > > Web Inspector: console.log fires getters for deep properties >diff --git a/LayoutTests/inspector/worker/debugger-pause.html b/LayoutTests/inspector/worker/debugger-pause.html >index c745c806c10..0de5134a34d 100644 >--- a/LayoutTests/inspector/worker/debugger-pause.html >+++ b/LayoutTests/inspector/worker/debugger-pause.html >@@ -111,8 +111,11 @@ function test() > } > }); > >- window.loadLinesFromSourceCode(workerTarget.mainResource).then(() => { >- suite.runTestCasesAndFinish(); >+ // Turn once to ensure workerTarget.mainResource is loaded. >+ Promise.resolve().then(() => { >+ window.loadLinesFromSourceCode(workerTarget.mainResource).then(() => { >+ suite.runTestCasesAndFinish(); >+ }); > }); > } > </script> >diff --git a/LayoutTests/platform/gtk/TestExpectations b/LayoutTests/platform/gtk/TestExpectations >index 7742536077a..3522ef5a8f0 100644 >--- a/LayoutTests/platform/gtk/TestExpectations >+++ b/LayoutTests/platform/gtk/TestExpectations >@@ -1840,8 +1840,6 @@ webkit.org/b/172283 inspector/worker/debugger-multiple-targets-pause.html [ Time > > webkit.org/b/172815 imported/w3c/i18n/bidi/bidi-plaintext-011.html [ Pass ImageOnlyFailure ] > >-webkit.org/b/164833 inspector/worker/debugger-pause.html [ Pass Failure Timeout ] >- > webkit.org/b/173412 fast/scrolling/overflow-scrollable-after-back.html [ Pass Failure ] > > webkit.org/b/168373 media/video-seek-past-end-paused.html [ Failure Pass ] >diff --git a/LayoutTests/platform/mac/TestExpectations b/LayoutTests/platform/mac/TestExpectations >index e6054ea6bbd..9cb6a5dd3c2 100644 >--- a/LayoutTests/platform/mac/TestExpectations >+++ b/LayoutTests/platform/mac/TestExpectations >@@ -1102,7 +1102,6 @@ webkit.org/b/181832 inspector/unit-tests/throttle.html [ Pass Failure ] > webkit.org/b/161361 inspector/unit-tests/yieldable-task.html [ Pass Failure ] > webkit.org/b/169228 inspector/worker/console-basic.html [ Pass Timeout ] > webkit.org/b/164872 inspector/worker/debugger-multiple-targets-pause.html [ Pass Failure Timeout ] >-webkit.org/b/164833 inspector/worker/debugger-pause.html [ Pass Failure Timeout ] > webkit.org/b/165582 inspector/worker/debugger-scripts.html [ Pass Failure ] > webkit.org/b/167203 inspector/worker/debugger-shared-breakpoint.html [ Pass Failure Timeout ] > webkit.org/b/155607 inspector/heap/snapshot.html [ Pass Timeout ]
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 164833
: 346941