Attachment 346919 Details for Bug 188478 – Patch v1

[patch] Patch v1

bug-188478-20180810134737.patch (text/plain), 2.68 KB, created by David Kilzer (:ddkilzer) on 2018-08-10 13:47:38 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: David Kilzer (:ddkilzer)

Created: 2018-08-10 13:47:38 PDT

Size: 2.68 KB

patch

obsolete

>Subversion Revision: 234690
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index a8463f581e6dc46dbaeef030ce65bea97cc066d4..5de1f348dc288dfff555ef37862dd5ea4de57597 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,23 @@
>+2018-08-10  David Kilzer  <ddkilzer@apple.com>
>+
>+        [Cocoa] WebKit::PlatformPopupMenuData should use member initialization
>+        <https://webkit.org/b/188478>
>+        <rdar://problem/43154363>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Shared/PlatformPopupMenuData.cpp:
>+        (WebKit::PlatformPopupMenuData::PlatformPopupMenuData): Delete
>+        implementation.  This constructor caused the warning by never
>+        initializing its member variables.
>+        * Shared/PlatformPopupMenuData.h:
>+        (WebKit::PlatformPopupMenuData::PlatformPopupMenuData):
>+        - Use default constructor.
>+        (WebKit::PlatformPopupMenuData::shouldPopOver):
>+        (WebKit::PlatformPopupMenuData::hideArrows):
>+        (WebKit::PlatformPopupMenuData::menuSize):
>+        - Add struct member initialization.
>+
> 2018-08-05  Darin Adler  <darin@apple.com>
> 
>         [Cocoa] More tweaks and refactoring to prepare for ARC
>diff --git a/Source/WebKit/Shared/PlatformPopupMenuData.cpp b/Source/WebKit/Shared/PlatformPopupMenuData.cpp
>index 2c066913606eb73086c4ce159344b91aa8619bd9..b948819e6f0e6495eee0e710d9b5b57e767fb26c 100644
>--- a/Source/WebKit/Shared/PlatformPopupMenuData.cpp
>+++ b/Source/WebKit/Shared/PlatformPopupMenuData.cpp
>@@ -30,10 +30,6 @@
> 
> namespace WebKit {
> 
>-PlatformPopupMenuData::PlatformPopupMenuData()
>-{
>-}
>-
> void PlatformPopupMenuData::encode(IPC::Encoder& encoder) const
> {
> #if PLATFORM(COCOA)
>diff --git a/Source/WebKit/Shared/PlatformPopupMenuData.h b/Source/WebKit/Shared/PlatformPopupMenuData.h
>index b295a67c5ac1d776bc042b9982069f8e56e7093f..59949870ecc423cc998c16e3a8e75918e3b80d04 100644
>--- a/Source/WebKit/Shared/PlatformPopupMenuData.h
>+++ b/Source/WebKit/Shared/PlatformPopupMenuData.h
>@@ -38,7 +38,7 @@ class Encoder;
> namespace WebKit {
> 
> struct PlatformPopupMenuData {
>-    PlatformPopupMenuData();
>+    PlatformPopupMenuData() = default;
> 
>     void encode(IPC::Encoder&) const;
>     static bool decode(IPC::Decoder&, PlatformPopupMenuData&);
>@@ -46,9 +46,9 @@ struct PlatformPopupMenuData {
> 
> #if PLATFORM(COCOA)
>     FontInfo fontInfo;
>-    bool shouldPopOver;
>-    bool hideArrows;
>-    WebCore::PopupMenuStyle::PopupMenuSize menuSize;
>+    bool shouldPopOver { false };
>+    bool hideArrows { false };
>+    WebCore::PopupMenuStyle::PopupMenuSize menuSize { WebCore::PopupMenuStyle::PopupMenuSize::PopupMenuSizeNormal };
> #elif PLATFORM(WIN)
>     int m_clientPaddingLeft { 0 };
>     int m_clientPaddingRight { 0 };

Actions: View | Formatted Diff | Diff

Attachments on bug 188478: 346919