Attachment 346916 Details for Bug 188476 – Patch

[patch] Patch

bug-188476-20180810210731.patch (text/plain), 3.35 KB, created by karogyoker2+webkit on 2018-08-10 12:07:26 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: karogyoker2+webkit

Created: 2018-08-10 12:07:26 PDT

Size: 3.35 KB

patch

obsolete

>Index: ChangeLog
>===================================================================
>--- ChangeLog	(revision 234702)
>+++ ChangeLog	(working copy)
>@@ -1,3 +1,16 @@
>+2018-08-10  Karo Gyoker  <karogyoker2+webkit@gmail.com>
>+
>+        [CMake][GTK] Disable JIT on IA-32 without SSE2
>+        https://bugs.webkit.org/show_bug.cgi?id=188476
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        IA-32 CPUs without SSE2 are crashing due to illegal instruction
>+        if the JIT is turned on.
>+
>+        * Source/cmake/OptionsGTK.cmake:
>+        * Source/cmake/WebKitFeatures.cmake:
>+
> 2018-07-30  Thibault Saunier  <tsaunier@igalia.com>
> 
>         [GStreamer] Make codecparsers optionnal
>Index: Source/WTF/ChangeLog
>===================================================================
>--- Source/WTF/ChangeLog	(revision 234764)
>+++ Source/WTF/ChangeLog	(working copy)
>@@ -1,3 +1,15 @@
>+2018-08-10  Karo Gyoker  <karogyoker2+webkit@gmail.com>
>+
>+        [CMake][GTK] Disable JIT on IA-32 without SSE2
>+        https://bugs.webkit.org/show_bug.cgi?id=188476
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        IA-32 CPUs without SSE2 are crashing due to illegal instruction
>+        if the JIT is turned on.
>+
>+        * wtf/Platform.h:
>+
> 2018-08-09  Ben Richards  <benton_richards@apple.com>
> 
>         We should cache the compiled sandbox profile in a data vault
>Index: Source/WTF/wtf/Platform.h
>===================================================================
>--- Source/WTF/wtf/Platform.h	(revision 234702)
>+++ Source/WTF/wtf/Platform.h	(working copy)
>@@ -738,9 +738,9 @@
> #endif
> #endif /* !defined(USE_JSVALUE64) && !defined(USE_JSVALUE32_64) */
> 
>-/* The JIT is enabled by default on all x86, x86-64, ARM & MIPS platforms except ARMv7k. */
>+/* The JIT is enabled by default on all x86 with SSE2, x86-64, ARM & MIPS platforms except ARMv7k. */
> #if !defined(ENABLE_JIT) \
>-    && (CPU(X86) || CPU(X86_64) || CPU(ARM) || (CPU(ARM64) && !defined(__ILP32__)) || CPU(MIPS)) \
>+    && (CPU(X86_SSE2) || CPU(X86_64) || CPU(ARM) || (CPU(ARM64) && !defined(__ILP32__)) || CPU(MIPS)) \
>     && !CPU(APPLE_ARMV7K)
> #define ENABLE_JIT 1
> #endif
>Index: Source/cmake/OptionsGTK.cmake
>===================================================================
>--- Source/cmake/OptionsGTK.cmake	(revision 234702)
>+++ Source/cmake/OptionsGTK.cmake	(working copy)
>@@ -126,7 +126,6 @@ WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_
> WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DRAG_SUPPORT PUBLIC ON)
> WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_GEOLOCATION PUBLIC ON)
> WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ICONDATABASE PUBLIC ON)
>-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_JIT PUBLIC ON)
> WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SAMPLING_PROFILER PUBLIC ON)
> WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SPELLCHECK PUBLIC ON)
> WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_TOUCH_EVENTS PUBLIC ON)
>Index: Source/cmake/WebKitFeatures.cmake
>===================================================================
>--- Source/cmake/WebKitFeatures.cmake	(revision 234702)
>+++ Source/cmake/WebKitFeatures.cmake	(working copy)
>@@ -72,7 +72,7 @@ macro(WEBKIT_OPTION_BEGIN)
>         set(ENABLE_FTL_DEFAULT OFF)
>     endif ()
> 
>-    if (WTF_CPU_ARM OR WTF_CPU_ARM64 OR WTF_CPU_MIPS OR WTF_CPU_X86_64 OR WTF_CPU_X86)
>+    if (WTF_CPU_ARM OR WTF_CPU_ARM64 OR WTF_CPU_MIPS OR WTF_CPU_X86_64 OR WTF_CPU_X86_SSE2)
>         set(ENABLE_JIT_DEFAULT ON)
>         set(USE_SYSTEM_MALLOC_DEFAULT OFF)
>     else ()

Actions: View | Formatted Diff | Diff

Attachments on bug 188476: 346916 | 346962 | 346968 | 346984