Attachment 346909 Details for Bug 188461 – Patch

[patch] Patch

bug-188461-20180810101615.patch (text/plain), 1.62 KB, created by Sihui Liu on 2018-08-10 10:16:16 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Sihui Liu

Created: 2018-08-10 10:16:16 PDT

Size: 1.62 KB

patch

obsolete

>Subversion Revision: 234733
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 994a0560fbed876db99b3c2467c2feac27e8ba24..0e89e73674fa08c8b25bd6c9183b8ad5d853a87c 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-08-10  Sihui Liu  <sihui_liu@apple.com>
>+
>+        CrashTracer: com.apple.WebKit.Storage at WebCore::IDBServer::UniqueIDBDatabase::scheduleShutdownForClose
>+        https://bugs.webkit.org/show_bug.cgi?id=188461
>+        <rdar://problem/33555052>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Before we try to schedule shutdown for database in operationAndTransactionTimerFired, we 
>+        should cancel the timer so no scheduleShutdownForClose will be running after this.
>+
>+        * Modules/indexeddb/server/UniqueIDBDatabase.cpp:
>+        (WebCore::IDBServer::UniqueIDBDatabase::scheduleShutdownForClose):
>+
> 2018-08-09  Saam Barati  <sbarati@apple.com>
> 
>         memoryFootprint should return size_t not optional<size_t>
>diff --git a/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp b/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp
>index 28da2a566252a1118d2f42864b8267f9c23f3af5..a6fede5076178e52108bf09a9d9a3896171328b4 100644
>--- a/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp
>+++ b/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp
>@@ -273,6 +273,8 @@ void UniqueIDBDatabase::scheduleShutdownForClose()
> {
>     ASSERT(isMainThread());
> 
>+    m_operationAndTransactionTimer.stop();
>+
>     RELEASE_ASSERT(!m_owningPointerForClose);
>     m_owningPointerForClose = m_server.closeAndTakeUniqueIDBDatabase(*this);
>

Actions: View | Formatted Diff | Diff

Attachments on bug 188461: 346881 | 346909 | 346910