Attachment 346907 Details for Bug 188473 – Patch

[patch] Patch

bug-188473-20180810100522.patch (text/plain), 2.19 KB, created by Daniel Bates on 2018-08-10 10:05:22 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Daniel Bates

Created: 2018-08-10 10:05:22 PDT

Size: 2.19 KB

patch

obsolete

>Subversion Revision: 234703
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 5beae2a31bd37f2cfddf518eb8684bae1b306128..40d032d97f2b42a41e5bd37d2aec296a5f1ab499 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-08-10  Daniel Bates  <dabates@apple.com>
>+
>+        webkit-patch setup-git-clone should set Git core editor to commit-log-editor
>+        https://bugs.webkit.org/show_bug.cgi?id=188473
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Have "webkit-patch setup-git-clone" set the Git core editor to "perl Tools/Scripts/commit-log-editor --regenerate-log"
>+        so that the Git commit message is generated from the ChangeLog for developers that manually
>+        generate their ChangeLog using prepare-ChangeLog.
>+
>+        * Scripts/webkitpy/tool/commands/setupgitclone.py:
>+        (SetupGitClone.execute):
>+
> 2018-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
> 
>         [iOS] fast/events/ios/contenteditable-autocapitalize.html is a flaky failure
>diff --git a/Tools/Scripts/webkitpy/tool/commands/setupgitclone.py b/Tools/Scripts/webkitpy/tool/commands/setupgitclone.py
>index 51f8e13a4bfacc42530ec21a2d5043d0db22f62c..81bb498bf6015546ea54cf23f7b86a38c3a61198 100644
>--- a/Tools/Scripts/webkitpy/tool/commands/setupgitclone.py
>+++ b/Tools/Scripts/webkitpy/tool/commands/setupgitclone.py
>@@ -46,7 +46,7 @@ class SetupGitClone(Command):
> 
>         username, email = self._get_username_and_email(tool)
> 
>-        # FIXME: We shouldn't be using a privatd method
>+        # FIXME: We shouldn't be using a private method.
>         run_git = tool.scm()._run_git
>         run_git(["pull"])
>         run_git(["svn", "init", "--prefix=origin/", "-T", "trunk", "http://svn.webkit.org/repository/webkit"])
>@@ -60,6 +60,8 @@ class SetupGitClone(Command):
>         run_git(["config", "diff.objcpp.xfuncname", "^[-+@a-zA-Z_].*$"])
>         run_git(["config", "diff.objcppheader.xfuncname", "^[@a-zA-Z_].*$"])
> 
>+        run_git(["config", "core.editor", "perl Tools/Scripts/commit-log-editor --regenerate-log"])
>+
>         if tool.user.confirm("Do you want to auto-color status, diff, and branch? (y/n)"):
>             run_git(["config", "color.status", "auto"])
>             run_git(["config", "color.diff", "auto"])

Actions: View | Formatted Diff | Diff

Attachments on bug 188473: 346907