Attachment 346902 Details for Bug 188468 – Patch

[patch] Patch

wd-alerts-on-script.diff (text/plain), 1.82 KB, created by Carlos Garcia Campos on 2018-08-10 05:38:16 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Carlos Garcia Campos

Created: 2018-08-10 05:38:16 PDT

Size: 1.82 KB

patch

obsolete

>diff --git a/Source/WebDriver/ChangeLog b/Source/WebDriver/ChangeLog
>index 825840c9ceb..bd41d2faf36 100644
>--- a/Source/WebDriver/ChangeLog
>+++ b/Source/WebDriver/ChangeLog
>@@ -1,3 +1,20 @@
>+2018-08-10  Carlos Garcia Campos  <cgarcia@igalia.com>
>+
>+        WebDriver: do not handle prompts that appear while running scripts
>+        https://bugs.webkit.org/show_bug.cgi?id=188468
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        This changed in the spec, we should just finish the script without handling the alert at all.
>+        https://github.com/w3c/webdriver/commit/afb578090bc95718debeab6a6821da8d12b952c8
>+
>+        "If at any point during the algorithm a user prompt appears, abort all subsequent substeps of this algorithm,
>+        and return success with data null."
>+        https://w3c.github.io/webdriver/#dfn-execute-a-function-body
>+
>+        * Session.cpp:
>+        (WebDriver::Session::executeScript):
>+
> 2018-08-10  Carlos Garcia Campos  <cgarcia@igalia.com>
> 
>         [GTK][WPE] WebDriver: do not use default browser arguments when browser binary has been provided
>diff --git a/Source/WebDriver/Session.cpp b/Source/WebDriver/Session.cpp
>index bfc73801eed..e766585bd0a 100644
>--- a/Source/WebDriver/Session.cpp
>+++ b/Source/WebDriver/Session.cpp
>@@ -1859,7 +1859,7 @@ void Session::executeScript(const String& script, RefPtr<JSON::Array>&& argument
>             if (response.isError || !response.responseObject) {
>                 auto result = CommandResult::fail(WTFMove(response.responseObject));
>                 if (result.errorCode() == CommandResult::ErrorCode::UnexpectedAlertOpen)
>-                    handleUnexpectedAlertOpen(WTFMove(completionHandler));
>+                    completionHandler(CommandResult::success());
>                 else
>                     completionHandler(WTFMove(result));
>                 return;

Flags:

zan: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 188468: 346902