Attachment 346882 Details for Bug 188463 – Patch

[patch] Patch

bug-188463-20180809175817.patch (text/plain), 2.34 KB, created by Sihui Liu on 2018-08-09 17:58:19 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Sihui Liu

Created: 2018-08-09 17:58:19 PDT

Size: 2.34 KB

patch

obsolete

>Subversion Revision: 234742
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index ec3a54bbc11f94136cd39735b1427dbf734e65d8..fa2f54bb027bcf942b4e9125ed48714eaf987408 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-08-09  Sihui Liu  <sihui_liu@apple.com>
>+
>+        Incorrect log message in NetworkSession when creating NetworkDataTask
>+        https://bugs.webkit.org/show_bug.cgi?id=188463
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
>+        (WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
>+
> 2018-08-09  Alex Christensen  <achristensen@webkit.org>
> 
>         Fix URLSchemeHandler.SyncXHR API test after r234735.
>diff --git a/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm b/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm
>index cdcfeddb7fb33943fa39ebec1bda4c6c93feeb37..822b40d24128922b5f3631efb9067982106b64fd 100644
>--- a/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm
>+++ b/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm
>@@ -222,12 +222,12 @@ NetworkDataTaskCocoa::NetworkDataTaskCocoa(NetworkSession& session, NetworkDataT
>         m_task = [cocoaSession.m_sessionWithCredentialStorage dataTaskWithRequest:nsRequest];
>         ASSERT(!cocoaSession.m_dataTaskMapWithCredentials.contains([m_task taskIdentifier]));
>         cocoaSession.m_dataTaskMapWithCredentials.add([m_task taskIdentifier], this);
>-        LOG(NetworkSession, "%llu Creating stateless NetworkDataTask with URL %s", [m_task taskIdentifier], nsRequest.URL.absoluteString.UTF8String);
>+        LOG(NetworkSession, "%llu Creating stateful NetworkDataTask with URL %s", [m_task taskIdentifier], nsRequest.URL.absoluteString.UTF8String);
>     } else {
>         m_task = [cocoaSession.m_statelessSession dataTaskWithRequest:nsRequest];
>         ASSERT(!cocoaSession.m_dataTaskMapWithoutState.contains([m_task taskIdentifier]));
>         cocoaSession.m_dataTaskMapWithoutState.add([m_task taskIdentifier], this);
>-        LOG(NetworkSession, "%llu Creating NetworkDataTask with URL %s", [m_task taskIdentifier], nsRequest.URL.absoluteString.UTF8String);
>+        LOG(NetworkSession, "%llu Creating stateless NetworkDataTask with URL %s", [m_task taskIdentifier], nsRequest.URL.absoluteString.UTF8String);
>     }
> 
>     if (shouldPreconnectOnly == PreconnectOnly::Yes) {

Actions: View | Formatted Diff | Diff

Attachments on bug 188463: 346882