Attachment 346877 Details for Bug 188459 – Patch

[patch] Patch

bug-188459-20180809171301.patch (text/plain), 1.74 KB, created by Daniel Bates on 2018-08-09 17:13:01 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Daniel Bates

Created: 2018-08-09 17:13:01 PDT

Size: 1.74 KB

patch

obsolete

>Subversion Revision: 234703
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index ebabcc3de7e0c3061fbdacfb77ee2dc3eabbfb74..0966ffea4c1b2738f39953d54cc8fbcd06f09147 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,18 @@
>+2018-08-09  Daniel Bates  <dabates@apple.com>
>+
>+        Cleanup: Remove unnecessary code to resume animations from CachedFrameBase::restore()
>+        https://bugs.webkit.org/show_bug.cgi?id=188459
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        It is unnessary for CachedFrameBase::restore() to explicitly resume animations on the
>+        document as it calls Document::resume(), which already does this.
>+
>+        No functionality changed. So, no new tests.
>+
>+        * history/CachedFrame.cpp:
>+        (WebCore::CachedFrameBase::restore):
>+
> 2018-08-09  Daniel Bates  <dabates@apple.com>
> 
>         Once <object> is hidden, its content won't be displayed again if its URL has fragment identifier ("#").
>diff --git a/Source/WebCore/history/CachedFrame.cpp b/Source/WebCore/history/CachedFrame.cpp
>index ed53f528046d6963402140ea7429be422efff7ba..3b34388eb1d62783d24b91c56c2673f196d567c1 100644
>--- a/Source/WebCore/history/CachedFrame.cpp
>+++ b/Source/WebCore/history/CachedFrame.cpp
>@@ -98,11 +98,6 @@ void CachedFrameBase::restore()
>     if (m_document->svgExtensions())
>         m_document->accessSVGExtensions().unpauseAnimations();
> 
>-    if (RuntimeEnabledFeatures::sharedFeatures().webAnimationsCSSIntegrationEnabled())
>-        m_document->timeline().resumeAnimations();
>-    else
>-        frame.animation().resumeAnimationsForDocument(m_document.get());
>-
>     m_document->resume(ReasonForSuspension::PageCache);
> 
>     // It is necessary to update any platform script objects after restoring the

Actions: View | Formatted Diff | Diff

Attachments on bug 188459: 346877