Attachment 346873 Details for Bug 188457 – [PATCH] Proposed Fix

[patch] [PATCH] Proposed Fix

elcap-1.patch (text/plain), 17.14 KB, created by Joseph Pecoraro on 2018-08-09 16:39:45 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Joseph Pecoraro

Created: 2018-08-09 16:39:45 PDT

Size: 17.14 KB

patch

obsolete

>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index dbdba41392b..1f258fa7732 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-08-09  Joseph Pecoraro  <pecoraro@apple.com>
>+
>+        Remove ElCapitan specific layout test expectations
>+        https://bugs.webkit.org/show_bug.cgi?id=188457
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * platform/mac-wk1/TestExpectations:
>+        * platform/mac-wk2/TestExpectations:
>+        * platform/mac/TestExpectations:
>+
> 2018-08-08  Joseph Pecoraro  <pecoraro@apple.com>
> 
>         Web Inspector: XHR content sometimes shows as error even though load succeeded
>diff --git a/LayoutTests/platform/mac-wk1/TestExpectations b/LayoutTests/platform/mac-wk1/TestExpectations
>index 83b18b67e5d..fc7239a1539 100644
>--- a/LayoutTests/platform/mac-wk1/TestExpectations
>+++ b/LayoutTests/platform/mac-wk1/TestExpectations
>@@ -363,9 +363,6 @@ webkit.org/b/158585 webgl/webgl-backing-store-size-update.html [ Pass Timeout ]
> [ Sierra+ ] accessibility/mac/document-attributes.html [ Failure ]
> [ Sierra+ ] accessibility/parent-delete.html [ Failure ]
> 
>-# rdar://problem/28017216
>-[ ElCapitan ] fast/inline-block/003.html [ Failure ]
>-
> # rdar://problem/26478296
> [ Sierra+ ] svg/hixie/text/003.html [ Failure ]
> 
>@@ -375,8 +372,6 @@ webkit.org/b/160101 userscripts/window-onerror-for-isolated-world-3.html [ Pass
> 
> webkit.org/b/105870 [ Debug ] webaudio/audionode-connect-order.html [ Pass Crash ]
> 
>-webkit.org/b/160227 [ ElCapitan Debug ] inspector/memory/tracking.html [ Pass Crash ]
>-
> # rdar://problem/27723718
> [ Sierra+ ] imported/blink/compositing/child-transform-with-anchor-point.html [ ImageOnlyFailure ]
> 
>@@ -400,8 +395,6 @@ http/tests/inspector/network/resource-sizes-network.html [ Failure ]
> http/tests/inspector/network/resource-sizes-memory-cache.html [ Failure ]
> http/tests/inspector/network/har/har-page.html [ Failure ]
> 
>-webkit.org/b/164491 [ ElCapitan ] fast/visual-viewport/rtl-zoomed-rects.html [ Failure ]
>-
> webkit.org/b/164933 http/tests/misc/link-rel-icon-beforeload.html [ Failure ]
> 
> webkit.org/b/165541 compositing/layer-creation/fixed-overlap-extent-rtl.html [ Failure ]
>diff --git a/LayoutTests/platform/mac-wk2/TestExpectations b/LayoutTests/platform/mac-wk2/TestExpectations
>index 0970c816032..4df068b8546 100644
>--- a/LayoutTests/platform/mac-wk2/TestExpectations
>+++ b/LayoutTests/platform/mac-wk2/TestExpectations
>@@ -337,8 +337,6 @@ webkit.org/b/150542 fast/forms/state-restore-per-form.html [ Pass Timeout ]
> 
> webkit.org/b/151709 [ Release ] http/tests/xmlhttprequest/workers/methods.html [ Pass Timeout ]
> 
>-webkit.org/b/155151 [ Debug ElCapitan ] media/track/track-cues-pause-on-exit.html [ Pass Timeout ]
>-
> webkit.org/b/155312 inspector/heap/getPreview.html [ Pass Timeout ]
> 
> webkit.org/b/156077 inspector/heap/getRemoteObject.html [ Pass Failure ]
>@@ -415,18 +413,6 @@ webkit.org/b/139828 svg/animations/animateMotion-additive-2d.svg [ Pass ImageOnl
> 
> [ Debug ] editing/undo/remove-css-property-and-remove-style.html [ Pass Failure ]
> 
>-# This test fails every time on El Capitan
>-[ ElCapitan ] fast/mediastream/MediaStream-video-element-video-tracks-disabled.html [ Skip ]
>-
>-webkit.org/b/175061 [ ElCapitan ] imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-worker.html [ Failure ]
>-webkit.org/b/175061 [ ElCapitan ] imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors.html [ Failure ]
>-webkit.org/b/175061 [ ElCapitan ] imported/w3c/web-platform-tests/fetch/api/cors/cors-basic.any.html [ Failure ]
>-webkit.org/b/175061 [ ElCapitan ] imported/w3c/web-platform-tests/fetch/api/cors/cors-basic.any.worker.html [ Failure ]
>-webkit.org/b/175061 [ ElCapitan ] imported/w3c/web-platform-tests/fetch/api/cors/cors-no-preflight.any.html [ Failure ]
>-webkit.org/b/175061 [ ElCapitan ] imported/w3c/web-platform-tests/fetch/api/cors/cors-no-preflight.any.worker.html [ Failure ]
>-webkit.org/b/175061 [ ElCapitan ] imported/w3c/web-platform-tests/fetch/api/cors/cors-origin.any.html [ Failure ]
>-webkit.org/b/175061 [ ElCapitan ] imported/w3c/web-platform-tests/fetch/api/cors/cors-origin.any.worker.html [ Failure ]
>-
> ### END OF (3) Unclassified failures
> ########################################
> 
>@@ -579,8 +565,6 @@ webkit.org/b/179455 [ Sierra+ ] fast/scrolling/rtl-scrollbars.html [ Pass ImageO
> [ Sierra+ ] fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement-2.html [ Pass ]
> webkit.org/b/162638 [ Sierra+ ] fast/scrolling/rtl-scrollbars-alternate-iframe-body-dir-attr-does-not-update-scrollbar-placement.html [ Pass ImageOnlyFailure ]
> [ Sierra+ ] fast/scrolling/rtl-scrollbars-animation-property.html [ Pass ]
>-# This test only produces an RTL token on Sierra.
>-[ ElCapitan ] fast/scrolling/rtl-scrollbars-animation-property.html [ Failure ]
> 
> # <rdar://problem/25063128>
> [ Sierra+ ] media/media-controls-drag-timeline-set-controls-property.html [ Pass Timeout ]
>@@ -634,7 +618,6 @@ webkit.org/b/163453 [ Sierra Release ] http/tests/security/contentSecurityPolicy
> webkit.org/b/163702 platform/mac-wk2/plugins/muted-state.html [ Failure ]
> 
> webkit.org/b/164870 [ Debug ] imported/w3c/web-platform-tests/IndexedDB/idbcursor_iterating.htm [ Pass Failure ]
>-webkit.org/b/164870 [ ElCapitan Release ] imported/w3c/web-platform-tests/IndexedDB/idbcursor_iterating.htm [ Pass Failure ]
> 
> webkit.org/b/165352 fast/dom/Window/window-resize-contents.html [ Pass Timeout ]
> 
>@@ -653,20 +636,12 @@ webkit.org/b/168336 [ Debug ] imported/w3c/web-platform-tests/streams/readable-s
> webkit.org/b/168089 [ Release ] animations/trigger-container-scroll-empty.html [ Pass Failure ]
> webkit.org/b/168089 [ Release ] legacy-animation-engine/animations/trigger-container-scroll-empty.html [ Pass Failure ]
> 
>-webkit.org/b/168391 [ ElCapitan Debug ] storage/indexeddb/modern/idbcursor-continue-primary-key-1.html [ Pass Timeout ]
>-
>-
>-webkit.org/b/168380 [ ElCapitan Debug ] imported/w3c/web-platform-tests/IndexedDB/idb-binary-key-roundtrip.htm [ Pass Failure ]
>-
> # Skipped because Mac doesn't have a key to show the context menu
> fast/events/context-activated-by-key-event.html [ Skip ]
> 
> webkit.org/b/169621 imported/w3c/web-platform-tests/IndexedDB/fire-error-event-exception.html [ Pass Failure ]
> webkit.org/b/169760 imported/w3c/web-platform-tests/IndexedDB/fire-success-event-exception.html [ Pass Failure ]
> 
>-# Media loading via network cache requires Sierra or newer.
>-[ ElCapitan ] http/tests/cache/disk-cache/disk-cache-media-small.html [ Failure ]
>-
> compositing/tiling/non-visible-window-tile-coverage.html [ Pass ]
> 
> webkit.org/b/170629  memory/memory-pressure-simulation.html [ Pass Failure ]
>@@ -702,19 +677,6 @@ webkit.org/b/172666 [ Debug ] fast/images/slower-decoding-than-animation-image.h
> 
> webkit.org/b/173188 fast/mediastream/getUserMedia-grant-persistency3.html [ Pass Failure ]
> 
>-webkit.org/b/172834 [ ElCapitan ] imported/w3c/web-platform-tests/IndexedDB/idbindex_getAll.html [ Pass Failure ]
>-
>-webkit.org/b/172834 [ ElCapitan ] imported/w3c/web-platform-tests/IndexedDB/idbindex_getAllKeys.html [ Pass Failure ]
>-
>-webkit.org/b/172834 [ ElCapitan ] imported/w3c/web-platform-tests/IndexedDB/idbobjectstore_getAllKeys.html [ Pass Failure ]
>-
>-# Beacon is not supported on WK2 for the non NETWORK_SESSION code path.
>-[ ElCapitan ] http/tests/blink/sendbeacon/ [ Skip ]
>-[ ElCapitan ] http/tests/inspector/network/beacon-type.html [ Skip ]
>-[ ElCapitan ] http/wpt/beacon/ [ Skip ]
>-[ ElCapitan ] imported/blink/fast/beacon/ [ Skip ]
>-[ ElCapitan ] imported/w3c/web-platform-tests/beacon/ [ Skip ]
>-
> webkit.org/b/172201 webaudio/silent-audio-interrupted-in-background.html [ Pass Timeout ]
> 
> webkit.org/b/167757 workers/bomb.html [ Pass Timeout ]
>@@ -811,12 +773,8 @@ http/tests/security/strip-referrer-to-origin-for-third-party-requests-in-private
> # Link preconnect is disabled on pre-High Sierra because the CFNetwork SPI is missing.
> [ ElCapitan Sierra ] http/tests/preconnect [ Skip ]
> 
>-webkit.org/b/176486 [ ElCapitan Debug ] imported/w3c/web-platform-tests/background-fetch/interfaces-worker.https.html [ Pass Failure ]
>-
> webkit.org/b/171839 [ Debug ] tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-vertical-then-horizontal.html [ Pass Failure ]
> 
>-webkit.org/b/177214 [ ElCapitan Debug ] imported/w3c/web-platform-tests/FileAPI/historical.https.html [ Pass Failure ]
>-
> webkit.org/b/177687 http/tests/inspector/network/resource-sizes-memory-cache.html [ Pass Failure ]
> 
> webkit.org/b/178472 http/tests/resourceLoadStatistics/prevalent-resource-handled-keydown.html [ Skip ]
>diff --git a/LayoutTests/platform/mac/TestExpectations b/LayoutTests/platform/mac/TestExpectations
>index 595856aa134..3dc439a514e 100644
>--- a/LayoutTests/platform/mac/TestExpectations
>+++ b/LayoutTests/platform/mac/TestExpectations
>@@ -980,10 +980,6 @@ webkit.org/b/136109 fast/multicol/mixed-opacity-fixed-test.html  [ ImageOnlyFail
> # FIXME: Needs bugzilla (<rdar://problem/18273139>)
> storage/websql/sql-error-codes.html [ Failure ]
> 
>-# Language-specific font fallback is disabled on certain versions of OS X
>-webkit.org/b/147390 [ ElCapitan ] fast/text/fallback-language-han.html [ ImageOnlyFailure ]
>-webkit.org/b/147390 [ ElCapitan ] fast/text/fallback-language-han-2.html [ ImageOnlyFailure ]
>-
> webkit.org/b/137589 compositing/hidpi-compositing-vs-non-compositing-check-on-testing-framework.html [ Pass ImageOnlyFailure ]
> 
> # These tests fail on machines with AMD (ATI) graphics cards - that is, on EWS and locally.
>@@ -1050,10 +1046,6 @@ http/tests/security/contentSecurityPolicy/media-src-allowed.html [ Skip ]
> 
> webkit.org/b/150978 fast/canvas/webgl/oes-texture-half-float-linear.html [ Pass Failure ]
> 
>-# These tests rely on iOS-specific font fallback.
>-[ ElCapitan ] fast/text/international/system-language/arabic-glyph-cache-fill-combine.html [ Pass ImageOnlyFailure ]
>-[ ElCapitan ] fast/text/arabic-blacklisted-expected.html [ Pass ImageOnlyFailure ]
>-
> webkit.org/b/173931 inspector/canvas/context-attributes.html [ Pass Timeout ]
> webkit.org/b/178028 inspector/canvas/create-context-2d.html [ Pass Timeout ]
> webkit.org/b/174066 inspector/canvas/create-context-webgl2.html [ Pass Timeout ]
>@@ -1148,27 +1140,12 @@ webkit.org/b/150806 imported/w3c/web-platform-tests/XMLHttpRequest/send-timeout-
> webkit.org/b/150823 imported/w3c/web-platform-tests/XMLHttpRequest/getresponseheader-chunked-trailer.htm [ Pass Failure ]
> webkit.org/b/159724 [ Debug ] imported/w3c/web-platform-tests/XMLHttpRequest/send-redirect-post-upload.htm [ Skip ]
> 
>-# WOFF2 is only supported on certain Operating Systems.
>-webkit.org/b/150830 [ ElCapitan ] fast/text/woff2.html [ ImageOnlyFailure ]
>-
> webkit.org/b/162668 fast/text/woff2-totalsfntsize.html [ ImageOnlyFailure ]
> 
> webkit.org/b/140217 http/tests/navigation/forward-and-cancel.html [ Pass Failure ]
> 
> webkit.org/b/151469 imported/w3c/web-platform-tests/html/syntax/parsing/template/creating-an-element-for-the-token/template-owner-document.html [ Pass Crash ]
> 
>-webkit.org/b/152009 [ Debug ElCapitan ] fast/canvas/canvas-too-large-to-draw.html [ Skip ]
>-
>-# El Capitan does not support font feature coverage queries.
>-[ ElCapitan ] css3/font-variant-small-caps-synthesis-coverage.html [ ImageOnlyFailure ]
>-[ ElCapitan ] css3/font-variant-petite-caps-synthesis-coverage.html [ ImageOnlyFailure ]
>-[ ElCapitan ] fast/text/all-small-caps-whitespace.html [ ImageOnlyFailure ]
>-[ ElCapitan ] css3/font-variant-synthesis-jdaggett.html [ ImageOnlyFailure ]
>-
>-# Temporarily disable font feature synthesis tests.
>-[ ElCapitan ] css3/font-variant-small-caps-synthesis.html [ ImageOnlyFailure ]
>-[ ElCapitan ] css3/font-variant-petite-caps-synthesis.html [ ImageOnlyFailure ]
>-
> webkit.org/b/153086 sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.3/15.1.3.3_encodeURI/S15.1.3.3_A2.4_T2.html [ Pass Crash ]
> 
> webkit.org/b/153809 transitions/clip-path-transitions.html [ Pass Failure ]
>@@ -1197,10 +1174,6 @@ webkit.org/b/155092 js/arraybuffer-wrappers.html [ Pass Timeout ]
> webkit.org/b/155140 js/promises-tests/promises-tests-2-3-3.html [ Pass Failure ]
> webkit.org/b/187103 js/error-should-not-strong-reference-global-object.html [ Pass Failure ]
> 
>-# Content Security Policy for media redirects is not supported on some OSes.
>-[ ElCapitan ] http/tests/security/contentSecurityPolicy/audio-redirect-blocked.html [ Failure ]
>-[ ElCapitan ] http/tests/security/contentSecurityPolicy/video-redirect-blocked.html [ Failure ]
>-
> webkit.org/b/155505 [ ElCapitan+ ] http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html [ Skip ]
> webkit.org/b/155505 [ ElCapitan+ ] http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-video.html [ Skip ]
> 
>@@ -1226,7 +1199,6 @@ webkit.org/b/158534 css3/filters/backdrop/dynamic-backdrop-filter-change.html [
> # These tests hardcode platform-specific font aliases.
> webkit.org/b/158649 [ ElCapitan+ ] fast/text/chinese-font-name-aliases-2.html [ ImageOnlyFailure ]
> webkit.org/b/159003 [ Sierra+ ] fast/text/font-cursive-italic-cjk.html [ Skip ]
>-webkit.org/b/159003 [ ElCapitan ] fast/text/font-cursive-italic-cjk-2.html [ ImageOnlyFailure ]
> 
> webkit.org/b/158889 media/video-controls-show-on-kb-or-ax-event.html [ Pass Failure Timeout ]
> 
>@@ -1378,20 +1350,6 @@ webkit.org/b/168087 media/video-zoom.html [ Pass Failure ]
> webkit.org/b/168094 imported/w3c/web-platform-tests/media-source/SourceBuffer-abort.html [ Pass Failure ]
> webkit.org/b/167975 imported/w3c/web-platform-tests/media-source/SourceBuffer-abort-removed.html [ Pass Failure ]
> 
>-# Resource Timing data not available in El Capitan.
>-webkit.org/b/168415 [ ElCapitan ] http/wpt/resource-timing/rt-cors.html [ Skip ]
>-webkit.org/b/168415 [ ElCapitan ] http/wpt/resource-timing/rt-cors.worker.html [ Skip ]
>-
>-# Resource Timing networking data not available without Network Session.
>-[ ElCapitan ] http/wpt/resource-timing/rt-nextHopProtocol.html [ Failure ]
>-[ ElCapitan ] http/wpt/resource-timing/rt-nextHopProtocol.worker.html [ Failure ]
>-
>-# Request Header networking data not available without Network Session.
>-[ ElCapitan ] http/tests/inspector/network/resource-request-headers.html [ Failure ]
>-[ ElCapitan ] http/tests/inspector/network/har/har-page.html [ Failure ]
>-
>-[ ElCapitan ] http/tests/inspector/network/ping-type.html [ Skip ]
>-
> # <rdar://problem/30610988>
> [ Sierra+ ] imported/w3c/web-platform-tests/fetch/api/redirect/redirect-count-cross-origin.html [ Failure ]
> [ Sierra+ ] imported/w3c/web-platform-tests/fetch/api/redirect/redirect-count-worker.html [ Failure ]
>@@ -1431,8 +1389,6 @@ webkit.org/b/170177 fast/images/reset-image-animation.html [ Pass Failure ]
> 
> webkit.org/b/168390 fast/images/slower-animation-than-decoding-image.html [ Pass Failure ]
> 
>-webkit.org/b/170493 [ ElCapitan ] imported/w3c/web-platform-tests/fetch/api/response/response-trailer.html [ Pass Failure ]
>-
> webkit.org/b/170831 media/track/track-cue-rendering-rtl.html [ Pass Timeout ]
> 
> webkit.org/b/165553 media/media-controls-timeline-updates-when-hovered.html [ Pass Failure ]
>@@ -1445,8 +1401,6 @@ webkit.org/b/171760 imported/w3c/i18n/bidi/bidi-plaintext-011.html [ ImageOnlyFa
> 
> webkit.org/b/171886 imported/w3c/web-platform-tests/streams/readable-byte-streams/general.html [ Pass Failure ]
> 
>-webkit.org/b/172469 [ ElCapitan ] imported/w3c/web-platform-tests/WebCryptoAPI/import_export/test_rsa_importKey.https.html [ Timeout ]
>-
> # These tests are iOS-specific
> media/modern-media-controls/audio/audio-controls-styles.html [ Skip ]
> media/modern-media-controls/ios-inline-media-controls [ Skip ]
>@@ -1472,8 +1426,6 @@ webkit.org/b/178127 media/modern-media-controls/media-controller/media-controlle
> # on iOS, and the bug it was created to regression-test was iOS-only, so there is no hurry to make it work on Mac.
> media/modern-media-controls/media-documents/background-color-and-centering.html [ Pass ImageOnlyFailure ]
> 
>-# These tests use Picture-in-Picture which isn't supported on El Capitan.
>-[ ElCapitan ] media/modern-media-controls/placard-support/placard-support-pip.html [ Skip ]
> media/modern-media-controls/pip-support/ipad [ Skip ]
> 
> webkit.org/b/169158 media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html [ Skip ]
>@@ -1483,8 +1435,6 @@ webkit.org/b/170907 [ Debug ] imported/w3c/web-platform-tests/WebCryptoAPI/deriv
> webkit.org/b/173328 [ ElCapitan Sierra ] fast/text/system-font-fallback-emoji.html [ Failure ]
> webkit.org/b/173328 [ ElCapitan Sierra ] fast/text/system-font-fallback.html [ ImageOnlyFailure ]
> 
>-webkit.org/b/313156 [ ElCapitan ] fast/text/system-font-japanese-synthetic-italic.html [ ImageOnlyFailure ]
>-
> webkit.org/b/178083 media/media-source/media-source-paint-to-canvas.html [ Failure ]
> 
> webkit.org/b/173068 imported/w3c/web-platform-tests/IndexedDB/idbobjectstore_getKey.html [ Pass Failure ]
>@@ -1659,9 +1609,6 @@ webkit.org/b/172052 [ Debug ] imported/w3c/web-platform-tests/html/webappapis/ti
> # <rdar://problem/33850189>
> [ HighSierra+ ] http/tests/websocket/tests/hybi/deflate-frame-parameter.html [ Failure ]
> 
>-# Release logging not supported
>-[ ElCapitan ] inspector/console/webcore-logging.html [ Skip ]
>-
> webkit.org/b/177319 imported/w3c/web-platform-tests/html/semantics/forms/the-form-element/form-elements-filter.html [ Failure ]
> 
> webkit.org/b/177322 imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/parsing.html [ Pass Failure ]

Actions: View | Formatted Diff | Diff

Attachments on bug 188457: 346873